• Benedikt Meurer's avatar
    [debug] Make JSArrayBuffer (pre)views into internal properties. · 2cab7ae9
    Benedikt Meurer authored
    For JSArrayBuffer instances (which map to both v8::ArrayBuffer and
    v8::SharedArrayBuffer), we add a couple of synthetic views to its
    ValueMirror to make it easy for developers to peak into the contents of
    the JSArrayBuffer. These were previously real properties, but that's
    just wrong (both intuitively and semantically), and they should instead
    be internal properties.
    
    Drive-by-fix: The [[IsDetached]] internal property should only be shown
    on actually detached JSArrayBuffer's to reduce visual clutter. And for
    detached JSArrayBuffers creating views on them throws TypeErrors per
    specification, so we shouldn't attempt to display views on them.
    
    Bug: v8:9308, chromium:1162229
    Change-Id: Ia006de7873ca4b27aae7d00d46e1b69d2e326449
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2606047
    Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
    Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
    Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#71892}
    2cab7ae9
Name
Last commit
Last update
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...