• Clemens Hammacher's avatar
    Remove FixedArray::GetValue · 2aa0f934
    Clemens Hammacher authored
    The semantics of that method are not obvious (it returns an empty
    MaybeHandle if the element is undefined, otherwise it assumes it is of
    type T). Since there is only a single use of that method in the whole
    code base, just having that logic there explicitly is much simpler.
    
    Potential future uses of that method are probably also easier to
    understand if they just to the checks explicitly.
    
    Drive-by: Document semantics of {FixedArray::GetValueChecked}. Also for
    this method it's quesionable whether it is useful overall.
    Drive-by^2: Avoid else after return (see style guide).
    
    R=mstarzinger@chromium.org
    
    Bug: v8:9183
    Change-Id: I88dcb0f080d728bbe55932f17cf4d7eb25ab5928
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1619761
    Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
    Reviewed-by: 's avatarMichael Starzinger <mstarzinger@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#61686}
    2aa0f934
Name
Last commit
Last update
..
api Loading commit data...
arm Loading commit data...
arm64 Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
extensions Loading commit data...
heap Loading commit data...
ia32 Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
mips Loading commit data...
mips64 Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
ppc Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
runtime Loading commit data...
s390 Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
wasm Loading commit data...
x64 Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
OWNERS Loading commit data...
accessors.cc Loading commit data...
accessors.h Loading commit data...
address-map.cc Loading commit data...
address-map.h Loading commit data...
allocation-site-scopes-inl.h Loading commit data...
allocation-site-scopes.h Loading commit data...
allocation.cc Loading commit data...
allocation.h Loading commit data...
arguments-inl.h Loading commit data...
arguments.cc Loading commit data...
arguments.h Loading commit data...
assert-scope.cc Loading commit data...
assert-scope.h Loading commit data...
bit-vector.cc Loading commit data...
bit-vector.h Loading commit data...
boxed-float.h Loading commit data...
callable.h Loading commit data...
cancelable-task.cc Loading commit data...
cancelable-task.h Loading commit data...
checks.h Loading commit data...
compilation-statistics.cc Loading commit data...
compilation-statistics.h Loading commit data...
contexts-inl.h Loading commit data...
contexts.cc Loading commit data...
contexts.h Loading commit data...
detachable-vector.cc Loading commit data...
detachable-vector.h Loading commit data...
execution.cc Loading commit data...
execution.h Loading commit data...
external-reference-table.cc Loading commit data...
external-reference-table.h Loading commit data...
external-reference.cc Loading commit data...
external-reference.h Loading commit data...
feedback-vector-inl.h Loading commit data...
feedback-vector.cc Loading commit data...
feedback-vector.h Loading commit data...
flag-definitions.h Loading commit data...
flags.cc Loading commit data...
flags.h Loading commit data...
frame-constants.h Loading commit data...
frames-inl.h Loading commit data...
frames.cc Loading commit data...
frames.h Loading commit data...
function-kind.h Loading commit data...
futex-emulation.cc Loading commit data...
futex-emulation.h Loading commit data...
global-handles.cc Loading commit data...
global-handles.h Loading commit data...
globals.h Loading commit data...
handles-inl.h Loading commit data...
handles.cc Loading commit data...
handles.h Loading commit data...
hash-seed-inl.h Loading commit data...
heap-symbols.h Loading commit data...
identity-map.cc Loading commit data...
identity-map.h Loading commit data...
isolate-data.h Loading commit data...
isolate-inl.h Loading commit data...
isolate.cc Loading commit data...
isolate.h Loading commit data...
keys.cc Loading commit data...
keys.h Loading commit data...
locked-queue-inl.h Loading commit data...
locked-queue.h Loading commit data...
maybe-handles-inl.h Loading commit data...
maybe-handles.h Loading commit data...
memcopy.cc Loading commit data...
memcopy.h Loading commit data...
message-template.h Loading commit data...
messages.cc Loading commit data...
messages.h Loading commit data...
microtask-queue.cc Loading commit data...
microtask-queue.h Loading commit data...
objects-body-descriptors-inl.h Loading commit data...
objects-body-descriptors.h Loading commit data...
objects-definitions.h Loading commit data...
objects-inl.h Loading commit data...
objects.cc Loading commit data...
objects.h Loading commit data...
ostreams.cc Loading commit data...
ostreams.h Loading commit data...
pending-compilation-error-handler.cc Loading commit data...
pending-compilation-error-handler.h Loading commit data...
pointer-with-payload.h Loading commit data...
ptr-compr-inl.h Loading commit data...
ptr-compr.h Loading commit data...
roots-inl.h Loading commit data...
roots.cc Loading commit data...
roots.h Loading commit data...
runtime-profiler.cc Loading commit data...
runtime-profiler.h Loading commit data...
simulator-base.cc Loading commit data...
simulator-base.h Loading commit data...
simulator.h Loading commit data...
splay-tree-inl.h Loading commit data...
splay-tree.h Loading commit data...
task-utils.cc Loading commit data...
task-utils.h Loading commit data...
thread-id.cc Loading commit data...
thread-id.h Loading commit data...
thread-local-top.cc Loading commit data...
thread-local-top.h Loading commit data...
type-hints.cc Loading commit data...
type-hints.h Loading commit data...
utils-inl.h Loading commit data...
utils.cc Loading commit data...
utils.h Loading commit data...
v8.cc Loading commit data...
v8.h Loading commit data...
v8dll-main.cc Loading commit data...
v8memory.h Loading commit data...
v8threads.cc Loading commit data...
v8threads.h Loading commit data...
value-serializer.cc Loading commit data...
value-serializer.h Loading commit data...
vector-slot-pair.cc Loading commit data...
vector-slot-pair.h Loading commit data...
vector.h Loading commit data...
version.cc Loading commit data...
version.h Loading commit data...
visitors.cc Loading commit data...
visitors.h Loading commit data...
vm-state-inl.h Loading commit data...
vm-state.h Loading commit data...