• Clemens Hammacher's avatar
    Remove FixedArray::GetValue · 2aa0f934
    Clemens Hammacher authored
    The semantics of that method are not obvious (it returns an empty
    MaybeHandle if the element is undefined, otherwise it assumes it is of
    type T). Since there is only a single use of that method in the whole
    code base, just having that logic there explicitly is much simpler.
    
    Potential future uses of that method are probably also easier to
    understand if they just to the checks explicitly.
    
    Drive-by: Document semantics of {FixedArray::GetValueChecked}. Also for
    this method it's quesionable whether it is useful overall.
    Drive-by^2: Avoid else after return (see style guide).
    
    R=mstarzinger@chromium.org
    
    Bug: v8:9183
    Change-Id: I88dcb0f080d728bbe55932f17cf4d7eb25ab5928
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1619761
    Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
    Reviewed-by: 's avatarMichael Starzinger <mstarzinger@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#61686}
    2aa0f934
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...