• Shu-yu Guo's avatar
    Revert "[regexp] Reorganize and deduplicate in the regexp parser" · 294a77ea
    Shu-yu Guo authored
    This reverts commit 7d849870.
    
    Reason for revert: Will block roll. Broke error message tests upstream:
    
    https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Blink%20Win/6635/overview
    
    
    Original change's description:
    > [regexp] Reorganize and deduplicate in the regexp parser
    >
    > The parser is organized in a somewhat tricky way s.t. it can be
    > hard to map the implementation back to the specified grammar.
    >
    > In particular, the logic for CharacterClassEscape, ClassEscape,
    > and CharacterEscape was implemented twice - once inside a character
    > class, once outside.
    >
    > This CL refactors related logic to have only a single implementation.
    >
    > As a drive-by, fix one related inconsistency related to \k inside
    > a character class.
    >
    > Fixed: v8:10602
    > Change-Id: I5858840159694fa6f8d1aa857027db80754e3dfd
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3178966
    > Reviewed-by: Mathias Bynens <mathias@chromium.org>
    > Commit-Queue: Jakob Gruber <jgruber@chromium.org>
    > Cr-Commit-Position: refs/heads/main@{#77114}
    
    Change-Id: Ic7404d6c9f0e6ea51e8cd8f1ab672856dca0c637
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3190692
    Auto-Submit: Shu-yu Guo <syg@chromium.org>
    Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
    Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/main@{#77125}
    294a77ea
Name
Last commit
Last update
..
benchmarks Loading commit data...
bigint Loading commit data...
cctest Loading commit data...
common Loading commit data...
debugger Loading commit data...
debugging Loading commit data...
fuzzer Loading commit data...
fuzzilli Loading commit data...
inspector Loading commit data...
intl Loading commit data...
js-perf-test Loading commit data...
memory Loading commit data...
message Loading commit data...
mjsunit Loading commit data...
mkgrokdump Loading commit data...
mozilla Loading commit data...
test262 Loading commit data...
torque Loading commit data...
unittests Loading commit data...
wasm-api-tests Loading commit data...
wasm-js Loading commit data...
wasm-spec-tests Loading commit data...
webkit Loading commit data...
BUILD.gn Loading commit data...
OWNERS Loading commit data...