• Shu-yu Guo's avatar
    Revert "[regexp] Reorganize and deduplicate in the regexp parser" · 294a77ea
    Shu-yu Guo authored
    This reverts commit 7d849870.
    
    Reason for revert: Will block roll. Broke error message tests upstream:
    
    https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Blink%20Win/6635/overview
    
    
    Original change's description:
    > [regexp] Reorganize and deduplicate in the regexp parser
    >
    > The parser is organized in a somewhat tricky way s.t. it can be
    > hard to map the implementation back to the specified grammar.
    >
    > In particular, the logic for CharacterClassEscape, ClassEscape,
    > and CharacterEscape was implemented twice - once inside a character
    > class, once outside.
    >
    > This CL refactors related logic to have only a single implementation.
    >
    > As a drive-by, fix one related inconsistency related to \k inside
    > a character class.
    >
    > Fixed: v8:10602
    > Change-Id: I5858840159694fa6f8d1aa857027db80754e3dfd
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3178966
    > Reviewed-by: Mathias Bynens <mathias@chromium.org>
    > Commit-Queue: Jakob Gruber <jgruber@chromium.org>
    > Cr-Commit-Position: refs/heads/main@{#77114}
    
    Change-Id: Ic7404d6c9f0e6ea51e8cd8f1ab672856dca0c637
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3190692
    Auto-Submit: Shu-yu Guo <syg@chromium.org>
    Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
    Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/main@{#77125}
    294a77ea
Name
Last commit
Last update
.github Loading commit data...
bazel Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.bazelrc Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.mailmap Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.bazel Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LOONG_OWNERS Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
WORKSPACE Loading commit data...
codereview.settings Loading commit data...