• vabr's avatar
    Fix error message for invalid buffer offset · 1dd803f9
    vabr authored
    The constructor for TypedArray in js/typedarray.js emitted
    kInvalidTypedArrayAlignment if the array offset exceeded the size of the
    underlying buffer. This seems like a typo introduced in
    https://codereview.chromium.org/2090353003.
    
    The error message to be emitted instead coincides with the already existing
    kInvalidDataViewOffset. The message string is independent of whether the
    object in question is a DataView or a typed array, so this CL:
      (1) renames kInvalidDataViewOffset to just kInvalidOffset, and
      (2) uses kInvalidOffset instead of kInvalidTypedArrayAlignment for cases
          when the TypedArray is constructed with an offset exceeding the buffer
          size.
    
    BUG=v8:5733
    TEST=Run d8, execute "new Uint8Array(new ArrayBuffer(1),2)", see the error message mention the invalid offset 2.
    
    Review-Url: https://codereview.chromium.org/2692753002
    Cr-Commit-Position: refs/heads/master@{#43151}
    1dd803f9
Name
Last commit
Last update
..
arm Loading commit data...
arm64 Loading commit data...
ia32 Loading commit data...
mips Loading commit data...
mips64 Loading commit data...
ppc Loading commit data...
s390 Loading commit data...
x64 Loading commit data...
x87 Loading commit data...
builtins-api.cc Loading commit data...
builtins-arguments.cc Loading commit data...
builtins-arguments.h Loading commit data...
builtins-array.cc Loading commit data...
builtins-arraybuffer.cc Loading commit data...
builtins-async-function.cc Loading commit data...
builtins-async.cc Loading commit data...
builtins-async.h Loading commit data...
builtins-boolean.cc Loading commit data...
builtins-call.cc Loading commit data...
builtins-callsite.cc Loading commit data...
builtins-constructor.cc Loading commit data...
builtins-constructor.h Loading commit data...
builtins-conversion.cc Loading commit data...
builtins-dataview.cc Loading commit data...
builtins-date.cc Loading commit data...
builtins-debug.cc Loading commit data...
builtins-error.cc Loading commit data...
builtins-function.cc Loading commit data...
builtins-generator.cc Loading commit data...
builtins-global.cc Loading commit data...
builtins-handler.cc Loading commit data...
builtins-ic.cc Loading commit data...
builtins-internal.cc Loading commit data...
builtins-interpreter.cc Loading commit data...
builtins-json.cc Loading commit data...
builtins-math.cc Loading commit data...
builtins-number.cc Loading commit data...
builtins-object.cc Loading commit data...
builtins-object.h Loading commit data...
builtins-promise.cc Loading commit data...
builtins-promise.h Loading commit data...
builtins-proxy.cc Loading commit data...
builtins-reflect.cc Loading commit data...
builtins-regexp.cc Loading commit data...
builtins-regexp.h Loading commit data...
builtins-sharedarraybuffer.cc Loading commit data...
builtins-string.cc Loading commit data...
builtins-symbol.cc Loading commit data...
builtins-typedarray.cc Loading commit data...
builtins-utils.h Loading commit data...
builtins.cc Loading commit data...
builtins.h Loading commit data...