• vabr's avatar
    Fix error message for invalid buffer offset · 1dd803f9
    vabr authored
    The constructor for TypedArray in js/typedarray.js emitted
    kInvalidTypedArrayAlignment if the array offset exceeded the size of the
    underlying buffer. This seems like a typo introduced in
    https://codereview.chromium.org/2090353003.
    
    The error message to be emitted instead coincides with the already existing
    kInvalidDataViewOffset. The message string is independent of whether the
    object in question is a DataView or a typed array, so this CL:
      (1) renames kInvalidDataViewOffset to just kInvalidOffset, and
      (2) uses kInvalidOffset instead of kInvalidTypedArrayAlignment for cases
          when the TypedArray is constructed with an offset exceeding the buffer
          size.
    
    BUG=v8:5733
    TEST=Run d8, execute "new Uint8Array(new ArrayBuffer(1),2)", see the error message mention the invalid offset 2.
    
    Review-Url: https://codereview.chromium.org/2692753002
    Cr-Commit-Position: refs/heads/master@{#43151}
    1dd803f9
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
gypfiles Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...