• Maya Lekova's avatar
    Revert "Reland "[deoptimizer] Change deopt entries into builtins"" · 7c7aa4fa
    Maya Lekova authored
    This reverts commit fbfa9bf4.
    
    Reason for revert: Seems to break arm64 sim CFI build (please see DeoptExitSizeIfFixed) - https://ci.chromium.org/p/v8/builders/ci/V8%20Linux%20-%20arm64%20-%20sim%20-%20CFI/2808
    
    Original change's description:
    > Reland "[deoptimizer] Change deopt entries into builtins"
    >
    > This is a reland of 7f58ced7
    >
    > It fixes the different exit size emitted on x64/Atom CPUs due to
    > performance tuning in TurboAssembler::Call. Additionally, add
    > cctests to verify the fixed size exits.
    >
    > Original change's description:
    > > [deoptimizer] Change deopt entries into builtins
    > >
    > > While the overall goal of this commit is to change deoptimization
    > > entries into builtins, there are multiple related things happening:
    > >
    > > - Deoptimization entries, formerly stubs (i.e. Code objects generated
    > >   at runtime, guaranteed to be immovable), have been converted into
    > >   builtins. The major restriction is that we now need to preserve the
    > >   kRootRegister, which was formerly used on most architectures to pass
    > >   the deoptimization id. The solution differs based on platform.
    > > - Renamed DEOPT_ENTRIES_OR_FOR_TESTING code kind to FOR_TESTING.
    > > - Removed heap/ support for immovable Code generation.
    > > - Removed the DeserializerData class (no longer needed).
    > > - arm64: to preserve 4-byte deopt exits, introduced a new optimization
    > >   in which the final jump to the deoptimization entry is generated
    > >   once per Code object, and deopt exits can continue to emit a
    > >   near-call.
    > > - arm,ia32,x64: change to fixed-size deopt exits. This reduces exit
    > >   sizes by 4/8, 5, and 5 bytes, respectively.
    > >
    > > On arm the deopt exit size is reduced from 12 (or 16) bytes to 8 bytes
    > > by using the same strategy as on arm64 (recalc deopt id from return
    > > address). Before:
    > >
    > >  e300a002       movw r10, <id>
    > >  e59fc024       ldr ip, [pc, <entry offset>]
    > >  e12fff3c       blx ip
    > >
    > > After:
    > >
    > >  e59acb35       ldr ip, [r10, <entry offset>]
    > >  e12fff3c       blx ip
    > >
    > > On arm64 the deopt exit size remains 4 bytes (or 8 bytes in same cases
    > > with CFI). Additionally, up to 4 builtin jumps are emitted per Code
    > > object (max 32 bytes added overhead per Code object). Before:
    > >
    > >  9401cdae       bl <entry offset>
    > >
    > > After:
    > >
    > >  # eager deoptimization entry jump.
    > >  f95b1f50       ldr x16, [x26, <eager entry offset>]
    > >  d61f0200       br x16
    > >  # lazy deoptimization entry jump.
    > >  f95b2b50       ldr x16, [x26, <lazy entry offset>]
    > >  d61f0200       br x16
    > >  # the deopt exit.
    > >  97fffffc       bl <eager deoptimization entry jump offset>
    > >
    > > On ia32 the deopt exit size is reduced from 10 to 5 bytes. Before:
    > >
    > >  bb00000000     mov ebx,<id>
    > >  e825f5372b     call <entry>
    > >
    > > After:
    > >
    > >  e8ea2256ba     call <entry>
    > >
    > > On x64 the deopt exit size is reduced from 12 to 7 bytes. Before:
    > >
    > >  49c7c511000000 REX.W movq r13,<id>
    > >  e8ea2f0700     call <entry>
    > >
    > > After:
    > >
    > >  41ff9560360000 call [r13+<entry offset>]
    > >
    > > Bug: v8:8661,v8:8768
    > > Change-Id: I13e30aedc360474dc818fecc528ce87c3bfeed42
    > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2465834
    > > Commit-Queue: Jakob Gruber <jgruber@chromium.org>
    > > Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
    > > Reviewed-by: Tobias Tebbi <tebbi@chromium.org>
    > > Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
    > > Cr-Commit-Position: refs/heads/master@{#70597}
    >
    > Tbr: ulan@chromium.org, tebbi@chromium.org, rmcilroy@chromium.org
    > Bug: v8:8661,v8:8768,chromium:1140165
    > Change-Id: Ibcd5c39c58a70bf2b2ac221aa375fc68d495e144
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2485506
    > Reviewed-by: Jakob Gruber <jgruber@chromium.org>
    > Reviewed-by: Tobias Tebbi <tebbi@chromium.org>
    > Commit-Queue: Jakob Gruber <jgruber@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#70655}
    
    TBR=ulan@chromium.org,rmcilroy@chromium.org,jgruber@chromium.org,tebbi@chromium.org
    
    Change-Id: I4739a3475bfd8ee0cfbe4b9a20382f91a6ef1bf0
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: v8:8661
    Bug: v8:8768
    Bug: chromium:1140165
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2485223Reviewed-by: 's avatarMaya Lekova <mslekova@chromium.org>
    Commit-Queue: Maya Lekova <mslekova@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#70658}
    7c7aa4fa
Name
Last commit
Last update
..
OWNERS Loading commit data...
allocation-site-inl.h Loading commit data...
allocation-site-scopes-inl.h Loading commit data...
allocation-site-scopes.h Loading commit data...
allocation-site.h Loading commit data...
allocation-site.tq Loading commit data...
api-callbacks-inl.h Loading commit data...
api-callbacks.h Loading commit data...
api-callbacks.tq Loading commit data...
arguments-inl.h Loading commit data...
arguments.h Loading commit data...
arguments.tq Loading commit data...
backing-store.cc Loading commit data...
backing-store.h Loading commit data...
bigint.cc Loading commit data...
bigint.h Loading commit data...
cell-inl.h Loading commit data...
cell.h Loading commit data...
cell.tq Loading commit data...
class-definitions-tq-deps-inl.h Loading commit data...
code-inl.h Loading commit data...
code-kind.cc Loading commit data...
code-kind.h Loading commit data...
code.cc Loading commit data...
code.h Loading commit data...
code.tq Loading commit data...
compilation-cache-inl.h Loading commit data...
compilation-cache.h Loading commit data...
compressed-slots-inl.h Loading commit data...
compressed-slots.h Loading commit data...
contexts-inl.h Loading commit data...
contexts.cc Loading commit data...
contexts.h Loading commit data...
contexts.tq Loading commit data...
data-handler-inl.h Loading commit data...
data-handler.h Loading commit data...
data-handler.tq Loading commit data...
debug-objects-inl.h Loading commit data...
debug-objects.cc Loading commit data...
debug-objects.h Loading commit data...
debug-objects.tq Loading commit data...
descriptor-array-inl.h Loading commit data...
descriptor-array.h Loading commit data...
descriptor-array.tq Loading commit data...
dictionary-inl.h Loading commit data...
dictionary.h Loading commit data...
elements-inl.h Loading commit data...
elements-kind.cc Loading commit data...
elements-kind.h Loading commit data...
elements.cc Loading commit data...
elements.h Loading commit data...
embedder-data-array-inl.h Loading commit data...
embedder-data-array.cc Loading commit data...
embedder-data-array.h Loading commit data...
embedder-data-array.tq Loading commit data...
embedder-data-slot-inl.h Loading commit data...
embedder-data-slot.h Loading commit data...
feedback-cell-inl.h Loading commit data...
feedback-cell.h Loading commit data...
feedback-cell.tq Loading commit data...
feedback-vector-inl.h Loading commit data...
feedback-vector.cc Loading commit data...
feedback-vector.h Loading commit data...
feedback-vector.tq Loading commit data...
field-index-inl.h Loading commit data...
field-index.h Loading commit data...
field-type.cc Loading commit data...
field-type.h Loading commit data...
fixed-array-inl.h Loading commit data...
fixed-array.h Loading commit data...
fixed-array.tq Loading commit data...
foreign-inl.h Loading commit data...
foreign.h Loading commit data...
foreign.tq Loading commit data...
frame-array-inl.h Loading commit data...
frame-array.h Loading commit data...
free-space-inl.h Loading commit data...
free-space.h Loading commit data...
free-space.tq Loading commit data...
function-kind.h Loading commit data...
function-syntax-kind.h Loading commit data...
hash-table-inl.h Loading commit data...
hash-table.h Loading commit data...
heap-number-inl.h Loading commit data...
heap-number.h Loading commit data...
heap-number.tq Loading commit data...
heap-object-inl.h Loading commit data...
heap-object.h Loading commit data...
heap-object.tq Loading commit data...
instance-type-inl.h Loading commit data...
instance-type.h Loading commit data...
internal-index.h Loading commit data...
intl-objects.cc Loading commit data...
intl-objects.h Loading commit data...
intl-objects.tq Loading commit data...
js-array-buffer-inl.h Loading commit data...
js-array-buffer.cc Loading commit data...
js-array-buffer.h Loading commit data...
js-array-buffer.tq Loading commit data...
js-array-inl.h Loading commit data...
js-array.h Loading commit data...
js-array.tq Loading commit data...
js-break-iterator-inl.h Loading commit data...
js-break-iterator.cc Loading commit data...
js-break-iterator.h Loading commit data...
js-collator-inl.h Loading commit data...
js-collator.cc Loading commit data...
js-collator.h Loading commit data...
js-collection-inl.h Loading commit data...
js-collection-iterator.h Loading commit data...
js-collection-iterator.tq Loading commit data...
js-collection.h Loading commit data...
js-collection.tq Loading commit data...
js-date-time-format-inl.h Loading commit data...
js-date-time-format.cc Loading commit data...
js-date-time-format.h Loading commit data...
js-display-names-inl.h Loading commit data...
js-display-names.cc Loading commit data...
js-display-names.h Loading commit data...
js-function-inl.h Loading commit data...
js-function.cc Loading commit data...
js-function.h Loading commit data...
js-generator-inl.h Loading commit data...
js-generator.h Loading commit data...
js-generator.tq Loading commit data...
js-list-format-inl.h Loading commit data...
js-list-format.cc Loading commit data...
js-list-format.h Loading commit data...
js-locale-inl.h Loading commit data...
js-locale.cc Loading commit data...
js-locale.h Loading commit data...
js-number-format-inl.h Loading commit data...
js-number-format.cc Loading commit data...
js-number-format.h Loading commit data...
js-objects-inl.h Loading commit data...
js-objects.cc Loading commit data...
js-objects.h Loading commit data...
js-objects.tq Loading commit data...
js-plural-rules-inl.h Loading commit data...
js-plural-rules.cc Loading commit data...
js-plural-rules.h Loading commit data...
js-promise-inl.h Loading commit data...
js-promise.h Loading commit data...
js-promise.tq Loading commit data...
js-proxy-inl.h Loading commit data...
js-proxy.h Loading commit data...
js-proxy.tq Loading commit data...
js-regexp-inl.h Loading commit data...
js-regexp-string-iterator-inl.h Loading commit data...
js-regexp-string-iterator.h Loading commit data...
js-regexp-string-iterator.tq Loading commit data...
js-regexp.cc Loading commit data...
js-regexp.h Loading commit data...
js-regexp.tq Loading commit data...
js-relative-time-format-inl.h Loading commit data...
js-relative-time-format.cc Loading commit data...
js-relative-time-format.h Loading commit data...
js-segment-iterator-inl.h Loading commit data...
js-segment-iterator.cc Loading commit data...
js-segment-iterator.h Loading commit data...
js-segmenter-inl.h Loading commit data...
js-segmenter.cc Loading commit data...
js-segmenter.h Loading commit data...
js-segments-inl.h Loading commit data...
js-segments.cc Loading commit data...
js-segments.h Loading commit data...
js-weak-refs-inl.h Loading commit data...
js-weak-refs.h Loading commit data...
js-weak-refs.tq Loading commit data...
keys.cc Loading commit data...
keys.h Loading commit data...
layout-descriptor-inl.h Loading commit data...
layout-descriptor.cc Loading commit data...
layout-descriptor.h Loading commit data...
literal-objects-inl.h Loading commit data...
literal-objects.cc Loading commit data...
literal-objects.h Loading commit data...
literal-objects.tq Loading commit data...
lookup-cache-inl.h Loading commit data...
lookup-cache.cc Loading commit data...
lookup-cache.h Loading commit data...
lookup-inl.h Loading commit data...
lookup.cc Loading commit data...
lookup.h Loading commit data...
managed.cc Loading commit data...
managed.h Loading commit data...
map-inl.h Loading commit data...
map-updater.cc Loading commit data...
map-updater.h Loading commit data...
map.cc Loading commit data...
map.h Loading commit data...
map.tq Loading commit data...
maybe-object-inl.h Loading commit data...
maybe-object.h Loading commit data...
microtask-inl.h Loading commit data...
microtask.h Loading commit data...
microtask.tq Loading commit data...
module-inl.h Loading commit data...
module.cc Loading commit data...
module.h Loading commit data...
module.tq Loading commit data...
name-inl.h Loading commit data...
name.h Loading commit data...
name.tq Loading commit data...
object-list-macros.h Loading commit data...
object-macros-undef.h Loading commit data...
object-macros.h Loading commit data...
objects-body-descriptors-inl.h Loading commit data...
objects-body-descriptors.h Loading commit data...
objects-definitions.h Loading commit data...
objects-inl.h Loading commit data...
objects.cc Loading commit data...
objects.h Loading commit data...
oddball-inl.h Loading commit data...
oddball.h Loading commit data...
oddball.tq Loading commit data...
ordered-hash-table-inl.h Loading commit data...
ordered-hash-table.cc Loading commit data...
ordered-hash-table.h Loading commit data...
ordered-hash-table.tq Loading commit data...
osr-optimized-code-cache-inl.h Loading commit data...
osr-optimized-code-cache.cc Loading commit data...
osr-optimized-code-cache.h Loading commit data...
primitive-heap-object-inl.h Loading commit data...
primitive-heap-object.h Loading commit data...
primitive-heap-object.tq Loading commit data...
promise-inl.h Loading commit data...
promise.h Loading commit data...
promise.tq Loading commit data...
property-array-inl.h Loading commit data...
property-array.h Loading commit data...
property-array.tq Loading commit data...
property-cell-inl.h Loading commit data...
property-cell.h Loading commit data...
property-cell.tq Loading commit data...
property-descriptor-object-inl.h Loading commit data...
property-descriptor-object.h Loading commit data...
property-descriptor-object.tq Loading commit data...
property-descriptor.cc Loading commit data...
property-descriptor.h Loading commit data...
property-details.h Loading commit data...
property.cc Loading commit data...
property.h Loading commit data...
prototype-info-inl.h Loading commit data...
prototype-info.h Loading commit data...
prototype-info.tq Loading commit data...
prototype-inl.h Loading commit data...
prototype.h Loading commit data...
regexp-match-info.h Loading commit data...
regexp-match-info.tq Loading commit data...
scope-info.cc Loading commit data...
scope-info.h Loading commit data...
scope-info.tq Loading commit data...
script-inl.h Loading commit data...
script.h Loading commit data...
script.tq Loading commit data...
shared-function-info-inl.h Loading commit data...
shared-function-info.cc Loading commit data...
shared-function-info.h Loading commit data...
shared-function-info.tq Loading commit data...
slots-atomic-inl.h Loading commit data...
slots-inl.h Loading commit data...
slots.h Loading commit data...
smi-inl.h Loading commit data...
smi.h Loading commit data...
source-text-module.cc Loading commit data...
source-text-module.h Loading commit data...
source-text-module.tq Loading commit data...
stack-frame-info-inl.h Loading commit data...
stack-frame-info.cc Loading commit data...
stack-frame-info.h Loading commit data...
stack-frame-info.tq Loading commit data...
string-comparator.cc Loading commit data...
string-comparator.h Loading commit data...
string-inl.h Loading commit data...
string-set-inl.h Loading commit data...
string-set.h Loading commit data...
string-table-inl.h Loading commit data...
string-table.cc Loading commit data...
string-table.h Loading commit data...
string.cc Loading commit data...
string.h Loading commit data...
string.tq Loading commit data...
struct-inl.h Loading commit data...
struct.h Loading commit data...
struct.tq Loading commit data...
synthetic-module.cc Loading commit data...
synthetic-module.h Loading commit data...
synthetic-module.tq Loading commit data...
tagged-field-inl.h Loading commit data...
tagged-field.h Loading commit data...
tagged-impl-inl.h Loading commit data...
tagged-impl.cc Loading commit data...
tagged-impl.h Loading commit data...
tagged-index.h Loading commit data...
tagged-value-inl.h Loading commit data...
tagged-value.h Loading commit data...
template-objects-inl.h Loading commit data...
template-objects.cc Loading commit data...
template-objects.h Loading commit data...
template-objects.tq Loading commit data...
template.tq Loading commit data...
templates-inl.h Loading commit data...
templates.h Loading commit data...
transitions-inl.h Loading commit data...
transitions.cc Loading commit data...
transitions.h Loading commit data...
type-hints.cc Loading commit data...
type-hints.h Loading commit data...
value-serializer.cc Loading commit data...
value-serializer.h Loading commit data...
visitors.cc Loading commit data...
visitors.h Loading commit data...