• Clemens Backes's avatar
    [wasm] Fix check for committing over the global limit · 1a3cc643
    Clemens Backes authored
    If we generate more code than allowed by the --wasm-max-code-space flag,
    the {WasmCodeManager::Commit} method will fail (via fatal error). The
    DCHECK that was placed before that call checked for a related condition
    though, and failed before the {Commit} method could fail.
    By moving it after the call, we fix this issue.
    
    Adding a test case for this seems to be involved, since that test would
    crash the whole process (because of the fatal error). So it would have
    to be a unittest such that we can use ASSERT_DEATH_IF_SUPPORTED. In
    unittests though we don't yet have the infrastructure to create a
    NativeModule (needed for the WasmCodeAllocator). Alternatively we could
    add special testing methods (and a constructor) to the
    WasmCodeAllocator, but I do not consider this worth the effort for this
    little fix.
    
    R=thibaudm@chromium.org
    
    Bug: chromium:1124646
    Change-Id: Ief09dfbd0a5b0b040fe9cf8a34e458d1d01dfacc
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2390754
    Auto-Submit: Clemens Backes <clemensb@chromium.org>
    Commit-Queue: Thibaud Michaud <thibaudm@chromium.org>
    Reviewed-by: 's avatarThibaud Michaud <thibaudm@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#69723}
    1a3cc643
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
OWNERS Loading commit data...