• Clemens Backes's avatar
    [wasm] Fix check for committing over the global limit · 1a3cc643
    Clemens Backes authored
    If we generate more code than allowed by the --wasm-max-code-space flag,
    the {WasmCodeManager::Commit} method will fail (via fatal error). The
    DCHECK that was placed before that call checked for a related condition
    though, and failed before the {Commit} method could fail.
    By moving it after the call, we fix this issue.
    
    Adding a test case for this seems to be involved, since that test would
    crash the whole process (because of the fatal error). So it would have
    to be a unittest such that we can use ASSERT_DEATH_IF_SUPPORTED. In
    unittests though we don't yet have the infrastructure to create a
    NativeModule (needed for the WasmCodeAllocator). Alternatively we could
    add special testing methods (and a constructor) to the
    WasmCodeAllocator, but I do not consider this worth the effort for this
    little fix.
    
    R=thibaudm@chromium.org
    
    Bug: chromium:1124646
    Change-Id: Ief09dfbd0a5b0b040fe9cf8a34e458d1d01dfacc
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2390754
    Auto-Submit: Clemens Backes <clemensb@chromium.org>
    Commit-Queue: Thibaud Michaud <thibaudm@chromium.org>
    Reviewed-by: 's avatarThibaud Michaud <thibaudm@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#69723}
    1a3cc643
Name
Last commit
Last update
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...