• Andreas Haas's avatar
    Revert "[wasm] Enter CallDepthScope after compilation to execute microtasks" · 193b8255
    Andreas Haas authored
    This reverts commit b1f89633.
    
    Reason for revert: This causes a crash with streaming compilation when the stream gets aborted because the context gets destroyed, e.g. when a worker gets killed early.
    
    Original change's description:
    > [wasm] Enter CallDepthScope after compilation to execute microtasks
    >
    > When async compilation finishes for WebAssembly, the promise returned by
    > `WebAssembly.compile()` gets resolved. Resolving the promise creates a
    > microtask that should get executed automatically when the call stack
    > empties up when MicrotasksPolicy::kAuto is used. However, this policy
    > requires a CallDepthScope to work, but there is no CallDepthScope when
    > WebAssembly compilation finishes. This CL adds this CallDepthScope.
    >
    > R=​jkummerow@chromium.org
    >
    > Bug: chromium:1297672
    > Change-Id: I1bd607dec9daf08b3dbb1294393a8af255d222ff
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3679579
    > Auto-Submit: Andreas Haas <ahaas@chromium.org>
    > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
    > Commit-Queue: Jakob Kummerow <jkummerow@chromium.org>
    > Cr-Commit-Position: refs/heads/main@{#80872}
    
    Bug: chromium:1297672, chromium:1335042
    Change-Id: I1f186a7f17f007a448ca7188bd32605a4fc03497
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3695359
    Commit-Queue: Andreas Haas <ahaas@chromium.org>
    Reviewed-by: 's avatarJakob Kummerow <jkummerow@chromium.org>
    Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/main@{#81040}
    193b8255
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
baseline Loading commit data...
bigint Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
maglev Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sandbox Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
temporal Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
web-snapshot Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
OWNERS Loading commit data...