• Andreas Haas's avatar
    Revert "[wasm] Enter CallDepthScope after compilation to execute microtasks" · 193b8255
    Andreas Haas authored
    This reverts commit b1f89633.
    
    Reason for revert: This causes a crash with streaming compilation when the stream gets aborted because the context gets destroyed, e.g. when a worker gets killed early.
    
    Original change's description:
    > [wasm] Enter CallDepthScope after compilation to execute microtasks
    >
    > When async compilation finishes for WebAssembly, the promise returned by
    > `WebAssembly.compile()` gets resolved. Resolving the promise creates a
    > microtask that should get executed automatically when the call stack
    > empties up when MicrotasksPolicy::kAuto is used. However, this policy
    > requires a CallDepthScope to work, but there is no CallDepthScope when
    > WebAssembly compilation finishes. This CL adds this CallDepthScope.
    >
    > R=​jkummerow@chromium.org
    >
    > Bug: chromium:1297672
    > Change-Id: I1bd607dec9daf08b3dbb1294393a8af255d222ff
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3679579
    > Auto-Submit: Andreas Haas <ahaas@chromium.org>
    > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
    > Commit-Queue: Jakob Kummerow <jkummerow@chromium.org>
    > Cr-Commit-Position: refs/heads/main@{#80872}
    
    Bug: chromium:1297672, chromium:1335042
    Change-Id: I1f186a7f17f007a448ca7188bd32605a4fc03497
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3695359
    Commit-Queue: Andreas Haas <ahaas@chromium.org>
    Reviewed-by: 's avatarJakob Kummerow <jkummerow@chromium.org>
    Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/main@{#81040}
    193b8255
Name
Last commit
Last update
.github Loading commit data...
bazel Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.bazelrc Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.mailmap Loading commit data...
.style.yapf Loading commit data...
.vpython Loading commit data...
.vpython3 Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.bazel Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LOONG_OWNERS Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
WORKSPACE Loading commit data...
codereview.settings Loading commit data...