• Bill Budge's avatar
    Revert "Improve error messages for property access on null/undefined" · b261213f
    Bill Budge authored
    This reverts commit 24c626c1.
    
    Reason for revert: Blocks V8 roll into Chromium (changed error messages cause tests to fail):
    https://ci.chromium.org/p/chromium/builders/try/linux-rel/724109?
    
    Original change's description:
    > Improve error messages for property access on null/undefined
    >
    > Only print the property name when accessing null/undefined if we can
    > convert it to a string without causing side effects.
    > If we can't, omit the property name in the error message.
    > This should avoid confusion when the key is an object with toString().
    > E.g. undefined[{toString:()=>'a'}] doesn't print 'read property [object
    > Object]' anymore, which was misleading since the property accessed would
    > be 'a', but we can't evaluate the key without side effects.
    >
    > Bug: v8:11365
    > Change-Id: If82d1adb42561d4851e2bd2ca297a1c71738aee8
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2960211
    > Reviewed-by: Toon Verwaest <verwaest@chromium.org>
    > Commit-Queue: Patrick Thier <pthier@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#75250}
    
    Bug: v8:11365
    Change-Id: Ic63f34033254f55b3871041633d84ea48586a75d
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2977374
    Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
    Commit-Queue: Deepti Gandluri <gdeepti@chromium.org>
    Commit-Queue: Bill Budge <bbudge@chromium.org>
    Reviewed-by: 's avatarBill Budge <bbudge@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#75282}
    b261213f
Name
Last commit
Last update
..
arm Loading commit data...
arm64 Loading commit data...
ia32 Loading commit data...
mips Loading commit data...
mips64 Loading commit data...
ppc Loading commit data...
riscv64 Loading commit data...
s390 Loading commit data...
x64 Loading commit data...
DIR_METADATA Loading commit data...
OWNERS Loading commit data...
arguments-inl.h Loading commit data...
arguments.cc Loading commit data...
arguments.h Loading commit data...
execution.cc Loading commit data...
execution.h Loading commit data...
external-pointer-table.cc Loading commit data...
external-pointer-table.h Loading commit data...
frame-constants.h Loading commit data...
frames-inl.h Loading commit data...
frames.cc Loading commit data...
frames.h Loading commit data...
futex-emulation.cc Loading commit data...
futex-emulation.h Loading commit data...
interrupts-scope.cc Loading commit data...
interrupts-scope.h Loading commit data...
isolate-data.h Loading commit data...
isolate-inl.h Loading commit data...
isolate-utils-inl.h Loading commit data...
isolate-utils.h Loading commit data...
isolate.cc Loading commit data...
isolate.h Loading commit data...
local-isolate-inl.h Loading commit data...
local-isolate.cc Loading commit data...
local-isolate.h Loading commit data...
messages.cc Loading commit data...
messages.h Loading commit data...
microtask-queue.cc Loading commit data...
microtask-queue.h Loading commit data...
pointer-authentication-dummy.h Loading commit data...
pointer-authentication.h Loading commit data...
protectors-inl.h Loading commit data...
protectors.cc Loading commit data...
protectors.h Loading commit data...
runtime-profiler.cc Loading commit data...
runtime-profiler.h Loading commit data...
shared-mutex-guard-if-off-thread.h Loading commit data...
simulator-base.cc Loading commit data...
simulator-base.h Loading commit data...
simulator.h Loading commit data...
stack-guard.cc Loading commit data...
stack-guard.h Loading commit data...
thread-id.cc Loading commit data...
thread-id.h Loading commit data...
thread-local-top.cc Loading commit data...
thread-local-top.h Loading commit data...
v8threads.cc Loading commit data...
v8threads.h Loading commit data...
vm-state-inl.h Loading commit data...
vm-state.h Loading commit data...