• Bill Budge's avatar
    Revert "Improve error messages for property access on null/undefined" · b261213f
    Bill Budge authored
    This reverts commit 24c626c1.
    
    Reason for revert: Blocks V8 roll into Chromium (changed error messages cause tests to fail):
    https://ci.chromium.org/p/chromium/builders/try/linux-rel/724109?
    
    Original change's description:
    > Improve error messages for property access on null/undefined
    >
    > Only print the property name when accessing null/undefined if we can
    > convert it to a string without causing side effects.
    > If we can't, omit the property name in the error message.
    > This should avoid confusion when the key is an object with toString().
    > E.g. undefined[{toString:()=>'a'}] doesn't print 'read property [object
    > Object]' anymore, which was misleading since the property accessed would
    > be 'a', but we can't evaluate the key without side effects.
    >
    > Bug: v8:11365
    > Change-Id: If82d1adb42561d4851e2bd2ca297a1c71738aee8
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2960211
    > Reviewed-by: Toon Verwaest <verwaest@chromium.org>
    > Commit-Queue: Patrick Thier <pthier@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#75250}
    
    Bug: v8:11365
    Change-Id: Ic63f34033254f55b3871041633d84ea48586a75d
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2977374
    Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
    Commit-Queue: Deepti Gandluri <gdeepti@chromium.org>
    Commit-Queue: Bill Budge <bbudge@chromium.org>
    Reviewed-by: 's avatarBill Budge <bbudge@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#75282}
    b261213f
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
baseline Loading commit data...
bigint Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
web-snapshot Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
OWNERS Loading commit data...