• Andreas Haas's avatar
    [wasm] Set thread-in-wasm flag correctly after stack unwinding · 15bf8519
    Andreas Haas authored
    In Isolate::UnwindAndFindHandler(), the thread-in-wasm flag was set
    before the destructor of some objects in that function got executed,
    e.g. the destructor of {WasmCodeRefScope}. On Windows-asan, these
    destructors could throw exceptions (asan on Windows uses exceptions for
    its memory access tracking), which get handled initially by the wasm
    trap handler, and would thereby invalidate the thread-in-wasm flag.
    
    With this CL a new scope gets introduced which makes sure that setting
    the thread-in-wasm flag is the last thing that happens in
    Isolate::UnwindAndFindHandler().
    
    
    Bug: chromium:1195595
    Change-Id: If9f5f486c55b3bc2718a1d5aee3e3bd290d0ff35
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2817598
    Commit-Queue: Andreas Haas <ahaas@chromium.org>
    Reviewed-by: 's avatarJakob Kummerow <jkummerow@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#73904}
    15bf8519
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
baseline Loading commit data...
bigint Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
web-snapshot Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
OWNERS Loading commit data...