• Andreas Haas's avatar
    [wasm] Set thread-in-wasm flag correctly after stack unwinding · 15bf8519
    Andreas Haas authored
    In Isolate::UnwindAndFindHandler(), the thread-in-wasm flag was set
    before the destructor of some objects in that function got executed,
    e.g. the destructor of {WasmCodeRefScope}. On Windows-asan, these
    destructors could throw exceptions (asan on Windows uses exceptions for
    its memory access tracking), which get handled initially by the wasm
    trap handler, and would thereby invalidate the thread-in-wasm flag.
    
    With this CL a new scope gets introduced which makes sure that setting
    the thread-in-wasm flag is the last thing that happens in
    Isolate::UnwindAndFindHandler().
    
    
    Bug: chromium:1195595
    Change-Id: If9f5f486c55b3bc2718a1d5aee3e3bd290d0ff35
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2817598
    Commit-Queue: Andreas Haas <ahaas@chromium.org>
    Reviewed-by: 's avatarJakob Kummerow <jkummerow@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#73904}
    15bf8519
Name
Last commit
Last update
.github Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...