• Clemens Backes's avatar
    [wasm][debug] Make recompilation isolate-independent · 14984372
    Clemens Backes authored
    Passing an isolate to {RecompileNativeModule} feels wrong, since
    compilation and the generated code are totally isolate-independent. In
    fact, the isolate is only used for updating counters.
    Instead of passing the counters instead, this CL just refactors the code
    to support a nullptr for the counters everywhere (some code paths
    already supported that). The few recompilation would not make a
    significant difference in the histograms anyway, and even have the risk
    of skewing the data.
    
    Drive-by 1: Rename {TierUp} to {StartTierUp} and update comments.
    Drive-by 2: Remove non-actionable TODO.
    
    R=thibaudm@chromium.org
    
    Bug: v8:10359
    Change-Id: Ic027f939bbc55398b90784922130fe1fe5573b0c
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2187638Reviewed-by: 's avatarThibaud Michaud <thibaudm@chromium.org>
    Commit-Queue: Clemens Backes <clemensb@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#67708}
    14984372
Name
Last commit
Last update
..
OWNERS Loading commit data...
test-c-wasm-entry.cc Loading commit data...
test-compilation-cache.cc Loading commit data...
test-gc.cc Loading commit data...
test-grow-memory.cc Loading commit data...
test-jump-table-assembler.cc Loading commit data...
test-liftoff-inspection.cc Loading commit data...
test-run-wasm-64.cc Loading commit data...
test-run-wasm-asmjs.cc Loading commit data...
test-run-wasm-atomics.cc Loading commit data...
test-run-wasm-atomics64.cc Loading commit data...
test-run-wasm-bulk-memory.cc Loading commit data...
test-run-wasm-exceptions.cc Loading commit data...
test-run-wasm-interpreter.cc Loading commit data...
test-run-wasm-js.cc Loading commit data...
test-run-wasm-module.cc Loading commit data...
test-run-wasm-sign-extension.cc Loading commit data...
test-run-wasm-simd-liftoff.cc Loading commit data...
test-run-wasm-simd-scalar-lowering.cc Loading commit data...
test-run-wasm-simd.cc Loading commit data...
test-run-wasm.cc Loading commit data...
test-streaming-compilation.cc Loading commit data...
test-wasm-breakpoints.cc Loading commit data...
test-wasm-codegen.cc Loading commit data...
test-wasm-debug-evaluate.cc Loading commit data...
test-wasm-import-wrapper-cache.cc Loading commit data...
test-wasm-serialization.cc Loading commit data...
test-wasm-shared-engine.cc Loading commit data...
test-wasm-stack.cc Loading commit data...
test-wasm-trap-position.cc Loading commit data...
wasm-atomics-utils.h Loading commit data...
wasm-run-utils.cc Loading commit data...
wasm-run-utils.h Loading commit data...