• Clemens Backes's avatar
    [wasm][debug] Leave stepping code early · 0de9a7e6
    Clemens Backes authored
    Stepping code that is left on the stack will repeatedly call the
    WasmDebugBreak function. This has no observable effect, except for
    severe slowdown of execution. In the linked bug, we were executing at
    least another few million instructions in the same frame, so it appeared
    that it never finishes.
    
    This CL fixes that by replacing stepping code with non-stepping code if
    the WasmDebugBreak runtime function is called from stepping code but we
    are not stepping (any more).
    Adding a test for this is difficult, since this only has an effect on
    performance.
    
    R=thibaudm@chromium.org
    
    Bug: chromium:1153308
    Change-Id: I02feb04a156dfe81ca76ce26f0af131c470ef7a3
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2775575
    Commit-Queue: Clemens Backes <clemensb@chromium.org>
    Reviewed-by: 's avatarThibaud Michaud <thibaudm@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#73567}
    0de9a7e6
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
baseline Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
web-snapshot Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
OWNERS Loading commit data...