• Clemens Backes's avatar
    [wasm][debug] Leave stepping code early · 0de9a7e6
    Clemens Backes authored
    Stepping code that is left on the stack will repeatedly call the
    WasmDebugBreak function. This has no observable effect, except for
    severe slowdown of execution. In the linked bug, we were executing at
    least another few million instructions in the same frame, so it appeared
    that it never finishes.
    
    This CL fixes that by replacing stepping code with non-stepping code if
    the WasmDebugBreak runtime function is called from stepping code but we
    are not stepping (any more).
    Adding a test for this is difficult, since this only has an effect on
    performance.
    
    R=thibaudm@chromium.org
    
    Bug: chromium:1153308
    Change-Id: I02feb04a156dfe81ca76ce26f0af131c470ef7a3
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2775575
    Commit-Queue: Clemens Backes <clemensb@chromium.org>
    Reviewed-by: 's avatarThibaud Michaud <thibaudm@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#73567}
    0de9a7e6
Name
Last commit
Last update
.github Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...