• Clemens Backes's avatar
    [wasm] Refactor callback triggering · 0dc598df
    Clemens Backes authored
    1) Instead of passing three boolean values to |TriggerCallbacks|, pass
       one EnumSet which contains all events to trigger.
    2) Remember which events already happened, to avoid triggering them
       again.
    3) Compute triggered events once after the loop in |OnFinishedUnits|,
       instead of checking for every finished unit.
    4) When a new callback is registered, trigger all previous events
       immediately. This solves issue v8:10217.
    5) Replace |NotifyTopTierReady| by |AddCallback| which is identical now.
    6) Do not call |OnFinishedJSToWasmWrapperUnits| if no wrappers were
       compiled (this is a minor performance optimization; we save taking
       and releasing a lock).
    7) Drive-by: Make the |EnumSet| constructor really constexpr (by making
       |Mask| constexpr).
    
    R=ahaas@chromium.org
    
    Bug: v8:10217
    Change-Id: Ib3688a1687ad7b523e90efd73f4073e9f1193016
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2072737
    Commit-Queue: Clemens Backes <clemensb@chromium.org>
    Reviewed-by: 's avatarAndreas Haas <ahaas@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#66459}
    0dc598df
Name
Last commit
Last update
..
debug Loading commit data...
platform Loading commit data...
utils Loading commit data...
DEPS Loading commit data...
OWNERS Loading commit data...
address-region.h Loading commit data...
atomic-utils.h Loading commit data...
atomicops.h Loading commit data...
atomicops_internals_atomicword_compat.h Loading commit data...
atomicops_internals_portable.h Loading commit data...
atomicops_internals_std.h Loading commit data...
base-export.h Loading commit data...
bit-field.h Loading commit data...
bits.cc Loading commit data...
bits.h Loading commit data...
bounded-page-allocator.cc Loading commit data...
bounded-page-allocator.h Loading commit data...
bounds.h Loading commit data...
build_config.h Loading commit data...
compiler-specific.h Loading commit data...
cpu.cc Loading commit data...
cpu.h Loading commit data...
division-by-constant.cc Loading commit data...
division-by-constant.h Loading commit data...
enum-set.h Loading commit data...
export-template.h Loading commit data...
file-utils.cc Loading commit data...
file-utils.h Loading commit data...
flags.h Loading commit data...
free_deleter.h Loading commit data...
functional.cc Loading commit data...
functional.h Loading commit data...
hashmap-entry.h Loading commit data...
hashmap.h Loading commit data...
ieee754.cc Loading commit data...
ieee754.h Loading commit data...
iterator.h Loading commit data...
lazy-instance.h Loading commit data...
list.h Loading commit data...
logging.cc Loading commit data...
logging.h Loading commit data...
lsan.h Loading commit data...
macros.h Loading commit data...
memory.h Loading commit data...
once.cc Loading commit data...
once.h Loading commit data...
optional.h Loading commit data...
overflowing-math.h Loading commit data...
page-allocator.cc Loading commit data...
page-allocator.h Loading commit data...
qnx-math.h Loading commit data...
region-allocator.cc Loading commit data...
region-allocator.h Loading commit data...
ring-buffer.h Loading commit data...
safe_conversions.h Loading commit data...
safe_conversions_impl.h Loading commit data...
small-vector.h Loading commit data...
sys-info.cc Loading commit data...
sys-info.h Loading commit data...
template-utils.h Loading commit data...
threaded-list.h Loading commit data...
timezone-cache.h Loading commit data...
type-traits.h Loading commit data...
ubsan.cc Loading commit data...
v8-fallthrough.h Loading commit data...
vlq-base64.cc Loading commit data...
vlq-base64.h Loading commit data...
win32-headers.h Loading commit data...