• Clemens Backes's avatar
    [wasm] Refactor callback triggering · 0dc598df
    Clemens Backes authored
    1) Instead of passing three boolean values to |TriggerCallbacks|, pass
       one EnumSet which contains all events to trigger.
    2) Remember which events already happened, to avoid triggering them
       again.
    3) Compute triggered events once after the loop in |OnFinishedUnits|,
       instead of checking for every finished unit.
    4) When a new callback is registered, trigger all previous events
       immediately. This solves issue v8:10217.
    5) Replace |NotifyTopTierReady| by |AddCallback| which is identical now.
    6) Do not call |OnFinishedJSToWasmWrapperUnits| if no wrappers were
       compiled (this is a minor performance optimization; we save taking
       and releasing a lock).
    7) Drive-by: Make the |EnumSet| constructor really constexpr (by making
       |Mask| constexpr).
    
    R=ahaas@chromium.org
    
    Bug: v8:10217
    Change-Id: Ib3688a1687ad7b523e90efd73f4073e9f1193016
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2072737
    Commit-Queue: Clemens Backes <clemensb@chromium.org>
    Reviewed-by: 's avatarAndreas Haas <ahaas@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#66459}
    0dc598df
Name
Last commit
Last update
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...