• Marja Hölttä's avatar
    [builtins] Unify ArrayPrototypeSlice & ReduceArrayPrototypeSlice · 0d42c9d0
    Marja Hölttä authored
    They need to agree about when to delegate to CloneFastJSArray, since it
    produces arrays which are potentially COW. If they don't agree, TF
    generates code which produces a COW array and then expects it to be
    non-COW -> immediate deopt.
    
    This CL gets rid of the discrepancy in the case when there's exactly
    one argument and it's the number 0.
    
    Some corner cases remain, e.g., 1st argument not a number but ToInteger
    returns 0. These should be extremely rare in the real world.
    
    Bug: v8:12194
    Change-Id: I10230245c97f8997da4d79702f29ebff11297229
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3147910
    Commit-Queue: Marja Hölttä <marja@chromium.org>
    Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#76745}
    0d42c9d0
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
baseline Loading commit data...
bigint Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
web-snapshot Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
OWNERS Loading commit data...