• Marja Hölttä's avatar
    [builtins] Unify ArrayPrototypeSlice & ReduceArrayPrototypeSlice · 0d42c9d0
    Marja Hölttä authored
    They need to agree about when to delegate to CloneFastJSArray, since it
    produces arrays which are potentially COW. If they don't agree, TF
    generates code which produces a COW array and then expects it to be
    non-COW -> immediate deopt.
    
    This CL gets rid of the discrepancy in the case when there's exactly
    one argument and it's the number 0.
    
    Some corner cases remain, e.g., 1st argument not a number but ToInteger
    returns 0. These should be extremely rare in the real world.
    
    Bug: v8:12194
    Change-Id: I10230245c97f8997da4d79702f29ebff11297229
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3147910
    Commit-Queue: Marja Hölttä <marja@chromium.org>
    Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#76745}
    0d42c9d0
Name
Last commit
Last update
.github Loading commit data...
bazel Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.bazelrc Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.mailmap Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.bazel Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LOONG_OWNERS Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
WORKSPACE Loading commit data...
codereview.settings Loading commit data...