• Kim-Anh Tran's avatar
    [wasm][debug] Keep breakpointIdToDebuggerBreakpointIds alive on reload · 09a5c855
    Kim-Anh Tran authored
    Until now the breakpointIdToDebuggerBreakpointIds was cleared on page
    reload. It keeps a map from breakpointIds to debuggerBreakpointIds,
    with the latter being necessary for removing breakpoints.
    
    If a breakpoint is set and we trigger a page reload, the
    information about that breakpoint will be removed from the map,
    even if it still exists. If we later want to remove the breakpoint
    we look into the map, but the meta data is no longer existing.
    
    Thus, reloading the page again will lead to hitting the breakpoint,
    even if we removed it in the front-end.
    
    This change keeps the map alive on page reset, so that we still
    keep track of set breakpoints after a page reload.
    
    Bug: chromium:1073071
    Change-Id: I82192777bac7afc406245a5a1cff0620e8174499
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2253842Reviewed-by: 's avatarClemens Backes <clemensb@chromium.org>
    Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
    Commit-Queue: Kim-Anh Tran <kimanh@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#68433}
    09a5c855
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
OWNERS Loading commit data...