• Kim-Anh Tran's avatar
    [wasm][debug] Keep breakpointIdToDebuggerBreakpointIds alive on reload · 09a5c855
    Kim-Anh Tran authored
    Until now the breakpointIdToDebuggerBreakpointIds was cleared on page
    reload. It keeps a map from breakpointIds to debuggerBreakpointIds,
    with the latter being necessary for removing breakpoints.
    
    If a breakpoint is set and we trigger a page reload, the
    information about that breakpoint will be removed from the map,
    even if it still exists. If we later want to remove the breakpoint
    we look into the map, but the meta data is no longer existing.
    
    Thus, reloading the page again will lead to hitting the breakpoint,
    even if we removed it in the front-end.
    
    This change keeps the map alive on page reset, so that we still
    keep track of set breakpoints after a page reload.
    
    Bug: chromium:1073071
    Change-Id: I82192777bac7afc406245a5a1cff0620e8174499
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2253842Reviewed-by: 's avatarClemens Backes <clemensb@chromium.org>
    Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
    Commit-Queue: Kim-Anh Tran <kimanh@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#68433}
    09a5c855
Name
Last commit
Last update
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...