• Benedikt Meurer's avatar
    [inspector] Report length and endColumn correctly for Wasm. · 03ba73e4
    Benedikt Meurer authored
    Previously both the length and the endColumn for Wasm scripts were
    reported as 0, and that was sort of okayish, since the front-end
    was ignoring both of these fields in case of Wasm, and was applying
    special cases. But these special casing lead to some subtle bugs,
    and this is the first step towards a more uniform treatment.
    
    Source positions for Wasm are in terms of the bytecode, and the
    column field contains the bytecode offset here, while the line
    number field is always 0. Hence we send 0 for both startLine and
    endLine as before, but endColumn now corresponds to the bytecode
    size.
    
    Bug: chromium:1056632
    Change-Id: Ia8a9cfe454ed250b87a524f5cbcbbbe242205db6
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2215817
    Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
    Commit-Queue: Yang Guo <yangguo@chromium.org>
    Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#67997}
    03ba73e4
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
OWNERS Loading commit data...