• Benedikt Meurer's avatar
    [inspector] Report length and endColumn correctly for Wasm. · 03ba73e4
    Benedikt Meurer authored
    Previously both the length and the endColumn for Wasm scripts were
    reported as 0, and that was sort of okayish, since the front-end
    was ignoring both of these fields in case of Wasm, and was applying
    special cases. But these special casing lead to some subtle bugs,
    and this is the first step towards a more uniform treatment.
    
    Source positions for Wasm are in terms of the bytecode, and the
    column field contains the bytecode offset here, while the line
    number field is always 0. Hence we send 0 for both startLine and
    endLine as before, but endColumn now corresponds to the bytecode
    size.
    
    Bug: chromium:1056632
    Change-Id: Ia8a9cfe454ed250b87a524f5cbcbbbe242205db6
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2215817
    Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
    Commit-Queue: Yang Guo <yangguo@chromium.org>
    Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#67997}
    03ba73e4
Name
Last commit
Last update
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...