• Camillo Bruni's avatar
    [d8] Fix leak detection for DynamicImportData from Modules · 0316b4fc
    Camillo Bruni authored
    1) Since we collect a stack trace for unhandled promises we might end up
    invoking code right before the shutdown phase.
    2) Any dynamic module import that happens in this phase will enqueue a
    microtask job with a freshly allocated DynamicImportData object. It
    only gets deleted when fully emptying the microtask queue.
    3) Since we're exiting we might end up with a non-empty microtask queue.
    4) LSAN detects this as a leak on shutdown.
    
    To make LSAN happy again d8 now keeps track of DynamicImportData to
    free them on destructing PerIsolateData.
    
    Bug: chromium:1158223
    Change-Id: I9bb21f71bffc75a0d5f4ffc5bf0727c7b4cbab88
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2599755
    Commit-Queue: Camillo Bruni <cbruni@chromium.org>
    Reviewed-by: 's avatarShu-yu Guo <syg@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#72008}
    0316b4fc
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
OWNERS Loading commit data...