• Camillo Bruni's avatar
    [d8] Fix leak detection for DynamicImportData from Modules · 0316b4fc
    Camillo Bruni authored
    1) Since we collect a stack trace for unhandled promises we might end up
    invoking code right before the shutdown phase.
    2) Any dynamic module import that happens in this phase will enqueue a
    microtask job with a freshly allocated DynamicImportData object. It
    only gets deleted when fully emptying the microtask queue.
    3) Since we're exiting we might end up with a non-empty microtask queue.
    4) LSAN detects this as a leak on shutdown.
    
    To make LSAN happy again d8 now keeps track of DynamicImportData to
    free them on destructing PerIsolateData.
    
    Bug: chromium:1158223
    Change-Id: I9bb21f71bffc75a0d5f4ffc5bf0727c7b4cbab88
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2599755
    Commit-Queue: Camillo Bruni <cbruni@chromium.org>
    Reviewed-by: 's avatarShu-yu Guo <syg@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#72008}
    0316b4fc
Name
Last commit
Last update
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...