- 28 Jun, 2021 24 commits
-
-
Junliang Yan authored
Change-Id: Ib511d5332c63952724a1a787d262269dd4aed4a6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2992458Reviewed-by: Milad Fa <mfarazma@redhat.com> Commit-Queue: Junliang Yan <junyan@redhat.com> Cr-Commit-Position: refs/heads/master@{#75424}
-
Ng Zhi An authored
Bug: v8:11879 Change-Id: I7badcbe81485f9e325c75f406560983b78be949a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2989101Reviewed-by: Georg Neis <neis@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#75423}
-
Victor Gomes authored
This allows zlib to be overwritten in blaze. No-Try: true Bug: v8:11234 Change-Id: Id858076a4b744fdade7f6a23646d2d78d33723a7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2993031 Auto-Submit: Victor Gomes <victorgomes@chromium.org> Reviewed-by: Camillo Bruni <cbruni@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#75422}
-
Al Muthanna Athamina authored
Bug: chromium:934932, v8:11933 Cq-Include-Trybots: luci.v8.try:v8_fuchsia_rel_ng Change-Id: Ic2254d647e1e0440523b6546bb82813a07369afc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2983198 Auto-Submit: Almothana Athamneh <almuthanna@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#75421}
-
Thibaud Michaud authored
PopulateReferenceMaps caches an iterator for the reference maps list, which allows skipping many iterations when the live ranges are mostly sorted. When they are not sorted however, the complexity increases significantly since we have to iterate from the beginning of the reference maps list for each live range. We observed a real-world wasm GC function where this phase takes up 90% of the compilation time because of this, which drops to below 2% when the ranges are sorted first. R=sigurds@chromium.org CC=jkummerow@chromium.org Change-Id: I829c909c06e5a1daee0f8d10c156d0a382af9ed0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2985339 Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Reviewed-by: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#75420}
-
Francis McCabe authored
This reverts commit edab8730. Reason for revert: appears to be causing additional TSAN flakes: see https://ci.chromium.org/p/v8/builders/ci/V8%20Linux64%20TSAN%20-%20stress-incremental-marking/3772 Original change's description: > Fix -Wimplicit-int-float-conversions. > > Bug: chromium:989932 > Change-Id: Ief917b023cb079f5ff87dc8963d74f225d074d7a > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2989096 > Reviewed-by: Bill Budge <bbudge@chromium.org> > Reviewed-by: Sigurd Schneider <sigurds@chromium.org> > Auto-Submit: Peter Kasting <pkasting@chromium.org> > Commit-Queue: Peter Kasting <pkasting@chromium.org> > Cr-Commit-Position: refs/heads/master@{#75413} Bug: chromium:989932 Change-Id: I43d16b151f3c2d7bd68d0007af18a06de65da442 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2991342 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Francis McCabe <fgm@chromium.org> Cr-Commit-Position: refs/heads/master@{#75419}
-
https://crrev.com/c/2992710Sigurd Schneider authored
Change-Id: Icd0acbc07698ef59804a6aae01b347e1e173cba9 Bug: chromium:1213393 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2992711 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Auto-Submit: Sigurd Schneider <sigurds@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#75418}
-
Junliang Yan authored
Change-Id: I2ba262ae96f3205e8f2b15f68e0d0307bd244c34 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2992891Reviewed-by: Milad Fa <mfarazma@redhat.com> Commit-Queue: Junliang Yan <junyan@redhat.com> Cr-Commit-Position: refs/heads/master@{#75417}
-
Daan de Graaf authored
Bug: v8:11546 Change-Id: I40bc4b5e3c813edba4a194b086b63e19d1231e29 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2956729 Commit-Queue: Daan de Graaf <daagra@google.com> Reviewed-by: Zhi An Ng <zhin@chromium.org> Reviewed-by: Mythri Alle <mythria@chromium.org> Cr-Commit-Position: refs/heads/master@{#75416}
-
Junliang Yan authored
Change-Id: I15d135a4b7ce2619b501f782a382bd3790e2dcf7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2992890 Commit-Queue: Junliang Yan <junyan@redhat.com> Auto-Submit: Junliang Yan <junyan@redhat.com> Reviewed-by: Milad Fa <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/master@{#75415}
-
Maya Lekova authored
This CL implements setting the javascript_execution_assert on the isolate from generated code, so we don't need to create an expensive class in the embedder callback. Bug: chromium:1218898 Change-Id: Ia05b49281ab4c1cc3ac34caf2dfadb79feb86e84 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2982998 Commit-Queue: Maya Lekova <mslekova@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#75414}
-
Peter Kasting authored
Bug: chromium:989932 Change-Id: Ief917b023cb079f5ff87dc8963d74f225d074d7a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2989096Reviewed-by: Bill Budge <bbudge@chromium.org> Reviewed-by: Sigurd Schneider <sigurds@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#75413}
-
Liu Yu authored
Port c5d41ae6 Bug: v8:11420 Change-Id: I65ac4f2a100ada91f7009ff8990bb6079d00e7dc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2986416Reviewed-by: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Commit-Queue: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Auto-Submit: Liu yu <liuyu@loongson.cn> Cr-Commit-Position: refs/heads/master@{#75412}
-
Sigurd Schneider authored
Bug: chromium:1213393 Change-Id: I6c7d334cc2c3e6d9f6bdc5ca119a71c2fc013e88 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2992710 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Auto-Submit: Sigurd Schneider <sigurds@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#75411}
-
Igor Sheludko authored
Bug: v8:11880 Change-Id: Ief047a62b7c9323fba8b7c2e4a3200a6db7e04c4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2992709 Commit-Queue: Igor Sheludko <ishell@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Auto-Submit: Igor Sheludko <ishell@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#75410}
-
Marja Hölttä authored
Bug: v8:11111 Change-Id: Ieb9e8d1440b57f3840857c34debfece337bf4f51 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2979598 Commit-Queue: Marja Hölttä <marja@chromium.org> Reviewed-by: Igor Sheludko <ishell@chromium.org> Reviewed-by: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/master@{#75409}
-
Santiago Aboy Solanes authored
This is a reland of 8f17052c Changes can be seen in PS1..4 (re-marked kraken/audio-beat-detection) Original change's description: > [test] Unmark TSAN tests as SLOW/SKIP > > We allowed more time for tsan testing [1] so unmarking some tests. > > [1]: https://chromium-review.googlesource.com/c/v8/v8/+/2979671 > > Bug: v8:7790, v8:11600, v8:11906 > Change-Id: I026a32abe0380c2d32327aaa8b301ef51f22a5e2 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2979602 > Reviewed-by: Mythri Alle <mythria@chromium.org> > Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> > Cr-Commit-Position: refs/heads/master@{#75357} Bug: v8:7790, v8:11600, v8:11906 Change-Id: Ie5b8886820d8e7d18c8ceee612a5c4d9ef72bc49 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2983536Reviewed-by: Mythri Alle <mythria@chromium.org> Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Cr-Commit-Position: refs/heads/master@{#75408}
-
Victor Gomes authored
https://groups.google.com/a/chromium.org/g/blink-dev/c/di9BL9d1CKI/m/6_GkR7eMAgAJ Bug: chromium:1213927 Change-Id: I22226007f906fba7f523e15ad8abea09bcbcee77 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2988749 Auto-Submit: Victor Gomes <victorgomes@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Reviewed-by: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#75407}
-
Michael Achenbach authored
This limits the feature of running Memory-hungry tests in sequence to the GCE bots in swarming. There, the positive memory impact is large due to the overall lower system memory and the negative runtime impact is small due to the smaller number of cores. Bug: v8:11928 Change-Id: Ib577b455d5cccbb3c9855526becbdbf822259bea Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2991630 Auto-Submit: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Liviu Rau <liviurau@chromium.org> Reviewed-by: Liviu Rau <liviurau@chromium.org> Cr-Commit-Position: refs/heads/master@{#75406}
-
Patrick Thier authored
With batch compilation, tracing messages for OSR were wrong and misleading. Since we can trace when and where we enter baseline code with other flags (--trace-unoptimized) we can remove tracing for baseline OSR. Bug: v8:11420 Change-Id: I72483c9262b7009652664739b692fd32bd936e20 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2988403 Auto-Submit: Patrick Thier <pthier@chromium.org> Reviewed-by: Toon Verwaest <verwaest@chromium.org> Reviewed-by: Nico Hartmann <nicohartmann@chromium.org> Commit-Queue: Nico Hartmann <nicohartmann@chromium.org> Cr-Commit-Position: refs/heads/master@{#75405}
-
Victor Gomes authored
- Creates v8root to reconcile support with blaze - Adds -m32 flag for 32 bit architectures No-Try: true Bug: v8:11234 Change-Id: I1c0b68b92922ee00cbfb960625c7be62445f636a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2987834Reviewed-by: Camillo Bruni <cbruni@chromium.org> Commit-Queue: Victor Gomes <victorgomes@chromium.org> Auto-Submit: Victor Gomes <victorgomes@chromium.org> Cr-Commit-Position: refs/heads/master@{#75404}
-
Victor Gomes authored
No-Try: true Bug: v8:11234 Change-Id: I82a066bfc395718f1b295f52785600aaa34604e3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2985402 Auto-Submit: Victor Gomes <victorgomes@chromium.org> Reviewed-by: Camillo Bruni <cbruni@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#75403}
-
Lu Yahan authored
Change-Id: Id9820ec6f21a08a5437bc847d7199e12f1daedf0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2992391 Auto-Submit: Yahan Lu <yahan@iscas.ac.cn> Commit-Queue: Ji Qiu <qiuji@iscas.ac.cn> Reviewed-by: Ji Qiu <qiuji@iscas.ac.cn> Cr-Commit-Position: refs/heads/master@{#75402}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/f8a6922..aeb5c9d Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/a73eec2..2a6dffa Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/49e7cd9..6274a55 TBR=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: I41c53f201fa84ea686de969ab5bcffd0402d18a4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2992318Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#75401}
-
- 27 Jun, 2021 1 commit
-
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/d3674b9..f8a6922 TBR=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: If692309f6319c56bba94e58f4c55ba08a7c88a3e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2991853Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#75400}
-
- 26 Jun, 2021 1 commit
-
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/9dc1297..d3674b9 Rolling v8/buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/46bcd59..82a4d60 Rolling v8/buildtools/linux64: git_revision:d924640c25f9d90386716116a53957f24d709042..git_revision:4d207c94eab41f09c9a8505eb47f3d2919e47943 Rolling v8/buildtools/third_party/libc++/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx/+log/8fa8794..79a2e92 Rolling v8/third_party/aemu-linux-x64: JZYvEBpGNCDNOK3uLHlpKn_AN6roNsL0YVup96egRSEC..A1XxYDWVeZi3lNSg1lZdcmGtIB2fA0XTIPYdevon60YC Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/a2a4ced..11a2ddf Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/cf60c0a..a73eec2 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/098695c..49e7cd9 Rolling v8/tools/luci-go: git_revision:2adc53281f4a72ecb71e84a8af5acc0fced04cc9..git_revision:8ed83b4afa51020c8900d121bb57624b35882dec Rolling v8/tools/luci-go: git_revision:2adc53281f4a72ecb71e84a8af5acc0fced04cc9..git_revision:8ed83b4afa51020c8900d121bb57624b35882dec Rolling v8/tools/luci-go: git_revision:2adc53281f4a72ecb71e84a8af5acc0fced04cc9..git_revision:8ed83b4afa51020c8900d121bb57624b35882dec TBR=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: I9b820d261ef642c5bbd53b331c24e0757389a585 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2989108Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#75399}
-
- 25 Jun, 2021 14 commits
-
-
Milad Fa authored
Change-Id: I57c6989ff0ca872b66567c701c2b9bf8ee6e83d9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2983069 Commit-Queue: Milad Fa <mfarazma@redhat.com> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#75398}
-
Junliang Yan authored
Change-Id: I36000eaafd18b9eca8d302d977ad8e2f1205af35 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2989137 Auto-Submit: Junliang Yan <junyan@redhat.com> Reviewed-by: Milad Fa <mfarazma@redhat.com> Commit-Queue: Junliang Yan <junyan@redhat.com> Cr-Commit-Position: refs/heads/master@{#75397}
-
Igor Sheludko authored
... implications of not having Code pointers in the non-code spaces anywhere except CodeDataContainer objects. Tbr: jgruber@chromium.org Bug: v8:11880 Change-Id: Ide7482bd5a95776de50f8d94adaefb078b611d6e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2987837Reviewed-by: Igor Sheludko <ishell@chromium.org> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#75396}
-
Igor Sheludko authored
StoreICs use slow handler for now. Bug: v8:11804 Change-Id: I008fc9a3639f649b63881f759078e664b16e25e3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2985403Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#75395}
-
Andreas Haas authored
R=jkummerow@chromium.org Bug: v8:11879 Change-Id: Ie0f748d78dd62d881dd4e97f9e2be19ef5a7bca9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2987830 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#75394}
-
Clemens Backes authored
This reverts commit 3161106e. Reason for revert: Breaks layout tests (missing handle scope): https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Blink%20Linux/12278/overview Original change's description: > [wasm] Initialize compilation progress before compilation units > > Initializing the compilation progress first, and making it an explicit > step, allows us to share the wrapper compilation code between async > compilation and streaming compilation. In the future it will also allow > us to initialize compilation units based on the compilation progress, > which will allow us to share more code between async compilation and > deserialization. > > R=clemensb@chromium.org > > Bug: v8:11862 > Change-Id: If8394f3068840f759b8325ba806549dbd208f195 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2978258 > Commit-Queue: Andreas Haas <ahaas@chromium.org> > Reviewed-by: Clemens Backes <clemensb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#75380} Bug: v8:11862 Change-Id: I05fa906a86ba8d3226356bcda99786a4a82e6374 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2988416 Auto-Submit: Clemens Backes <clemensb@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#75393}
-
Leszek Swirski authored
In case we find that Sparkplug benefits require short builtin calls, add a --sparkplug-needs-short-builtins flag to make the former depend on the latter. Change-Id: I5b23abbd9ad6e0d11d7033497d5755f08c2ab876 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2988753 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#75392}
-
Jakob Kummerow authored
This just moves the existing algorithm, and translates it from Handle<BigInt> to Digits as underlying data format. Bug: v8:11515 Change-Id: Ieefee4e953e14f4c574aebab94d825ddb7c31f8c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2975304 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/master@{#75391}
-
Milad Fa authored
Newly added test under https://crrev.com/c/2987824 needs to be skipped on unsupported platforms. Change-Id: Ib5d222c09726cd63328ea894c3e6ea7e1e1bd3e5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2988361Reviewed-by: Clemens Backes <clemensb@chromium.org> Commit-Queue: Milad Fa <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/master@{#75390}
-
Junliang Yan authored
Change-Id: Iffe01cd3b49aa8b590b4930b3ea94fb52419b83c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2985502 Auto-Submit: Junliang Yan <junyan@redhat.com> Reviewed-by: Milad Fa <mfarazma@redhat.com> Commit-Queue: Junliang Yan <junyan@redhat.com> Cr-Commit-Position: refs/heads/master@{#75389}
-
Clemens Backes authored
The cached memory start was not preserved across stack checks in debug code. This only manifests if the stack check is actually executed, hence it's tricky to reproduce. R=ahaas@chromium.org Bug: chromium:1222648 Change-Id: I8d678305022e3521bd457ad49ebed30d81b05231 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2987824 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#75388}
-
Mythri A authored
The code and prototype_or_initial_map fields are marked as weak in the torque definition of JSFunction. Given we don't have any annotations that generate BodyDescriptors or the C++ class specifying weak there didn't reflect in the actual C++ implementation. In the C++ implementation we were treating those as strong pointers and the rest of the code also expects them as strong pointers and doesn't actually deal with cleared weak references. Since JSFunction's header doesn't have any weak references we can just fallback to JSObject::BodyDescriptor that iterates through all header fields and the other JSObject fields as strong pointers. This is what was happening because JSFunction didn't have a body descriptor and we were falling back to JSObject::BodyDescriptor So this is a clean up CL to avoid confusion. There shouldn't be any change in behaviour. So this CL basically: 1. Drops weak from the torque definition to match with implementation 2. Changes JSFunction::BodyDescriptor to JSObject::BodyDescriptor when iterating over objects to be consistent with other JSObjects with strong pointers. Change-Id: I7c3e49f1759164a0f2517b3d5b8d0e5169b025ff Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2987827Reviewed-by: Nico Hartmann <nicohartmann@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Commit-Queue: Mythri Alle <mythria@chromium.org> Cr-Commit-Position: refs/heads/master@{#75387}
-
Victor Gomes authored
No-Try: true Change-Id: I1aee4944bf4b33cb4b1be745bedb88ac63c6d9e3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2987832Reviewed-by: Patrick Thier <pthier@chromium.org> Commit-Queue: Patrick Thier <pthier@chromium.org> Auto-Submit: Victor Gomes <victorgomes@chromium.org> Cr-Commit-Position: refs/heads/master@{#75386}
-
Clemens Backes authored
Some flag comments and descriptions contained "Turbofan" instead of "TurboFan". R=ahaas@chromium.org Bug: v8:11879 Change-Id: I7e4c6a8820b6ab31eb2f868641a20004faf7104a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2985401Reviewed-by: Andreas Haas <ahaas@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#75385}
-