• Mythri A's avatar
    [objects] Fix torque definition of JSFunction · 26ebc4f7
    Mythri A authored
    The code and prototype_or_initial_map fields are marked as weak in the
    torque definition of JSFunction. Given we don't have any annotations
    that generate BodyDescriptors or the C++ class specifying weak there
    didn't reflect in the actual C++ implementation.
    
    In the C++ implementation we were treating those as strong pointers
    and the rest of the code also expects them as strong pointers and
    doesn't actually deal with cleared weak references.
    
    Since JSFunction's header doesn't have any weak references we can just
    fallback to JSObject::BodyDescriptor that iterates through all header
    fields and the other JSObject fields as strong pointers. This is what
    was happening because JSFunction didn't have a body descriptor and
    we were falling back to JSObject::BodyDescriptor
    
    So this is a clean up CL to avoid confusion. There shouldn't be
    any change in behaviour.
    
    So this CL basically:
    1. Drops weak from the torque definition to match with implementation
    2. Changes JSFunction::BodyDescriptor to JSObject::BodyDescriptor when
    iterating over objects to be consistent with other JSObjects with
    strong pointers.
    
    Change-Id: I7c3e49f1759164a0f2517b3d5b8d0e5169b025ff
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2987827Reviewed-by: 's avatarNico Hartmann <nicohartmann@chromium.org>
    Reviewed-by: 's avatarGeorg Neis <neis@chromium.org>
    Commit-Queue: Mythri Alle <mythria@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#75387}
    26ebc4f7
Name
Last commit
Last update
.github Loading commit data...
bazel Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.bazelrc Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.mailmap Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.bazel Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
WORKSPACE Loading commit data...
codereview.settings Loading commit data...