- 24 Apr, 2019 34 commits
-
-
Z Duong Nguyen-Huu authored
Bug: v8:6831 Change-Id: I4d4d9b65a346384b8f6c6dc2cfe0c1ce88116e18 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1574503 Commit-Queue: Z Nguyen-Huu <duongn@microsoft.com> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#60993}
-
Mathias Bynens authored
It shipped in Chrome 73. Bug: v8:8021 Change-Id: I82875829ff081ce055a0184170b15c65efca1c38 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1581647 Commit-Queue: Mathias Bynens <mathias@chromium.org> Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Auto-Submit: Mathias Bynens <mathias@chromium.org> Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#60992}
-
Clemens Hammacher authored
This reverts commit 81dd67db. Reason for revert: Breaks gc-stress: https://ci.chromium.org/p/v8/builders/ci/V8%20Linux%20-%20gc%20stress/22111 Original change's description: > Improve test coverage for non-extensible holey array in optimized code > > Bug: v8:6831 > Change-Id: Icb4b504771e623b3c9503c6daffd7b771fbef3a6 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1575036 > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Commit-Queue: Z Nguyen-Huu <duongn@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#60990} TBR=verwaest@chromium.org,duongn@microsoft.com Change-Id: I0a581c1e47d9883a2727000843ad4e9ede2e411d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:6831 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1581648Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#60991}
-
Z Duong Nguyen-Huu authored
Bug: v8:6831 Change-Id: Icb4b504771e623b3c9503c6daffd7b771fbef3a6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1575036Reviewed-by:
-
Ross McIlroy authored
This is a reland of d6121fd1 Original change's description: > [Interpreter] Ensure Test*Handler don't allocate a frame for fast-path. > > Avoids allocating a frame for the fast-path in TestEqual, TestEqualStrict and > TestLess/GreaterThan bytecode handlers. Also changes how feedback is tracked > to try and avoid needing to keep feedback to "combine" with if it's unecessary > which reduces the liveranges of the registers holding this data. > > This reduces the time needed for a tight loop in Ignition (e.g., > while (i < 1000000000) ++i;) from 12.8s to 10.8s. > > BUG=v8:9133 > > Change-Id: I686b9da89541d15d233635db3276de3dad2fa282 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1570020 > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#60906} TBR=jgruber@chromium.org Bug: v8:9133 Change-Id: Ie9940d029d412986e6713438630565a98fe3c51c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1582401Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#60989}
-
Hannes Payer authored
Bug: v8:9093 Change-Id: I6d71e8ebd34e2495312b01facbb896e0d5ae8a8a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1581645 Auto-Submit: Hannes Payer <hpayer@chromium.org> Commit-Queue: Hannes Payer <hpayer@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#60988}
-
Joey Gouly authored
Use `padreg` instead of x18 to maintain alignment in the CPURegList. Also clean up some comments and tidy up RequiredStackSizeForCallerSaved and PushCallerSaved. Change-Id: I80a780e5649e69a1746c43f37c2d1d875120c7a0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1581609Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Commit-Queue: Martyn Capewell <martyn.capewell@arm.com> Cr-Commit-Position: refs/heads/master@{#60987}
-
Tobias Tebbi authored
The order of the typeswitch branches causes repeated Smi-checks. This CL fixes this by putting the Number case first. However, the generated code is still worse due to repeated Map and InstanceType loads. This will be fixed by a future load elimination for Torque/CSA. Bug: chromium:955976 Change-Id: I0f59ef795878f65b3cb11246626738bc33f8aff5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1581644 Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
-
Mathias Bynens authored
It shipped in Chrome 72. Bug: v8:7782 Change-Id: I9ddee4370dd65821020dd7292d9e9b9850d060df Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1581603Reviewed-by:
-
Tobias Tebbi authored
Add suport for large object space allocations in Turbofan and use it from CSA when young large objects are enabled. This maintains the Turbofan invariant that the generation is statically predictable. In principle, this enables write barrier elimination for large objects allocated from Torque/CSA. But it doesn't seem to trigger much yet, probably we have to improve the MemoryOptimizer. Bug: v8:7793 Change-Id: I7ea7d0cb549573db65fafe5df5edf67e0ce90893 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1565905Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#60984}
-
Simon Zünd authored
This CL changes lint errors to not be printed directly to stderr. Instead, they are collected in a list that gets surfaced via the TorqueCompilerResult. This is done so they can be presented to language server clients. This change also removes the "abort_on_lint_errors" option. API users can now decide for themselves what to do, depending on the presence of lint errors in the returned list. R=sigurds@chromium.org, tebbi@chromium.org Bug: v8:8880 Change-Id: I44601010491aafcf4c8609fd8c115219317506a4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1581608Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#60983}
-
Igor Sheludko authored
... and make the checks stricter. Bug: chromium:954852 Change-Id: Ib28246d275b0cadff00012f02f8aca4c4c235cc5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1581599 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#60982}
-
Jakob Gruber authored
When collecting JS block coverage, we track block execution counts on so-called CoverageInfo objects. Generated bytecode and native code contains inlined snippets of code to increment the appropriate counters. These used to be implemented as calls to the IncBlockCounter runtime function. Each call incurred the entire CEntry overhead. This CL reduces that overhead by moving logic over into a new IncBlockCounter TFS builtin. The builtin is called directly from bytecode, and lowered to the same builtin call for optimized code. Drive-by: Tweak CoverageInfo layout to generate faster code. Tbr: jarin@chromium.org Bug: v8:9149, v8:6000 Change-Id: I2d7cb0db649edf7c56b5ef5a4683d27b1c34605c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1571420Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#60981}
-
Sergiy Belozorov authored
The --run-count-multiplier flag was used to run an experiment and is not needed anymore. It will be superceeded by another parameter that will run benchmarks as many times as needed until needed confidence is achieved. R=machenbach@chromium.org No-Try: true No-Tree-Checks: true Bug: chromium:880724 Change-Id: Iedd3d0f900a838f97cfa3339f582f6d02cce3e93 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1578504 Commit-Queue: Sergiy Belozorov <sergiyb@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#60980}
-
peterwmwong authored
Bug: v8:8976 Change-Id: Idc896770fd0f448c37d8d83b7970e3f8e16f5f2e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1572682 Commit-Queue: Peter Wong <peter.wm.wong@gmail.com> Reviewed-by:
Simon Zünd <szuend@chromium.org> Reviewed-by:
-
Jaroslav Sevcik authored
This fixes the bounds check for the 'in' operator to handle the negative index case properly (by using the same machinery as the potentially out-of-bounds loads/stores use). Bug: chromium:952586 Change-Id: I2225acae8be7dcedbcde745e8ef202e789085041 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1581179Reviewed-by:
Georg Neis <neis@chromium.org> Commit-Queue: Jaroslav Sevcik <jarin@chromium.org> Cr-Commit-Position: refs/heads/master@{#60978}
-
Michael Starzinger authored
This extends the existing test coverage of interactions between the exception handling and the reference type proposal. Now "any-func" and "except-ref" can both be encoded as an exception value. Missing switch cases have been added. R=clemensh@chromium.org TEST=mjsunit/wasm/exceptions-anyref[-interpreter] BUG=v8:8091,v8:7581 Change-Id: Ie2e9819fe66b4daab623390f27bb19007131f619 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1581600Reviewed-by:
-
Ross McIlroy authored
On Arm/64 the last return address is stored in a link register instead of being pushed to the top-of-stack like on x64/ia32. Extend the support in the tick sampler to check for samples in a frameless bytecode handler with support for checking the link register if it exists instead of top-of-stack. In addition, make the x64/ia32 check more robust by ensuring we only apply the change if the pc is a bytecode handler and the top frame isn't a bytecode handler (stub) frame. BUG=v8:9162 Change-Id: I89d2e80ea8a0b84ff6a265d0e0e73f9fdd1daca8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1578464Reviewed-by:
-
Clemens Hammacher authored
Use the existing {ArrayVector} method for this, which reads nicer. In some places, I replaced a stack-allocated array by {EmbeddedVector} to avoid the {ArrayVector} call. R=mstarzinger@chromium.org Bug: v8:8834 Change-Id: I5560c07f2775338fefd11acf67a540e003428e74 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1578899Reviewed-by:Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#60975}
-
Clemens Hammacher authored
This is one step towards removing the {StrLength} helper and using {size_t} consistently instead. R=mstarzinger@chromium.org Bug: v8:8834 Change-Id: Ibcdfd579531a259d490c39a8e8c96d469a5a4aac Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1578901 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: -
Sigurd Schneider authored
This reverts commit fa6ec3cb. Reason for revert: v8:9169, v8:9170 https://ci.chromium.org/p/v8/builders/ci/V8%20Linux/31457 https://ci.chromium.org/p/v8/builders/ci/V8%20Linux64/31417 https://ci.chromium.org/p/v8/builders/ci/V8%20Win32%20-%20debug/19919 Original change's description: > [cpu-profiler] Split out debug mode for CPU profiler naming > > Adds a new flag to CpuProfiler to control whether or not "debug" names > (potentially inferred from scope) are used for captured frames > associated with a SharedFunctionInfo instance. > > Bug: v8:9135 > Change-Id: I104f3246431dc6336de4e4688c0d98c86e0bb776 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1566169 > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Reviewed-by: Alexei Filippov <alph@chromium.org> > Reviewed-by: Peter Marshall <petermarshall@chromium.org> > Commit-Queue: Peter Marshall <petermarshall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#60972} TBR=ulan@chromium.org,alph@chromium.org,yangguo@chromium.org,petermarshall@chromium.org,acomminos@fb.com Change-Id: I573194b5affd31fd0748b9ef3c45052e8ab420f5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:9135 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1581639Reviewed-by:
-
Andrew Comminos authored
Adds a new flag to CpuProfiler to control whether or not "debug" names (potentially inferred from scope) are used for captured frames associated with a SharedFunctionInfo instance. Bug: v8:9135 Change-Id: I104f3246431dc6336de4e4688c0d98c86e0bb776 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1566169Reviewed-by:
Alexei Filippov <alph@chromium.org> Reviewed-by:
-
Michael Lippautz authored
Removes APIs: - MarkIndependent - IsIndependent - MarkActive - RegisterExternalReference All weak persistent handles are now treated as independent. Users of traced handles should already use v8::EmbedderHeapTracer. This reverts commit 49954eb5. Bug: chromium:923361 Change-Id: I0b9fcd678964331f926f6b725f70eb64268ca33f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1578462 Auto-Submit: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
The current logic sometimes skips the request for a code logging stack guard request, even though no such request is pending. This happens if the previous stack guard already executed, but a foreground task is still pending. This CL fixes this by re-requesting a stack guard interrupt when the first code is added to the vector of outstanding code to be logged. Plus minor drive-by fix. R=mstarzinger@chromium.org Bug: v8:9163 Change-Id: I4937f3983f15e7122141b04ddb1432cd1f78828b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1578461 Auto-Submit: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Michael Starzinger authored
R=titzer@chromium.org TEST=mjsunit/regress/regress-9165 BUG=v8:9165 Change-Id: If6d7d56bf164a85675590e69bf9857c11fc1b218 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1578463Reviewed-by:
Ben Titzer <titzer@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#60969}
-
Santiago Aboy Solanes authored
... for * in ("", "Tagged", "Signed"). Cq-Include-Trybots: luci.v8.try:v8_linux64_pointer_compression_rel_ng Cq-Include-Trybots: luci.v8.try:v8_linux64_arm64_pointer_compression_rel_ng Bug: v8:7703 Change-Id: I6891fea9596058e7290df7a6b6775dd8a184ea2f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1578500Reviewed-by: -
Sergiy Belozorov authored
R=machenbach@chromium.org, tmrts@chromium.org Bug: chromium:841700 Change-Id: I9852ccc573eda6b1bab7a7db295f7fd6e7410581 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1570010 Commit-Queue: Sergiy Belozorov <sergiyb@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
This is an attempt to work around a potential toolchain bug. Disassembly of FlushICache: 00000000 <_ZN2v88internal11CpuFeatures11FlushICacheEPvj>: 0:·b5c0 ··push··{r6, r7, lr} 2:·af01 ··add·r7, sp, #4 4:·2702 ··movs··r7, #2 6:·4401 ··add·r1, r0 8:·f2c0 070f ··movt··r7, #15 c:·2200 ··movs··r2, #0 e:·df00 ··svc·0 10:·bdc0 ··pop·{r6, r7, pc} Bug: chromium:952759 Change-Id: I6a618607f58c394c364b2ebd9f11684871a8beee Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1579542 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: -
Clemens Hammacher authored
They were introduced in https://crrev.com/c/559674, but never used. R=neis@chromium.org Bug: v8:8834 Change-Id: I773bc1ba14c7a1d5adc1a483f539221f18042361 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1578505Reviewed-by:
-
Toon Verwaest authored
Change-Id: I34dc911d205ab507f668bfd422eb1838f660a6bf Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1571624 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Reviewed-by:
-
Tobias Tebbi authored
Bug: v8:8880 Change-Id: I8693def4aea26a5a9430f4c49d701fae14b2f27b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1578502Reviewed-by:
-
Michael Achenbach authored
This prepares removing the special timeout of 200 on the bots. First we temporarily set 200 on v8 side to remove the flag on the infra side. Afterwards we'll remove the v8-side code, tested in CQ. TBR=tmrts@chromium.org Bug: v8:9145 Change-Id: I61578da02ab8c101d0d6c916106ad5a8bc6841cb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1581259Reviewed-by:
Tamer Tas <tmrts@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#60962}
-
v8-ci-autoroll-builder authored
Rolling v8/test/wasm-js/data: https://chromium.googlesource.com/external/github.com/WebAssembly/spec/+log/c46d4fa..43898ad [spec] Fix off-by-one error in table grow size limit (#1005) (Andreas Rossberg) https://chromium.googlesource.com/external/github.com/WebAssembly/spec/+/43898ad TBR=ahaas@chromium.org,clemensh@chromium.org Change-Id: Ibfc45cc4f5bc81e72c3340d830f059b5493f069e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1581082Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#60961}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/7dae72d..5160e91 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/fb33e51..429d9b4 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/6d9913a..0d82718 Rolling v8/third_party/googletest/src: https://chromium.googlesource.com/external/github.com/google/googletest/+log/9f893b9..a53e931 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: Ic65275bf40a1d69ef176c24b3cf75f7de5d84085 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1580800Reviewed-by:
-
- 23 Apr, 2019 6 commits
-
-
Z Duong Nguyen-Huu authored
Bug: chromium:953888 Change-Id: If2aa613bac18e61ac733102b45b0ebb6553eae1a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1579539Reviewed-by:
-
Michael Achenbach authored
Change-Id: I574f647245d215b03a59b6c3dd6889e94f4d7708 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1578507Reviewed-by:
-
Sathya Gunasekaran authored
In the PerformPromise{All, Race, AllSettled} operations, the resolve property of the constructor is looked up only once. In the implementation, for the fast path, where the constructor's resolve property is untainted, the resolve function is set to undefined. Since undefined can't be a valid value for the resolve function, we can switch on it (in CallResolve) to directly call the PromiseResolve builtin. If the resolve property is tainted, we do an observable property lookup, save this value, and call this property later (in CallResolve). I ran this CL against the test262 tests locally and they all pass: https://github.com/tc39/test262/pull/2131 Spec: - https://github.com/tc39/ecma262/pull/1506 - https://github.com/tc39/proposal-promise-allSettled/pull/40 Bug: v8:9152 Change-Id: Icb36a90b5a244a67a729611c7b3315d2c29de6e9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1574705 Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by: -
Michael Achenbach authored
TBR=tmrts@chromium.org Bug: v8:9145,v8:9098 Change-Id: Ib2170819f6d9aa00174fefb6bef4b0a27c11acfc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1578503Reviewed-by:
Sergiy Belozorov <sergiyb@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#60956}
-
andrew-cc-chen authored
Change-Id: I2bc21a353c871652daeac87eae62e1e6ae740b49 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1529638Reviewed-by:
-
Michael Lippautz authored
This reverts commit 1ebf5f72. Reason for revert: Breaks TSAN Original change's description: > [api,heap] Remove deprecated Persistent APIs > > Removes APIs: > - MarkIndependent > - IsIndependent > - MarkActive > - RegisterExternalReference > > All weak persistent handles are now treated as independent. Users of > traced handles should already use v8::EmbedderHeapTracer. > > Bug: chromium:923361 > Change-Id: Ic90a647fe2ce9db92197ad6560e4907290805592 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1578459 > Commit-Queue: Michael Lippautz <mlippautz@chromium.org> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#60953} TBR=ulan@chromium.org,mlippautz@chromium.org Change-Id: I8281daf30b67c1b71ef6e65d8f13a59230ba0334 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:923361 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1578900Reviewed-by:
-
