- 02 Mar, 2018 24 commits
-
-
Sigurd Schneider authored
This is subsumed by an optimization is JSCallReducer now. Bug: v8:7340, v8:7250 Change-Id: I6c706177e410abd57ea24a7ffbbe2437733ed7c7 Reviewed-on: https://chromium-review.googlesource.com/946088Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#51697}
-
Camillo Bruni authored
Bug: v8:7266 Change-Id: I2835ec79aaa2821aca288685a3f230a7f8029186 Reviewed-on: https://chromium-review.googlesource.com/941948 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Michael Stanton <mvstanton@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#51696}
-
Camillo Bruni authored
This CL removes the last method taking a raw callback as argument. Bug: chromium:782550 Change-Id: Ia7f19120be7dcb2648f11cd3cdb8880f8818490d Reviewed-on: https://chromium-review.googlesource.com/822198 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#51695}
-
Mathias Bynens authored
This patch removes the NumberConstructor_ConstructStub builtin, merging its functionality into the refactored NumberConstructor TurboFan builtin. This brings us closer to our goal of deprecating the `construct_stub` field in `SharedFunctionInfo`. Bug: v8:7503, v8:7518 Change-Id: Ia407a2d43cda9fc7b26e13274fd79f110b6232ca Reviewed-on: https://chromium-review.googlesource.com/946008 Commit-Queue: Mathias Bynens <mathias@chromium.org> Reviewed-by:
-
Camillo Bruni authored
- Add B/KiB/MiB units to histograms - Auto select fileReader to open dialog when pressing enter Bug: v8:7266 Change-Id: I6fa56d2fa112f6ddbd541304cd26a1f6bd9322ce No-Try: true Reviewed-on: https://chromium-review.googlesource.com/946128Reviewed-by:
-
Camillo Bruni authored
This prevents us from accidentally overwriting the default map of the empty_fixed_array since NewFixedArray might just return that. Change-Id: Id2fd20db1c07ec0289905ce5b0e12b5530a60229 Reviewed-on: https://chromium-review.googlesource.com/942923Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#51692}
-
Sigurd Schneider authored
This is a reland of b8bc26d0 Original change's description: > [turbofan] Preserve order of compares in switches > > This CL makes sure that control flow optimization does > not change the order of switches that ultimately get > lowered to a series of comparisons anyway. > > Bug: v8:7326 > Change-Id: If004de6b71a7e9504d37754c847ca108a64e49db > Reviewed-on: https://chromium-review.googlesource.com/941952 > Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> > Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> > Commit-Queue: Sigurd Schneider <sigurds@chromium.org> > Cr-Commit-Position: refs/heads/master@{#51679} Bug: v8:7326 Change-Id: Ifbe61dece499c98bbd49fa3ae9b99ccf4e955ddc Reviewed-on: https://chromium-review.googlesource.com/945770Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#51691}
-
Camillo Bruni authored
- Categorize more instance types - Fix GC selection dropdown labels - Show GC times in seconds - Collapse file reader after loading Bug: v8:7266 Change-Id: If967ebdb887105e808cfc8fb3bc92f9da5c91fd2 No-Try: true Reviewed-on: https://chromium-review.googlesource.com/945908Reviewed-by:
-
Michael Starzinger authored
R=clemensh@chromium.org BUG=v8:7509 Change-Id: If4c199535f9a039f648c54bc72094dbc4218607d Reviewed-on: https://chromium-review.googlesource.com/945731Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#51689}
-
Sigurd Schneider authored
Bug: v8:7444 Change-Id: Ib4f5134ff57127a5ce4d57dbc42e52111ab938ff Reviewed-on: https://chromium-review.googlesource.com/940941Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#51688}
-
Michael Starzinger authored
This makes sure that the object can be identified by a unique instance type and hence is not accidentally confused with other FixedArrays on the heap. R=clemensh@chromium.org BUG=v8:7509 Change-Id: Ib3dcdb4559821d0ad9ca8cced37754e0e3c1d578 Reviewed-on: https://chromium-review.googlesource.com/943781 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
-
Georg Neis authored
This reverts commit f48e7349. Reason for revert: innocent!! Original change's description: > Revert "[parsing] inline ArrayLiteral creation for spread calls" > > This reverts commit 93fc3841. > > Reason for revert: may break node.js integration > > Original change's description: > > [parsing] inline ArrayLiteral creation for spread calls > > > > Instead of using runtime calls to generate the Array Literal passed to > > %reflect_call / %reflect_construct, we create an ArrayLiteral from the > > list of arguments, and perform spreads using the interpreter mechanism for > > spreading in ArrayLiterals (thus, the spreading becomes inline). This > > array literal is still passed to %reflect_call / %reflect_construct as > > before. > > > > This cuts the runtime for bench-spread-call.js -> testSpread roughly in > > half, and will likely improve further once > > https://chromium-review.googlesource.com/c/v8/v8/+/915364 has landed. > > > > BUG=v8:7446 > > R=neis@chromium.org, adamk@chromium.org > > > > Change-Id: I74a6acd3a60aad422e4ac575275c7b567659d8ad > > Reviewed-on: https://chromium-review.googlesource.com/939587 > > Commit-Queue: Georg Neis <neis@chromium.org> > > Reviewed-by: Georg Neis <neis@chromium.org> > > Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#51678} > > TBR=adamk@chromium.org,neis@chromium.org,caitp@igalia.com,bmeurer@chromium.org > > Change-Id: I4730077591bce0e5e7b2ce7d59678e8b7135cc08 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: v8:7446 > Reviewed-on: https://chromium-review.googlesource.com/945769 > Reviewed-by: Sigurd Schneider <sigurds@chromium.org> > Commit-Queue: Sigurd Schneider <sigurds@chromium.org> > Cr-Commit-Position: refs/heads/master@{#51682} TBR=adamk@chromium.org,neis@chromium.org,sigurds@chromium.org,caitp@igalia.com,bmeurer@chromium.org Change-Id: I977513bea06a4f3fba03fa4a89270298475422e2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7446 Reviewed-on: https://chromium-review.googlesource.com/945808Reviewed-by:
Georg Neis <neis@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#51686}
-
Clemens Hammacher authored
Table inits can contain imported functions, hence their code will be a wasm-to-wasm wrapper. Fix a DCHECK and add a regression test. R=ahaas@chromium.org Bug: chromium:817380 Change-Id: I836be589e1ae66839ccd470154c8dea488e6bc1f Reviewed-on: https://chromium-review.googlesource.com/943107 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#51685}
-
Benedikt Meurer authored
Previously the array iterator protector only guarded the lookup of the @@iterator symbol on the initial Array.prototype, and we had to use an additional map check on the %ArrayIteratorPrototype% to ensure that no one messed with the next() method. This CL extends the array iterator protector to also guard the lookup of %ArrayIteratorPrototype%.next. This simplifies the code quite a bit and makes it more robust for cases where someone has to install additional methods on the iterator prototype, i.e. a custom async iterator. Bug: v8:7510, v8:7514 Change-Id: Ie6080bb837a91a2b60b224597121470614210660 Reviewed-on: https://chromium-review.googlesource.com/945728Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Reviewed-by:
-
Sigurd Schneider authored
Bug: v8:7250, v8:7340 Change-Id: Ic302a811dd827fc1692240c225b3e580a54a3a2f Reviewed-on: https://chromium-review.googlesource.com/943422Reviewed-by:
-
Sigurd Schneider authored
This reverts commit 93fc3841. Reason for revert: may break node.js integration Original change's description: > [parsing] inline ArrayLiteral creation for spread calls > > Instead of using runtime calls to generate the Array Literal passed to > %reflect_call / %reflect_construct, we create an ArrayLiteral from the > list of arguments, and perform spreads using the interpreter mechanism for > spreading in ArrayLiterals (thus, the spreading becomes inline). This > array literal is still passed to %reflect_call / %reflect_construct as > before. > > This cuts the runtime for bench-spread-call.js -> testSpread roughly in > half, and will likely improve further once > https://chromium-review.googlesource.com/c/v8/v8/+/915364 has landed. > > BUG=v8:7446 > R=neis@chromium.org, adamk@chromium.org > > Change-Id: I74a6acd3a60aad422e4ac575275c7b567659d8ad > Reviewed-on: https://chromium-review.googlesource.com/939587 > Commit-Queue: Georg Neis <neis@chromium.org> > Reviewed-by: Georg Neis <neis@chromium.org> > Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#51678} TBR=adamk@chromium.org,neis@chromium.org,caitp@igalia.com,bmeurer@chromium.org Change-Id: I4730077591bce0e5e7b2ce7d59678e8b7135cc08 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7446 Reviewed-on: https://chromium-review.googlesource.com/945769Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#51682}
-
Sigurd Schneider authored
This reverts commit b8bc26d0. Reason for revert: may break node.js integration Original change's description: > [turbofan] Preserve order of compares in switches > > This CL makes sure that control flow optimization does > not change the order of switches that ultimately get > lowered to a series of comparisons anyway. > > Bug: v8:7326 > Change-Id: If004de6b71a7e9504d37754c847ca108a64e49db > Reviewed-on: https://chromium-review.googlesource.com/941952 > Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> > Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> > Commit-Queue: Sigurd Schneider <sigurds@chromium.org> > Cr-Commit-Position: refs/heads/master@{#51679} TBR=jarin@chromium.org,sigurds@chromium.org,bmeurer@chromium.org Change-Id: Ideb551e0831c686dc7c247b77f59ff3485c30181 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7326 Reviewed-on: https://chromium-review.googlesource.com/945768Reviewed-by:
-
Camillo Bruni authored
This CL will temporarily regress memory since we will store the name both on the SFI and the ScopInfo. Future CLs will do the following: - Collapse the name field on SFI with the scopeInfo field - Store the ScopeInfo on the Context instead of the closure so we don't strongly hold on to the closure unnecessary Drive-by-fix: - Mark ScopeInfo accessors as const Bug: v8:7066 Change-Id: I7ef47d858352bb0bb76ad105f194eabce06938ed Reviewed-on: https://chromium-review.googlesource.com/939476Reviewed-by:
-
Sigurd Schneider authored
This CL makes sure that control flow optimization does not change the order of switches that ultimately get lowered to a series of comparisons anyway. Bug: v8:7326 Change-Id: If004de6b71a7e9504d37754c847ca108a64e49db Reviewed-on: https://chromium-review.googlesource.com/941952Reviewed-by:
-
Caitlin Potter authored
Instead of using runtime calls to generate the Array Literal passed to %reflect_call / %reflect_construct, we create an ArrayLiteral from the list of arguments, and perform spreads using the interpreter mechanism for spreading in ArrayLiterals (thus, the spreading becomes inline). This array literal is still passed to %reflect_call / %reflect_construct as before. This cuts the runtime for bench-spread-call.js -> testSpread roughly in half, and will likely improve further once https://chromium-review.googlesource.com/c/v8/v8/+/915364 has landed. BUG=v8:7446 R=neis@chromium.org, adamk@chromium.org Change-Id: I74a6acd3a60aad422e4ac575275c7b567659d8ad Reviewed-on: https://chromium-review.googlesource.com/939587 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
-
Camillo Bruni authored
Bug: v8:7266 Change-Id: Ifd3feedb0338fff9f442d6bb44c0dab5c1ac9fc6 R: mlippautz@chromium.orgA No-Try: true Reviewed-on: https://chromium-review.googlesource.com/943110Reviewed-by:
-
v8-autoroll authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/df4bee0..9ca0348 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/8a42ad3..414af52 Rolling v8/third_party/instrumented_libraries: https://chromium.googlesource.com/chromium/src/third_party/instrumented_libraries/+log/b745ddc..323cf32 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/b3d3f59..44042e5 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: Ie05eb56094c8447f7f128310eb23ac7d551f5a31 Reviewed-on: https://chromium-review.googlesource.com/945488Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#51676}
-
Deepti Gandluri authored
Bug: v8:6532 Change-Id: I6fde1fd2cc5776628af4e8a92e9b9ec030b398f7 Reviewed-on: https://chromium-review.googlesource.com/923718Reviewed-by:
Ben Smith <binji@chromium.org> Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/heads/master@{#51675}
-
Sathya Gunasekaran authored
Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I838bbb7c35c73edae8eaa7e94325e0c1341a0056 Reviewed-on: https://chromium-review.googlesource.com/944624Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#51674}
-
- 01 Mar, 2018 16 commits
-
-
Jakob Kummerow authored
Bug: v8:6791 Change-Id: I2799977e2a3ea275afa76edd56ee40083c1f0fe0 Reviewed-on: https://chromium-review.googlesource.com/944188Reviewed-by:
Adam Klein <adamk@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#51673}
-
Deepti Gandluri authored
This reverts commit 517df524. Reason for revert: Fails MSAN tests - https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20arm64%20-%20sim%20-%20MSAN/builds/20030 Original change's description: > [parser] Implements proposal-numeric-separator. > > https://github.com/tc39/proposal-numeric-separator > > This proposal-numeric-separator extends NumericLiteral and > allows developers to insert underscore(_) inside numeric literal. > > Bug: v8:7317 > Change-Id: I2a1a45cd6fe09cc5df63433bc915988fde687a33 > Reviewed-on: https://chromium-review.googlesource.com/923441 > Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> > Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> > Cr-Commit-Position: refs/heads/master@{#51671} TBR=adamk@chromium.org,jkummerow@chromium.org,hablich@chromium.org,gsathya@chromium.org,mathias@chromium.org,goto@google.com,brn@b6n.ch Change-Id: I6dcf46820caf20f28fbc11d94a5e8ced3cbbc78d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7317 Reviewed-on: https://chromium-review.googlesource.com/944767Reviewed-by:
Deepti Gandluri <gdeepti@chromium.org> Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/heads/master@{#51672}
-
Taketoshi Aono authored
https://github.com/tc39/proposal-numeric-separator This proposal-numeric-separator extends NumericLiteral and allows developers to insert underscore(_) inside numeric literal. Bug: v8:7317 Change-Id: I2a1a45cd6fe09cc5df63433bc915988fde687a33 Reviewed-on: https://chromium-review.googlesource.com/923441 Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#51671}
-
Brad Nelson authored
R=titzer@chromium.org Change-Id: I121ec495dbfea0f1800c8e12a1dffe5635cd2b6d Reviewed-on: https://chromium-review.googlesource.com/944252Reviewed-by:
Ben Titzer <titzer@chromium.org> Reviewed-by:
-
Caitlin Potter authored
Avoid generating ADDs when concatenating the empty string with other template parts. This prevents the creation of useless feedback slots, and reduces the number of extra dispatches. The impact on performance is negligible. BUG=v8:7415 Change-Id: I7ef3806b53f7252f3a86f7007ae7050ac697c1e3 Reviewed-on: https://chromium-review.googlesource.com/938145Reviewed-by:
-
Adam Klein authored
The memory gains were significant, so despite the bluebird-doxbee regression, we think it's better to have this patch than not. See the attached Chromium bug for more discussion. This is a reland of 20e346bd. Original change's description: > [parser] Remove pretenuring of closures assigned to properties > > This pretenuring was added in https://codereview.chromium.org/5220007, > back when it was necessary in order to allow use of the closure > as a "constant function" property. This should no longer be the case, > and the pretenuring causes some unfortunate downstream effects. > > This patch removes the parser's setting of this bit. If it doesn't > cause regressions on the perf bots, followup CLs will remove the > rest of the support for this feature. > > Bug: v8:7442 > Change-Id: I27c43dd4293ce5de921be6c78571e712778d138a > Reviewed-on: https://chromium-review.googlesource.com/914610 > Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> > Commit-Queue: Adam Klein <adamk@chromium.org> > Cr-Commit-Position: refs/heads/master@{#51254} Bug: v8:7442, chromium:814182 Change-Id: I228c59dccef3844803f115749e72ae6c5f286eda Reviewed-on: https://chromium-review.googlesource.com/938241Reviewed-by:
-
Brad Nelson authored
R=titzer@chromium.org Change-Id: Ib855271457ffd737abe7fa37ebf7a03a5bda9ee4 Reviewed-on: https://chromium-review.googlesource.com/940170Reviewed-by:
-
Jakob Kummerow authored
Bug: v8:6791, v8:7506 Change-Id: I8ff41cb5fab03ab2ced8f21016a0744582a3fcee Reviewed-on: https://chromium-review.googlesource.com/942387 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
-
Michael Starzinger authored
This makes sure that the object can be identified by a unique instance type and hence is not accidentally confused with other FixedArrays on the heap. R=clemensh@chromium.org BUG=v8:7509 Change-Id: I66e3d779ff9a323b64f5464bdd5fe02aefe468c6 Reviewed-on: https://chromium-review.googlesource.com/943442 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
-
Jakob Kummerow authored
Bug: v8:6791, v8:7486 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: I733d0fb886c42928816fe570712ed23f41c8e751 Reviewed-on: https://chromium-review.googlesource.com/938945Reviewed-by:
-
Igor Sheludko authored
This is a first step towards using Maps as store transition handlers. It is expected for this CL to noticeably regress memory consumption but most of it should be recovered by the next CL. Bug: v8:5988 Change-Id: Ic2e301f9ccebc36e699383ded8c8cd284a906ce1 Reviewed-on: https://chromium-review.googlesource.com/928646 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#51663}
-
Gabriel Charette authored
Follow-up to https://chromium-review.googlesource.com/c/v8/v8/+/941442. "background" refers to a priority and is inappropriate to refer to worker threads as many tasks posted to worker threads by v8 are in fact high priority. Also took advantage of this rename to make NumberOfWorkerThreads() return an int instead of size_t. While it is never negative, int is simpler and Google C++ style guide states to avoid unsigned integers in such cases (ref. "On Unsigned Integers" @ https://google.github.io/styleguide/cppguide.html#Integer_Types). The Chromium embedder for that call provided an int which was converted to size_t for this override and most often casted back down to int on the v8 side, adding churn, and readability overhead. R=ahaas@chromium.org Bug: v8:7310 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: Ib5280df73d2846b111d985be65a10b049995ea6a Reviewed-on: https://chromium-review.googlesource.com/941944 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
-
Igor Sheludko authored
Bug: chromium:808845 Change-Id: I406ca472e74b8fce5f79bc389bd40aec7dcebb84 Reviewed-on: https://chromium-review.googlesource.com/943261Reviewed-by:
-
Mathias Bynens authored
This patch removes the StringConstructor_ConstructStub builtin, merging its functionality into the refactored StringConstructor TurboFan builtin. This brings us closer to our goal of deprecating the `construct_stub` field in `SharedFunctionInfo`. Bug: v8:7503 Change-Id: Ie98520c652f49dda91eff2fc51263611f29e0ebe Reviewed-on: https://chromium-review.googlesource.com/942882 Commit-Queue: Mathias Bynens <mathias@chromium.org> Reviewed-by:
-
v8-autoroll authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/b1d6c28..df4bee0 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: Ic81a2974eb31627ae07630bcfad7346cdd7f1dd6 Reviewed-on: https://chromium-review.googlesource.com/936671Reviewed-by:
-
Junliang Yan authored
Port 66870070 Original Commit Message: Replace bitwise arithmetic with conditional move / select instructions on ia32, x64, Arm and Arm64. In local tests this improves --noopt Ignition performance by between 2-5%. R=rmcilroy@chromium.org, joransiu@ca.ibm.com, michael_dawson@ca.ibm.com BUG=chromium:798964 LOG=N Change-Id: I3cb65bdf2cf48df30e97b8a12966636fa6aca5ec Reviewed-on: https://chromium-review.googlesource.com/939852 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Joran Siu <joransiu@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#51658}
-
