• Georg Neis's avatar
    Reland "[parsing] inline ArrayLiteral creation for spread calls" · 82345e9f
    Georg Neis authored
    This reverts commit f48e7349.
    
    Reason for revert: innocent!!
    
    Original change's description:
    > Revert "[parsing] inline ArrayLiteral creation for spread calls"
    > 
    > This reverts commit 93fc3841.
    > 
    > Reason for revert: may break node.js integration
    > 
    > Original change's description:
    > > [parsing] inline ArrayLiteral creation for spread calls
    > > 
    > > Instead of using runtime calls to generate the Array Literal passed to
    > > %reflect_call / %reflect_construct, we create an ArrayLiteral from the
    > > list of arguments, and perform spreads using the interpreter mechanism for
    > > spreading in ArrayLiterals (thus, the spreading becomes inline). This
    > > array literal is still passed to %reflect_call / %reflect_construct as
    > > before.
    > > 
    > > This cuts the runtime for bench-spread-call.js -> testSpread roughly in
    > > half, and will likely improve further once
    > > https://chromium-review.googlesource.com/c/v8/v8/+/915364 has landed.
    > > 
    > > BUG=v8:7446
    > > R=​neis@chromium.org, adamk@chromium.org
    > > 
    > > Change-Id: I74a6acd3a60aad422e4ac575275c7b567659d8ad
    > > Reviewed-on: https://chromium-review.googlesource.com/939587
    > > Commit-Queue: Georg Neis <neis@chromium.org>
    > > Reviewed-by: Georg Neis <neis@chromium.org>
    > > Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
    > > Cr-Commit-Position: refs/heads/master@{#51678}
    > 
    > TBR=adamk@chromium.org,neis@chromium.org,caitp@igalia.com,bmeurer@chromium.org
    > 
    > Change-Id: I4730077591bce0e5e7b2ce7d59678e8b7135cc08
    > No-Presubmit: true
    > No-Tree-Checks: true
    > No-Try: true
    > Bug: v8:7446
    > Reviewed-on: https://chromium-review.googlesource.com/945769
    > Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
    > Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#51682}
    
    TBR=adamk@chromium.org,neis@chromium.org,sigurds@chromium.org,caitp@igalia.com,bmeurer@chromium.org
    
    Change-Id: I977513bea06a4f3fba03fa4a89270298475422e2
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: v8:7446
    Reviewed-on: https://chromium-review.googlesource.com/945808Reviewed-by: 's avatarGeorg Neis <neis@chromium.org>
    Commit-Queue: Georg Neis <neis@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#51686}
    82345e9f
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...