- 26 Oct, 2017 1 commit
-
-
Clemens Hammacher authored
This way, we can also check the return code of d8. We currently have a bug (6981) which makes failing tests not being detected, even though the failure message is (sometimes) being printed. After this refactoring, we can write tests for our mjsunit test functions. R=machenbach@chromium.org Bug: v8:6981 Change-Id: I0aa0abcb0f9a4f622a1e1d1a4d826da1e6eb4f07 Reviewed-on: https://chromium-review.googlesource.com/737991Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#48951}
-
- 17 Jul, 2017 1 commit
-
-
Sathya Gunasekaran authored
Previously, ➜ v8 (master)
./out.gn/x64.optdebug/d8 V8 version 6.1.0 (candidate) d8> var x = undefined undefined d8> var [a] = x (d8):1: TypeError: Cannot read property 'Symbol(Symbol.iterator)' of undefined var [a] = x ^ TypeError: Cannot read property 'Symbol(Symbol.iterator)' of undefined at (d8):1:11 Now, ➜ v8 (fix-iterator) ./out.gn/x64.optdebug/d8 V8 version 6.1.0 (candidate) d8> var x = undefined undefined d8> var [a] = x (d8):1: TypeError: x is not iterable var [a] = x ^ TypeError: x is not iterable at (d8):1:11 Bug: v8:6599, v8:6513 Change-Id: I71287a19166af0289e8f7708b8f41ad003ae87ae Reviewed-on: https://chromium-review.googlesource.com/571175 Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by:Adam Klein <adamk@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#46723}
-
- 06 Jul, 2017 1 commit
-
-
Sathya Gunasekaran authored
Print the object that is being destructured and update the error message. Previously, d8> var [a] = {} (d8):1: TypeError: [Symbol.iterator] is not a function Now, d8> var [a] = {} (d8):1: TypeError: {} is not iterable Bug: v8:6513, v8:5532 Change-Id: I5cbfe7c7e20632bce1a48bd38a1b0c98d0ff0660 Reviewed-on: https://chromium-review.googlesource.com/557370 Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by:
Adam Klein <adamk@chromium.org> Reviewed-by:
Caitlin Potter <caitp@igalia.com> Cr-Commit-Position: refs/heads/master@{#46457}
-
- 19 Jun, 2017 1 commit
-
-
Sathya Gunasekaran authored
This patch updates the error positition and the error msg. Previously, → ./out.gn/x64.release/d8 test.js test.js:1: TypeError: undefined is not a function var [a] = {}; ^ TypeError: undefined is not a function at test.js:1:1 With this patch, → ./out.gn/x64.release/d8 test.js test.js:1: TypeError: [Symbol.iterator] is not a function var [a] = {}; ^ TypeError: [Symbol.iterator] is not a function at test.js:1:11 Bug: v8:5532 Change-Id: Ib066e8ec8a53fdf06cce491bde4b1d0c6d564cbc Reviewed-on: https://chromium-review.googlesource.com/539024Reviewed-by:
Adam Klein <adamk@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#46015}
-