Skip to content

V
V8
Commit d8e1c484 authored by Sathya Gunasekaran's avatar Sathya Gunasekaran Committed by Commit Bot
Browse files
Options

[parser] Improve error message for destructuring non iterable 

Print the object that is being destructured and update the error 
message.

Previously,
  d8> var [a] = {}
  (d8):1: TypeError: [Symbol.iterator] is not a function

Now,
  d8> var [a] = {}
  (d8):1: TypeError: {} is not iterable

Bug: v8:6513, v8:5532
Change-Id: I5cbfe7c7e20632bce1a48bd38a1b0c98d0ff0660
Reviewed-on: https://chromium-review.googlesource.com/557370
Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org>
Reviewed-by: 's avatarAdam Klein <adamk@chromium.org>
Reviewed-by: 's avatarCaitlin Potter <caitp@igalia.com>
Cr-Commit-Position: refs/heads/master@{#46457}
parent aeb8f332
Hide whitespace changes
Inline Side-by-side
Showing with 137 additions and 44 deletions
src/ast/ast.h
View file @ d8e1c484
...@@ -2914,14 +2914,35 @@ class GetIterator final : public Expression { ...@@ -2914,14 +2914,35 @@ class GetIterator final : public Expression {
return async_iterator_call_feedback_slot_; return async_iterator_call_feedback_slot_;
} }
Expression* iterable_for_call_printer() const {
return destructured_iterable_ != nullptr ? destructured_iterable_
: iterable_;
}
private: private:
friend class AstNodeFactory; friend class AstNodeFactory;
explicit GetIterator(Expression* iterable, IteratorType hint, int pos) GetIterator(Expression* iterable, Expression* destructured_iterable,
: Expression(pos, kGetIterator), hint_(hint), iterable_(iterable) {} IteratorType hint, int pos)
: Expression(pos, kGetIterator),
hint_(hint),
iterable_(iterable),
destructured_iterable_(destructured_iterable) {}
GetIterator(Expression* iterable, IteratorType hint, int pos)
: Expression(pos, kGetIterator),
hint_(hint),
iterable_(iterable),
destructured_iterable_(nullptr) {}
IteratorType hint_; IteratorType hint_;
Expression* iterable_; Expression* iterable_;
// iterable_ is the variable proxy, while destructured_iterable_ points to
// the raw value stored in the variable proxy. This is only used for
// pretty printing error messages.
Expression* destructured_iterable_;
FeedbackSlot iterator_property_feedback_slot_; FeedbackSlot iterator_property_feedback_slot_;
FeedbackSlot iterator_call_feedback_slot_; FeedbackSlot iterator_call_feedback_slot_;
FeedbackSlot async_iterator_property_feedback_slot_; FeedbackSlot async_iterator_property_feedback_slot_;
...@@ -3522,6 +3543,12 @@ class AstNodeFactory final BASE_EMBEDDED { ...@@ -3522,6 +3543,12 @@ class AstNodeFactory final BASE_EMBEDDED {
return new (zone_) EmptyParentheses(pos); return new (zone_) EmptyParentheses(pos);
} }
GetIterator* NewGetIterator(Expression* iterable,
Expression* destructured_iterable,
IteratorType hint, int pos) {
return new (zone_) GetIterator(iterable, destructured_iterable, hint, pos);
}
GetIterator* NewGetIterator(Expression* iterable, IteratorType hint, GetIterator* NewGetIterator(Expression* iterable, IteratorType hint,
int pos) { int pos) {
return new (zone_) GetIterator(iterable, hint, pos); return new (zone_) GetIterator(iterable, hint, pos);
......
src/ast/prettyprinter.cc
View file @ d8e1c484
...@@ -22,10 +22,15 @@ CallPrinter::CallPrinter(Isolate* isolate, bool is_user_js) ...@@ -22,10 +22,15 @@ CallPrinter::CallPrinter(Isolate* isolate, bool is_user_js)
num_prints_ = 0; num_prints_ = 0;
found_ = false; found_ = false;
done_ = false; done_ = false;
iterator_hint_ = IteratorHint::kNone;
is_user_js_ = is_user_js; is_user_js_ = is_user_js;
InitializeAstVisitor(isolate); InitializeAstVisitor(isolate);
} }
CallPrinter::IteratorHint CallPrinter::GetIteratorHint() const {
return iterator_hint_;
}
Handle<String> CallPrinter::Print(FunctionLiteral* program, int position) { Handle<String> CallPrinter::Print(FunctionLiteral* program, int position) {
num_prints_ = 0; num_prints_ = 0;
position_ = position; position_ = position;
...@@ -223,9 +228,11 @@ void CallPrinter::VisitRegExpLiteral(RegExpLiteral* node) { ...@@ -223,9 +228,11 @@ void CallPrinter::VisitRegExpLiteral(RegExpLiteral* node) {
void CallPrinter::VisitObjectLiteral(ObjectLiteral* node) { void CallPrinter::VisitObjectLiteral(ObjectLiteral* node) {
Print("{");
for (int i = 0; i < node->properties()->length(); i++) { for (int i = 0; i < node->properties()->length(); i++) {
Find(node->properties()->at(i)->value()); Find(node->properties()->at(i)->value());
} }
Print("}");
} }
...@@ -372,17 +379,14 @@ void CallPrinter::VisitEmptyParentheses(EmptyParentheses* node) { ...@@ -372,17 +379,14 @@ void CallPrinter::VisitEmptyParentheses(EmptyParentheses* node) {
} }
void CallPrinter::VisitGetIterator(GetIterator* node) { void CallPrinter::VisitGetIterator(GetIterator* node) {
// Because CallPrinter is used by RenderCallSite() in runtime-internal.cc,
// and the GetIterator node results in a Call, either to a [@@iterator] or
// [@@asyncIterator]. It's unknown which call this error refers to, so we
// assume it's the first call.
bool was_found = !found_ && node->position() == position_; bool was_found = !found_ && node->position() == position_;
if (was_found) { if (was_found) {
found_ = true; found_ = true;
iterator_hint_ = node->hint() == IteratorType::kNormal
? IteratorHint::kNormal
: IteratorHint::kAsync;
} }
Find(node->iterable(), true); Find(node->iterable_for_call_printer(), true);
Print(node->hint() == IteratorType::kNormal ? "[Symbol.iterator]"
: "[Symbol.asyncIterator]");
if (was_found) done_ = true; if (was_found) done_ = true;
} }
......
src/ast/prettyprinter.h
View file @ d8e1c484
...@@ -20,6 +20,8 @@ class CallPrinter final : public AstVisitor<CallPrinter> { ...@@ -20,6 +20,8 @@ class CallPrinter final : public AstVisitor<CallPrinter> {
// The following routine prints the node with position |position| into a // The following routine prints the node with position |position| into a
// string. // string.
Handle<String> Print(FunctionLiteral* program, int position); Handle<String> Print(FunctionLiteral* program, int position);
enum IteratorHint { kNone, kNormal, kAsync };
IteratorHint GetIteratorHint() const;
// Individual nodes // Individual nodes
#define DECLARE_VISIT(type) void Visit##type(type* node); #define DECLARE_VISIT(type) void Visit##type(type* node);
...@@ -39,6 +41,7 @@ class CallPrinter final : public AstVisitor<CallPrinter> { ...@@ -39,6 +41,7 @@ class CallPrinter final : public AstVisitor<CallPrinter> {
bool found_; bool found_;
bool done_; bool done_;
bool is_user_js_; bool is_user_js_;
IteratorHint iterator_hint_;
DEFINE_AST_VISITOR_SUBCLASS_MEMBERS(); DEFINE_AST_VISITOR_SUBCLASS_MEMBERS();
......
src/messages.h
View file @ d8e1c484
...@@ -345,6 +345,7 @@ class ErrorUtils : public AllStatic { ...@@ -345,6 +345,7 @@ class ErrorUtils : public AllStatic {
T(NotDateObject, "this is not a Date object.") \ T(NotDateObject, "this is not a Date object.") \
T(NotGeneric, "% requires that 'this' be a %") \ T(NotGeneric, "% requires that 'this' be a %") \
T(NotIterable, "% is not iterable") \ T(NotIterable, "% is not iterable") \
T(NotAsyncIterable, "% is not async iterable") \
T(NotPropertyName, "% is not a valid property name") \ T(NotPropertyName, "% is not a valid property name") \
T(NotTypedArray, "this is not a typed array.") \ T(NotTypedArray, "this is not a typed array.") \
T(NotSuperConstructor, "Super constructor % of % is not a constructor") \ T(NotSuperConstructor, "Super constructor % of % is not a constructor") \
......
src/parsing/pattern-rewriter.cc
View file @ d8e1c484
...@@ -399,7 +399,7 @@ void Parser::PatternRewriter::VisitArrayLiteral(ArrayLiteral* node, ...@@ -399,7 +399,7 @@ void Parser::PatternRewriter::VisitArrayLiteral(ArrayLiteral* node,
auto temp = *temp_var = CreateTempVar(current_value_); auto temp = *temp_var = CreateTempVar(current_value_);
auto iterator = CreateTempVar(factory()->NewGetIterator( auto iterator = CreateTempVar(factory()->NewGetIterator(
factory()->NewVariableProxy(temp), IteratorType::kNormal, factory()->NewVariableProxy(temp), current_value_, IteratorType::kNormal,
current_value_->position())); current_value_->position()));
auto done = auto done =
CreateTempVar(factory()->NewBooleanLiteral(false, kNoSourcePosition)); CreateTempVar(factory()->NewBooleanLiteral(false, kNoSourcePosition));
......
src/runtime/runtime-internal.cc
View file @ d8e1c484
...@@ -392,13 +392,20 @@ bool ComputeLocation(Isolate* isolate, MessageLocation* target) { ...@@ -392,13 +392,20 @@ bool ComputeLocation(Isolate* isolate, MessageLocation* target) {
return false; return false;
} }
Handle<String> RenderCallSite(Isolate* isolate, Handle<Object> object) { Handle<String> RenderCallSite(Isolate* isolate, Handle<Object> object,
MessageTemplate::Template* id) {
MessageLocation location; MessageLocation location;
if (ComputeLocation(isolate, &location)) { if (ComputeLocation(isolate, &location)) {
ParseInfo info(location.shared()); ParseInfo info(location.shared());
if (parsing::ParseAny(&info, isolate)) { if (parsing::ParseAny(&info, isolate)) {
CallPrinter printer(isolate, location.shared()->IsUserJavaScript()); CallPrinter printer(isolate, location.shared()->IsUserJavaScript());
Handle<String> str = printer.Print(info.literal(), location.start_pos()); Handle<String> str = printer.Print(info.literal(), location.start_pos());
CallPrinter::IteratorHint type = printer.GetIteratorHint();
if (type == CallPrinter::IteratorHint::kNormal) {
*id = MessageTemplate::kNotIterable;
} else if (type == CallPrinter::IteratorHint::kAsync) {
*id = MessageTemplate::kNotAsyncIterable;
}
if (str->length() > 0) return str; if (str->length() > 0) return str;
} else { } else {
isolate->clear_pending_exception(); isolate->clear_pending_exception();
...@@ -413,9 +420,9 @@ RUNTIME_FUNCTION(Runtime_ThrowCalledNonCallable) { ...@@ -413,9 +420,9 @@ RUNTIME_FUNCTION(Runtime_ThrowCalledNonCallable) {
HandleScope scope(isolate); HandleScope scope(isolate);
DCHECK_EQ(1, args.length()); DCHECK_EQ(1, args.length());
CONVERT_ARG_HANDLE_CHECKED(Object, object, 0); CONVERT_ARG_HANDLE_CHECKED(Object, object, 0);
Handle<String> callsite = RenderCallSite(isolate, object); MessageTemplate::Template id = MessageTemplate::kCalledNonCallable;
THROW_NEW_ERROR_RETURN_FAILURE( Handle<String> callsite = RenderCallSite(isolate, object, &id);
isolate, NewTypeError(MessageTemplate::kCalledNonCallable, callsite)); THROW_NEW_ERROR_RETURN_FAILURE(isolate, NewTypeError(id, callsite));
} }
RUNTIME_FUNCTION(Runtime_ThrowCalledOnNullOrUndefined) { RUNTIME_FUNCTION(Runtime_ThrowCalledOnNullOrUndefined) {
...@@ -430,9 +437,9 @@ RUNTIME_FUNCTION(Runtime_ThrowConstructedNonConstructable) { ...@@ -430,9 +437,9 @@ RUNTIME_FUNCTION(Runtime_ThrowConstructedNonConstructable) {
HandleScope scope(isolate); HandleScope scope(isolate);
DCHECK_EQ(1, args.length()); DCHECK_EQ(1, args.length());
CONVERT_ARG_HANDLE_CHECKED(Object, object, 0); CONVERT_ARG_HANDLE_CHECKED(Object, object, 0);
Handle<String> callsite = RenderCallSite(isolate, object); MessageTemplate::Template id = MessageTemplate::kNotConstructor;
THROW_NEW_ERROR_RETURN_FAILURE( Handle<String> callsite = RenderCallSite(isolate, object, &id);
isolate, NewTypeError(MessageTemplate::kNotConstructor, callsite)); THROW_NEW_ERROR_RETURN_FAILURE(isolate, NewTypeError(id, callsite));
} }
RUNTIME_FUNCTION(Runtime_ThrowConstructorReturnedNonObject) { RUNTIME_FUNCTION(Runtime_ThrowConstructorReturnedNonObject) {
......
test/cctest/interpreter/bytecode_expectations/AsyncGenerators.golden
View file @ d8e1c484
...@@ -427,7 +427,7 @@ bytecodes: [ ...@@ -427,7 +427,7 @@ bytecodes: [
B(TestTypeOf), U8(5), B(TestTypeOf), U8(5),
B(JumpIfFalse), U8(4), B(JumpIfFalse), U8(4),
B(Jump), U8(18), B(Jump), U8(18),
B(Wide), B(LdaSmi), I16(131), B(Wide), B(LdaSmi), I16(132),
B(Star), R(19), B(Star), R(19),
B(LdaConstant), U8(15), B(LdaConstant), U8(15),
B(Star), R(20), B(Star), R(20),
...@@ -742,7 +742,7 @@ bytecodes: [ ...@@ -742,7 +742,7 @@ bytecodes: [
B(TestTypeOf), U8(5), B(TestTypeOf), U8(5),
B(JumpIfFalse), U8(4), B(JumpIfFalse), U8(4),
B(Jump), U8(18), B(Jump), U8(18),
B(Wide), B(LdaSmi), I16(131), B(Wide), B(LdaSmi), I16(132),
B(Star), R(17), B(Star), R(17),
B(LdaConstant), U8(25), B(LdaConstant), U8(25),
B(Star), R(18), B(Star), R(18),
...@@ -818,7 +818,7 @@ bytecodes: [ ...@@ -818,7 +818,7 @@ bytecodes: [
B(JumpIfToBooleanFalse), U8(4), B(JumpIfToBooleanFalse), U8(4),
B(Jump), U8(7), B(Jump), U8(7),
B(CallRuntime), U16(Runtime::kThrowIteratorResultNotAnObject), R(8), U8(1), B(CallRuntime), U16(Runtime::kThrowIteratorResultNotAnObject), R(8), U8(1),
B(Wide), B(LdaSmi), I16(145), B(Wide), B(LdaSmi), I16(146),
B(Star), R(17), B(Star), R(17),
B(LdaConstant), U8(25), B(LdaConstant), U8(25),
B(Star), R(18), B(Star), R(18),
......
test/cctest/interpreter/bytecode_expectations/ForAwaitOf.golden
View file @ d8e1c484
...@@ -156,7 +156,7 @@ bytecodes: [ ...@@ -156,7 +156,7 @@ bytecodes: [
B(TestTypeOf), U8(5), B(TestTypeOf), U8(5),
B(JumpIfFalse), U8(4), B(JumpIfFalse), U8(4),
B(Jump), U8(18), B(Jump), U8(18),
B(Wide), B(LdaSmi), I16(131), B(Wide), B(LdaSmi), I16(132),
B(Star), R(20), B(Star), R(20),
B(LdaConstant), U8(15), B(LdaConstant), U8(15),
B(Star), R(21), B(Star), R(21),
...@@ -488,7 +488,7 @@ bytecodes: [ ...@@ -488,7 +488,7 @@ bytecodes: [
B(TestTypeOf), U8(5), B(TestTypeOf), U8(5),
B(JumpIfFalse), U8(4), B(JumpIfFalse), U8(4),
B(Jump), U8(18), B(Jump), U8(18),
B(Wide), B(LdaSmi), I16(131), B(Wide), B(LdaSmi), I16(132),
B(Star), R(20), B(Star), R(20),
B(LdaConstant), U8(15), B(LdaConstant), U8(15),
B(Star), R(21), B(Star), R(21),
...@@ -843,7 +843,7 @@ bytecodes: [ ...@@ -843,7 +843,7 @@ bytecodes: [
B(TestTypeOf), U8(5), B(TestTypeOf), U8(5),
B(JumpIfFalse), U8(4), B(JumpIfFalse), U8(4),
B(Jump), U8(18), B(Jump), U8(18),
B(Wide), B(LdaSmi), I16(131), B(Wide), B(LdaSmi), I16(132),
B(Star), R(20), B(Star), R(20),
B(LdaConstant), U8(15), B(LdaConstant), U8(15),
B(Star), R(21), B(Star), R(21),
...@@ -1123,7 +1123,7 @@ bytecodes: [ ...@@ -1123,7 +1123,7 @@ bytecodes: [
B(TestTypeOf), U8(5), B(TestTypeOf), U8(5),
B(JumpIfFalse), U8(4), B(JumpIfFalse), U8(4),
B(Jump), U8(18), B(Jump), U8(18),
B(Wide), B(LdaSmi), I16(131), B(Wide), B(LdaSmi), I16(132),
B(Star), R(16), B(Star), R(16),
B(LdaConstant), U8(10), B(LdaConstant), U8(10),
B(Star), R(17), B(Star), R(17),
......
test/cctest/interpreter/bytecode_expectations/ForOf.golden
View file @ d8e1c484
...@@ -85,7 +85,7 @@ bytecodes: [ ...@@ -85,7 +85,7 @@ bytecodes: [
B(TestTypeOf), U8(5), B(TestTypeOf), U8(5),
B(JumpIfFalse), U8(4), B(JumpIfFalse), U8(4),
B(Jump), U8(18), B(Jump), U8(18),
B(Wide), B(LdaSmi), I16(131), B(Wide), B(LdaSmi), I16(132),
B(Star), R(11), B(Star), R(11),
B(LdaConstant), U8(8), B(LdaConstant), U8(8),
B(Star), R(12), B(Star), R(12),
...@@ -225,7 +225,7 @@ bytecodes: [ ...@@ -225,7 +225,7 @@ bytecodes: [
B(TestTypeOf), U8(5), B(TestTypeOf), U8(5),
B(JumpIfFalse), U8(4), B(JumpIfFalse), U8(4),
B(Jump), U8(18), B(Jump), U8(18),
B(Wide), B(LdaSmi), I16(131), B(Wide), B(LdaSmi), I16(132),
B(Star), R(12), B(Star), R(12),
B(LdaConstant), U8(8), B(LdaConstant), U8(8),
B(Star), R(13), B(Star), R(13),
...@@ -377,7 +377,7 @@ bytecodes: [ ...@@ -377,7 +377,7 @@ bytecodes: [
B(TestTypeOf), U8(5), B(TestTypeOf), U8(5),
B(JumpIfFalse), U8(4), B(JumpIfFalse), U8(4),
B(Jump), U8(18), B(Jump), U8(18),
B(Wide), B(LdaSmi), I16(131), B(Wide), B(LdaSmi), I16(132),
B(Star), R(11), B(Star), R(11),
B(LdaConstant), U8(8), B(LdaConstant), U8(8),
B(Star), R(12), B(Star), R(12),
...@@ -520,7 +520,7 @@ bytecodes: [ ...@@ -520,7 +520,7 @@ bytecodes: [
B(TestTypeOf), U8(5), B(TestTypeOf), U8(5),
B(JumpIfFalse), U8(4), B(JumpIfFalse), U8(4),
B(Jump), U8(18), B(Jump), U8(18),
B(Wide), B(LdaSmi), I16(131), B(Wide), B(LdaSmi), I16(132),
B(Star), R(10), B(Star), R(10),
B(LdaConstant), U8(10), B(LdaConstant), U8(10),
B(Star), R(11), B(Star), R(11),
......
test/cctest/interpreter/bytecode_expectations/ForOfLoop.golden
View file @ d8e1c484
...@@ -89,7 +89,7 @@ bytecodes: [ ...@@ -89,7 +89,7 @@ bytecodes: [
B(TestTypeOf), U8(5), B(TestTypeOf), U8(5),
B(JumpIfFalse), U8(4), B(JumpIfFalse), U8(4),
B(Jump), U8(18), B(Jump), U8(18),
B(Wide), B(LdaSmi), I16(131), B(Wide), B(LdaSmi), I16(132),
B(Star), R(13), B(Star), R(13),
B(LdaConstant), U8(7), B(LdaConstant), U8(7),
B(Star), R(14), B(Star), R(14),
...@@ -266,7 +266,7 @@ bytecodes: [ ...@@ -266,7 +266,7 @@ bytecodes: [
B(TestTypeOf), U8(5), B(TestTypeOf), U8(5),
B(JumpIfFalse), U8(4), B(JumpIfFalse), U8(4),
B(Jump), U8(18), B(Jump), U8(18),
B(Wide), B(LdaSmi), I16(131), B(Wide), B(LdaSmi), I16(132),
B(Star), R(12), B(Star), R(12),
B(LdaConstant), U8(11), B(LdaConstant), U8(11),
B(Star), R(13), B(Star), R(13),
...@@ -419,7 +419,7 @@ bytecodes: [ ...@@ -419,7 +419,7 @@ bytecodes: [
B(TestTypeOf), U8(5), B(TestTypeOf), U8(5),
B(JumpIfFalse), U8(4), B(JumpIfFalse), U8(4),
B(Jump), U8(18), B(Jump), U8(18),
B(Wide), B(LdaSmi), I16(131), B(Wide), B(LdaSmi), I16(132),
B(Star), R(11), B(Star), R(11),
B(LdaConstant), U8(9), B(LdaConstant), U8(9),
B(Star), R(12), B(Star), R(12),
...@@ -576,7 +576,7 @@ bytecodes: [ ...@@ -576,7 +576,7 @@ bytecodes: [
B(TestTypeOf), U8(5), B(TestTypeOf), U8(5),
B(JumpIfFalse), U8(4), B(JumpIfFalse), U8(4),
B(Jump), U8(18), B(Jump), U8(18),
B(Wide), B(LdaSmi), I16(131), B(Wide), B(LdaSmi), I16(132),
B(Star), R(16), B(Star), R(16),
B(LdaConstant), U8(9), B(LdaConstant), U8(9),
B(Star), R(17), B(Star), R(17),
...@@ -756,7 +756,7 @@ bytecodes: [ ...@@ -756,7 +756,7 @@ bytecodes: [
B(TestTypeOf), U8(5), B(TestTypeOf), U8(5),
B(JumpIfFalse), U8(4), B(JumpIfFalse), U8(4),
B(Jump), U8(18), B(Jump), U8(18),
B(Wide), B(LdaSmi), I16(131), B(Wide), B(LdaSmi), I16(132),
B(Star), R(17), B(Star), R(17),
B(LdaConstant), U8(10), B(LdaConstant), U8(10),
B(Star), R(18), B(Star), R(18),
...@@ -965,7 +965,7 @@ bytecodes: [ ...@@ -965,7 +965,7 @@ bytecodes: [
B(TestTypeOf), U8(5), B(TestTypeOf), U8(5),
B(JumpIfFalse), U8(4), B(JumpIfFalse), U8(4),
B(Jump), U8(18), B(Jump), U8(18),
B(Wide), B(LdaSmi), I16(131), B(Wide), B(LdaSmi), I16(132),
B(Star), R(16), B(Star), R(16),
B(LdaConstant), U8(14), B(LdaConstant), U8(14),
B(Star), R(17), B(Star), R(17),
...@@ -1129,7 +1129,7 @@ bytecodes: [ ...@@ -1129,7 +1129,7 @@ bytecodes: [
B(TestTypeOf), U8(5), B(TestTypeOf), U8(5),
B(JumpIfFalse), U8(4), B(JumpIfFalse), U8(4),
B(Jump), U8(18), B(Jump), U8(18),
B(Wide), B(LdaSmi), I16(131), B(Wide), B(LdaSmi), I16(132),
B(Star), R(20), B(Star), R(20),
B(LdaConstant), U8(7), B(LdaConstant), U8(7),
B(Star), R(21), B(Star), R(21),
...@@ -1390,7 +1390,7 @@ bytecodes: [ ...@@ -1390,7 +1390,7 @@ bytecodes: [
B(TestTypeOf), U8(5), B(TestTypeOf), U8(5),
B(JumpIfFalse), U8(4), B(JumpIfFalse), U8(4),
B(Jump), U8(18), B(Jump), U8(18),
B(Wide), B(LdaSmi), I16(131), B(Wide), B(LdaSmi), I16(132),
B(Star), R(21), B(Star), R(21),
B(LdaConstant), U8(11), B(LdaConstant), U8(11),
B(Star), R(22), B(Star), R(22),
......
test/cctest/interpreter/bytecode_expectations/Generators.golden
View file @ d8e1c484
...@@ -283,7 +283,7 @@ bytecodes: [ ...@@ -283,7 +283,7 @@ bytecodes: [
B(TestTypeOf), U8(5), B(TestTypeOf), U8(5),
B(JumpIfFalse), U8(4), B(JumpIfFalse), U8(4),
B(Jump), U8(18), B(Jump), U8(18),
B(Wide), B(LdaSmi), I16(131), B(Wide), B(LdaSmi), I16(132),
B(Star), R(15), B(Star), R(15),
B(LdaConstant), U8(15), B(LdaConstant), U8(15),
B(Star), R(16), B(Star), R(16),
......
test/message/destructuring-array-non-iterable-number.out
View file @ d8e1c484
*%(basename)s:5: TypeError: [Symbol.iterator] is not a function *%(basename)s:5: TypeError: 1 is not iterable
var [a] = 1; var [a] = 1;
^ ^
TypeError: [Symbol.iterator] is not a function TypeError: 1 is not iterable
at *%(basename)s:5:11 at *%(basename)s:5:11
test/message/destructuring-array-non-iterable-object-literal-complex.js 0 → 100644
View file @ d8e1c484
// Copyright 2017 the V8 project authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
var [a] = {['a']: {b: 1}};
test/message/destructuring-array-non-iterable-object-literal-complex.out 0 → 100644
View file @ d8e1c484
*%(basename)s:5: TypeError: {(intermediate value)} is not iterable
var [a] = {['a']: {b: 1}};
^
TypeError: {(intermediate value)} is not iterable
at *%(basename)s:5:11
test/message/destructuring-array-non-iterable-object-literal.js 0 → 100644
View file @ d8e1c484
// Copyright 2017 the V8 project authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
var [a] = {a: 1};
test/message/destructuring-array-non-iterable-object-literal.out 0 → 100644
View file @ d8e1c484
*%(basename)s:5: TypeError: {(intermediate value)} is not iterable
var [a] = {a: 1};
^
TypeError: {(intermediate value)} is not iterable
at *%(basename)s:5:11
test/message/destructuring-array-non-iterable-object.out
View file @ d8e1c484
*%(basename)s:6: TypeError: [Symbol.iterator] is not a function *%(basename)s:6: TypeError: x is not iterable
var [a] = x; var [a] = x;
^ ^
TypeError: [Symbol.iterator] is not a function TypeError: x is not iterable
at *%(basename)s:6:11 at *%(basename)s:6:11
test/message/for-of-non-iterable.js 0 → 100644
View file @ d8e1c484
// Copyright 2017 the V8 project authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
for ([a] of {}) {}
test/message/for-of-non-iterable.out 0 → 100644
View file @ d8e1c484
*%(basename)s:5: TypeError: {} is not iterable
for ([a] of {}) {}
^
TypeError: {} is not iterable
at *%(basename)s:5:13
test/message/get-iterator1.out
View file @ d8e1c484
*%(basename)s:7: TypeError: nonIterable(...)[Symbol.iterator] is not a function *%(basename)s:7: TypeError: nonIterable(...) is not iterable
[...nonIterable()]; [...nonIterable()];
^ ^
TypeError: nonIterable(...)[Symbol.iterator] is not a function TypeError: nonIterable(...) is not iterable
at *%(basename)s:7:5 at *%(basename)s:7:5
test/mjsunit/harmony/async-for-of-non-iterable.js 0 → 100644
View file @ d8e1c484
// Copyright 2017 the V8 project authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
// Flags: --harmony-async-iteration
var done = false;
async function f() {
try {
for await ([a] of {}) {
UNREACHABLE();
}
UNREACHABLE();
} catch (e) {
assertEquals(e.message, "{} is not async iterable");
done = true;
}
}
f();
assertTrue(done);
test/webkit/exception-for-nonobject-expected.txt
View file @ d8e1c484
...@@ -26,7 +26,7 @@ Test for correct handling of exceptions from instanceof and 'new' expressions ...@@ -26,7 +26,7 @@ Test for correct handling of exceptions from instanceof and 'new' expressions
On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
PASS new {}.undefined threw exception TypeError: (intermediate value).undefined is not a constructor. PASS new {}.undefined threw exception TypeError: {}.undefined is not a constructor.
PASS 1 instanceof {}.undefined threw exception TypeError: Right-hand side of 'instanceof' is not an object. PASS 1 instanceof {}.undefined threw exception TypeError: Right-hand side of 'instanceof' is not an object.
PASS successfullyParsed is true PASS successfullyParsed is true
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment