Skip to content

V
V8
Switch branch/tag
  1. 13 Sep, 2017 1 commit
  3. 12 Sep, 2017 1 commit
  5. 07 Sep, 2017 1 commit
  7. 31 Aug, 2017 1 commit
  9. 30 Aug, 2017 1 commit
  11. 28 Aug, 2017 1 commit
  13. 17 Aug, 2017 1 commit
    • Leszek Swirski's avatar
      [turbofan] Never generate loop exit phis for the accumulator · 1a302730
      Leszek Swirski authored 
      The accumulator should never be alive when jumping back to a loop
header, or jumping out of a loop. This means that as far as far as
TurboFan is concerned, we never need to create Phis or LoopExitValues
for the accumulator, as its value should not escape the loop.

For safety, this also augments the IsLivenessValid DCHECK in the
liveness analysis to check that the accumulator is not live in these
cases, and amends the bytecode analysis tests to kill the accumulator
where necessary to ensure this.

As a drive-by, added some comments to the more complex bytecode analysis
tests, since figuring out what they were for and how to fix them took a
non-trivial amount of time.

Change-Id: Idecf76a36681d724134c59768650c23cc6b0e9ef
Reviewed-on: https://chromium-review.googlesource.com/615168
Commit-Queue: Jaroslav Sevcik <jarin@chromium.org>
Reviewed-by: 's avatarRoss McIlroy <rmcilroy@chromium.org>
Reviewed-by: 's avatarJaroslav Sevcik <jarin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#47388}
      1a302730
  15. 11 Aug, 2017 1 commit
  17. 10 Aug, 2017 1 commit
  19. 08 Aug, 2017 1 commit
  21. 07 Aug, 2017 1 commit
  23. 03 Aug, 2017 3 commits
  25. 31 Jul, 2017 1 commit
  27. 28 Jul, 2017 4 commits
  29. 19 Jul, 2017 1 commit
  31. 14 Jul, 2017 2 commits
  33. 13 Jul, 2017 1 commit
  35. 12 Jul, 2017 1 commit
  37. 11 Jul, 2017 1 commit
    • Alexandre Talon's avatar
      [Turbofan] Enable reducers to report their name to make reducer tracing clearer · 7a75da34
      Alexandre Talon authored 
      Each reducer now has a virtual reducer_name function, returning its name
(the name of the class containing this reducer). This gets displayed when
using the --trace_turbo_reduction flag. Also when using this flags more
messages are displayed.

Actually when a node is replaced in-place (which is called an update
of the node), other reducers can still update it right after the
in-place replacement. When a node is really replaced (not in-place),
then we stop trying to apply reducers to it before we propagate the
reduction through the relevant nodes.

Before a message got printed only for the last reduction it went
through. So in case a node was reduced in-place several times
in a row, only the last update was printed, or none at all if after
being reduced in-place it got reduced by being replaced by another
node: only the non-in-place replacement was showed. 

Now each time an in-place reduction is applied to a node, a message
gets printed.

Bug: 
Change-Id: Id0f816fecd44c01d0253966c6decc4861be0c2fa
Reviewed-on: https://chromium-review.googlesource.com/563365Reviewed-by: 's avatarMichael Starzinger <mstarzinger@chromium.org>
Reviewed-by: 's avatarRoss McIlroy <rmcilroy@chromium.org>
Commit-Queue: Alexandre Talon <alexandret@google.com>
Cr-Commit-Position: refs/heads/master@{#46552}
      7a75da34
  39. 03 Jul, 2017 1 commit
  41. 30 Jun, 2017 1 commit
  43. 27 Jun, 2017 1 commit
  45. 14 Jun, 2017 1 commit
  47. 13 Jun, 2017 1 commit
  49. 07 Jun, 2017 1 commit
  51. 31 May, 2017 1 commit
  53. 29 May, 2017 1 commit
  55. 24 May, 2017 1 commit
  57. 22 May, 2017 1 commit
  59. 16 May, 2017 1 commit
  61. 15 May, 2017 1 commit
  63. 12 May, 2017 1 commit
  65. 08 May, 2017 1 commit
  67. 13 Apr, 2017 1 commit
    • bmeurer's avatar
      [turbofan] Let ChangeFloat64ToTagged canonicalize to Smi if possible. · 385734bf
      bmeurer authored 
      When the incoming value to ChangeFloat64ToTagged is in Smi range, we
represent it as Smi instead of a HeapNumber. This addresses a range of
problems where TurboFan unnecessarily deoptimizes because an operation
learned Smi feedback in Ignition, but was then confronted with a tagged
HeapNumber in TurboFan, just because the value was also represented as
unboxed double somewhere in the meantime.

BUG=v8:6256
R=yangguo@chromium.org

Review-Url: https://codereview.chromium.org/2815283002
Cr-Commit-Position: refs/heads/master@{#44631}
      385734bf