- 23 Jun, 2017 1 commit
-
-
Michael Starzinger authored
This removes the --turbo flag and solely relies on the filter pattern provided via --turbo-filter when deciding whether to use TurboFan. Note that disabling optimization wholesale can still be done with --no-opt, which should be used in favor of --no-turbo everywhere. Also note that this contains semantic changes to the TurboFan activation criteria. We respect the filter pattern more stringently and no longer activate TurboFan just because the source contains patterns forcing use of Ignition via {AstNumberingVisitor::DisableFullCodegenAndCrankshaft}. R=rmcilroy@chromium.org BUG=v8:6408 Change-Id: I0c855f6a62350eb62283a3431c8cc1baa750950e Reviewed-on: https://chromium-review.googlesource.com/528121Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Reviewed-by:
Michael Stanton <mvstanton@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#46167}
-
- 20 Jun, 2017 1 commit
-
-
Loo Rong Jie authored
Python List Comprehension does not need join() (alias of os.path.join). Change-Id: I9d5a8610d88c35fd4e3cb101bc10b25c3d1dd7cf Reviewed-on: https://chromium-review.googlesource.com/538453Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Loo Rong Jie <loorongjie@gmail.com> Cr-Commit-Position: refs/heads/master@{#46027}
-
- 02 May, 2017 1 commit
-
-
Jochen Eisinger authored
R=machenbach@chromium.org NOTRY=true NOTREECHECKS=true Bug: Change-Id: Ib6d3768a9e0cfb9ea5fdcece25325e8d498520af Reviewed-on: https://chromium-review.googlesource.com/493288Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#45028}
-
- 28 Apr, 2017 1 commit
-
-
Mythri authored
1. Replaces --crankshaft with --opt in tests. 2. Also fixes presubmit to check for --opt flag when assertOptimized is used. 3. Updates testrunner/local/variants.py and v8_foozie.py to use --opt flag. This would mean, nooptimize variant means there are no optimizations. Not even with %OptimizeFunctionOnNextCall. Bug:v8:6325 Change-Id: I638e743d0773a6729c6b9749e2ca1e2537f12ce6 Reviewed-on: https://chromium-review.googlesource.com/490206 Commit-Queue: Mythri Alle <mythria@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#44985}
-
- 13 Apr, 2017 1 commit
-
-
machenbach authored
TBR=martyn.capewell@arm.com NOTRY=true Review-Url: https://codereview.chromium.org/2818563005 Cr-Commit-Position: refs/heads/master@{#44654}
-
- 15 Mar, 2017 1 commit
-
-
Michael Achenbach authored
This adds one of the release unittests to presubmit. Different entry points for CI and CQ are required. More tests will follow in subsequent CLs. BUG=chromium:701296 NOTRY=true Change-Id: Ie96fba873f77df14efb1dc54388f075c056b64a6 Reviewed-on: https://chromium-review.googlesource.com/454639Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#43831}
-
- 23 Feb, 2017 1 commit
-
-
bradnelson authored
Adding a full run of checkdeps to tools/presubmit.py so that we keep checkdeps green. PRESUBMIT.py checks only incremental changes. Temporarily disabling a check rule that's broker in the inspector, pending owners fix. BUG= R=machenbach@chromium.org,dgozman@chromium.org,eholk@chromium.org Review-Url: https://codereview.chromium.org/2705333005 Cr-Commit-Position: refs/heads/master@{#43397}
-
- 17 Feb, 2017 1 commit
-
-
Michael Achenbach authored
Before this change, presubmit on upload/commit would miss checking status files when e.g. test files were deleted. But the status file check in CI will enforce that all referenced test files exist. NOTRY=true Change-Id: I6069563a0a4e98406977dbce2ae44b299f7cd4b0 Reviewed-on: https://chromium-review.googlesource.com/443467Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#43270}
-
- 26 Jan, 2017 1 commit
-
-
ishell authored
This CL adds --crankshaft and --no-always-opt flags to the tests that use assertOptimized() and assertUnoptimized() respectively. This CL also adds presubmit checks that ensure that tests have the proper flags set. BUG=v8:5890 Review-Url: https://codereview.chromium.org/2653753007 Cr-Commit-Position: refs/heads/master@{#42709}
-
- 09 Jan, 2017 1 commit
-
-
machenbach authored
This makes sure the metadata is found during minimization. Also renames the test files to fit the naming pattern. BUG=chromium:673246 NOTRY=true TBR=tandrii@chromium.org,mbarbella@chromium.org Review-Url: https://codereview.chromium.org/2622653002 Cr-Commit-Position: refs/heads/master@{#42150}
-
- 07 Jan, 2017 1 commit
-
-
littledan authored
This patch provides improved infrastructure for developing test262 tests together with V8. It has three parts: - The test262 test runner is updated to look for local versions of tests in the /test/test262/local-tests directory, which mirrors /test/test262/data. Additional tests can be added there and are run together with tests from upstream. Upstream tests can be locally updated by using the same name in local-tests; if a same-named test exists, then only the local version will be run. The local-tests directory is in the V8 repository, unlike the contents of the data directory, so tests can be added in the same patch as something else. - The tool /test/test262/upstream-local-tests.sh is added to create a patch against the test262 respository based on a patch which changes the local-tests directory. - The tool /test/test262/prune-local-tests.sh is added to remove redundant local tests on a test262 roll. See design doc: https://docs.google.com/document/d/16bj7AIDgZLv4WOsUEzQ5NzcEN9_xo095e88Pz8FC5rA/edit Review-Url: https://codereview.chromium.org/2611793002 Cr-Commit-Position: refs/heads/master@{#42117}
-
- 28 Dec, 2016 2 commits
-
-
machenbach authored
TBR=mstarzinger@chromium.org,bmeurer@chromium.org NOTRY=true Review-Url: https://codereview.chromium.org/2605113002 Cr-Commit-Position: refs/heads/master@{#41983}
-
epertoso authored
BUG= Review-Url: https://codereview.chromium.org/2601043002 Cr-Commit-Position: refs/heads/master@{#41969}
-
- 20 Dec, 2016 1 commit
-
-
machenbach authored
BUG=chromium:673246 NOTRY=true Review-Url: https://codereview.chromium.org/2589683003 Cr-Commit-Position: refs/heads/master@{#41844}
-
- 06 Dec, 2016 2 commits
-
-
machenbach authored
This turns the status files check into a source processor similar to lint and copyright check. On upload and on trybots it will only run on the affected files. BUG=v8:5603 NOTRY=true Review-Url: https://codereview.chromium.org/2553633002 Cr-Commit-Position: refs/heads/master@{#41516}
-
machenbach authored
Move a method that is not referenced in tools/presubmit.py. BUG=v8:5603 NOTRY=true Review-Url: https://codereview.chromium.org/2553623002 Cr-Commit-Position: refs/heads/master@{#41513}
-
- 28 Nov, 2016 1 commit
-
-
machenbach authored
BUG=v8:5603 NOTRY=true Review-Url: https://codereview.chromium.org/2534813002 Cr-Commit-Position: refs/heads/master@{#41297}
-
- 25 Nov, 2016 1 commit
-
-
yangguo authored
TBR=machenbach@chromium.org Review-Url: https://codereview.chromium.org/2533583002 Cr-Commit-Position: refs/heads/master@{#41286}
-
- 24 Nov, 2016 1 commit
-
-
machenbach authored
Presubmit on upload and on trybot will use the affected files as determined by the presubmit input_api. The continuously run presubmit will use the old method and search all files. BUG=v8:5603 NOTRY=true Review-Url: https://codereview.chromium.org/2523993003 Cr-Commit-Position: refs/heads/master@{#41248}
-
- 14 Nov, 2016 1 commit
-
-
yangguo authored
Changes include: - Adding V8_EXPORT macro for SnapshotCreator - Removing outdated DCHECKs. - Allow nullptr as external reference. This required a... - Refactoring of hashmaps used by the serializer. - Remove external references for counters. These are not used anywhere for isolates that are being serialized. - Put template infos into the partial snapshot cache. - Remove unnecessary presubmit check for external references. mksnapshot crashes if external references are missing. R=jochen@chromium.org, vogelheim@chromium.org BUG=chromium:617892 Review-Url: https://codereview.chromium.org/2490783004 Cr-Commit-Position: refs/heads/master@{#40949}
-
- 30 Sep, 2016 2 commits
-
-
kozyatinskiy authored
- added a inspector folder, - added related GN and gyp files, - added task handling infrastructure for test runner. BUG=chromium:635948 R=dgozman@chromium.org,alph@chromium.org Committed: https://crrev.com/dc1c71c0dc8a5c4ade4aa291f2ddcd02e90c64b2 Review-Url: https://codereview.chromium.org/2361623006 Cr-Original-Commit-Position: refs/heads/master@{#39866} Cr-Commit-Position: refs/heads/master@{#39918}
-
machenbach authored
Revert "[inspector] added inspector test runner [part 1]" This reverts commit dc1c71c0. Revert "[inspector] added inspector test runner [part 2]" This reverts commit cceaa122. Blocks the roll: https://codereview.chromium.org/2379053003/ In particular android debug: https://build.chromium.org/p/tryserver.chromium.android/builders/android_clang_dbg_recipe/builds/137605 BUG=chromium:635948 TBR=kozyatinskiy@chromium.org, NOTRY=true Review-Url: https://codereview.chromium.org/2387603002 Cr-Commit-Position: refs/heads/master@{#39909}
-
- 29 Sep, 2016 2 commits
-
-
kozyatinskiy authored
- added a inspector folder, - added related GN and gyp files, - added task handling infrastructure for test runner. BUG=chromium:635948 R=dgozman@chromium.org,alph@chromium.org Review-Url: https://codereview.chromium.org/2361623006 Cr-Commit-Position: refs/heads/master@{#39866}
-
kozyatinskiy authored
BUG=chromium:635948 R=dgozman@chromium.org,alph@chromium.org Review-Url: https://codereview.chromium.org/2354263003 Cr-Commit-Position: refs/heads/master@{#39846}
-
- 26 Sep, 2016 1 commit
-
-
kozyatinskiy authored
BUG=chromium:635948 R=dgozman@chromium.org,alph@chromium.org Review-Url: https://codereview.chromium.org/2343733002 Cr-Commit-Position: refs/heads/master@{#39727}
-
- 21 Sep, 2016 1 commit
-
-
kozyatinskiy authored
BUG=chromium:635948 R=dgozman@chromium.org,alph@chromium.org TBR=machenbach@chromium.org Review-Url: https://codereview.chromium.org/2338413003 Cr-Commit-Position: refs/heads/master@{#39608}
-
- 01 Sep, 2016 1 commit
-
-
dgozman authored
Attempt #2, formatted and disabled lint for src/inspector. BUG=chromium:635948 NOPRESUBMIT=true (for grammar check in license code) Review-Url: https://codereview.chromium.org/2292573002 Cr-Commit-Position: refs/heads/master@{#39107}
-
- 31 Aug, 2016 2 commits
-
-
machenbach authored
Revert of [inspector] Initial import of v8_inspector. (patchset #3 id:40001 of https://codereview.chromium.org/2292573002/ ) Reason for revert: Presubmit Original issue's description: > [inspector] Initial import of v8_inspector. > > BUG=chromium:635948 > NOPRESUBMIT=true (for code style) > > Committed: https://crrev.com/e29594ea3c5c41de0844e71f7a82c990a8da71ee > Cr-Commit-Position: refs/heads/master@{#39057} TBR=jochen@chromium.org,pfeldman@chromium.org,dgozman@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:635948 Review-Url: https://codereview.chromium.org/2300823002 Cr-Commit-Position: refs/heads/master@{#39058}
-
dgozman authored
BUG=chromium:635948 NOPRESUBMIT=true (for code style) Review-Url: https://codereview.chromium.org/2292573002 Cr-Commit-Position: refs/heads/master@{#39057}
-
- 10 Aug, 2016 1 commit
-
-
epertoso authored
NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true Review-Url: https://codereview.chromium.org/2231083002 Cr-Commit-Position: refs/heads/master@{#38546}
-
- 22 Mar, 2016 1 commit
-
-
mstarzinger authored
The linter (i.e. cpplint.py) no longer needs to check for alpha-sorted include directives because our source formatting (i.e. clang-format) will take care of this by now. This is the current default configuration of the underlying linter anyways. Note that the two tools disagree about the correct ordering about files containing dash characters. The ordering suggested by the formatter is more natural. Having the formatter trigger linter errors is not a good situation to be in. R=jochen@chromium.org Review URL: https://codereview.chromium.org/1822003002 Cr-Commit-Position: refs/heads/master@{#34985}
-
- 25 Jan, 2016 1 commit
-
-
titzer authored
R=mstarzinger@chromium.org,rossberg@chromium.org,bmeurer@chromium.org,hpayer@chromium.org,jochen@chromium.org BUG= Review URL: https://codereview.chromium.org/1600873002 Cr-Commit-Position: refs/heads/master@{#33485}
-
- 10 Dec, 2015 1 commit
-
-
mstarzinger authored
R=jochen@chromium.org Review URL: https://codereview.chromium.org/1506233008 Cr-Commit-Position: refs/heads/master@{#32745}
-
- 27 Nov, 2015 1 commit
-
-
jkummerow authored
And add a presubmit check to guard against future duplicates. R=machenbach@chromium.org Review URL: https://codereview.chromium.org/1477403002 Cr-Commit-Position: refs/heads/master@{#32380}
-
- 25 Nov, 2015 1 commit
-
-
machenbach authored
This loads all test suites and status files to catch subtle syntax errors. It also checks basic status file integrity and common mistakes. NOTRY=true Review URL: https://codereview.chromium.org/1475663002 Cr-Commit-Position: refs/heads/master@{#32271}
-
- 04 Nov, 2015 1 commit
-
-
ishell authored
Review URL: https://codereview.chromium.org/1412223018 Cr-Commit-Position: refs/heads/master@{#31785}
-
- 30 Sep, 2015 1 commit
-
-
mstarzinger authored
This enables linter checking for "readability/namespace" violations during presubmit and instead marks the few known exceptions that we allow explicitly. R=bmeurer@chromium.org Review URL: https://codereview.chromium.org/1371083003 Cr-Commit-Position: refs/heads/master@{#31019}
-
- 28 Sep, 2015 1 commit
-
-
mstarzinger authored
R=bmeurer@chromium.org Review URL: https://codereview.chromium.org/1365803004 Cr-Commit-Position: refs/heads/master@{#30963}
-
- 25 Sep, 2015 1 commit
-
-
mstarzinger authored
This enables linter checking for "runtime/threadsafe_fn" violations during presubmit and instead marks the few known exceptions that we allow explicitly. R=jochen@chromium.org Review URL: https://codereview.chromium.org/1369673003 Cr-Commit-Position: refs/heads/master@{#30933}
-
- 07 Sep, 2015 1 commit
-
-
mstarzinger authored
This enables the general linter checking for "build/c++11" violations during presubmit and instead marks the few known exceptions that we allow explicitly. R=jochen@chromium.org Review URL: https://codereview.chromium.org/1317463007 Cr-Commit-Position: refs/heads/master@{#30621}
-