- 14 Aug, 2017 25 commits
-
-
Sathya Gunasekaran authored
In the case of a function constructor or eval, we create a new script object which doesn't have a script name. In this case, we traverse upwards on the list of SFI's through script->eval_from_shared() to get the outermost script that was not an eval script and get the script name from that script. Bug: chromium:746909, v8:6683, v8:5785 Change-Id: I430459f632a0e3b18fc3111a5cf1c00cedb9f520 Reviewed-on: https://chromium-review.googlesource.com/606701 Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by:
Adam Klein <adamk@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#47352}
-
Ali Ijaz Sheikh authored
Bug: Change-Id: I5698f846e72e4f86b392a0c745a9f4793c7f4f25 Reviewed-on: https://chromium-review.googlesource.com/608584Reviewed-by:
-
Mircea Trofin authored
The way we access wasm addresses or sizes is the same, on a platform. We have 2 size parameters - memory and table - and 2 addresses - globals and memory. The CL also renames for generality the address setting API. Bug: Change-Id: Ib66c3aff6a0ab4313391528cd2692749bb389559 Reviewed-on: https://chromium-review.googlesource.com/612597 Commit-Queue: Brad Nelson <bradnelson@chromium.org> Reviewed-by:
Brad Nelson <bradnelson@chromium.org> Cr-Commit-Position: refs/heads/master@{#47350}
-
Adam Klein authored
Change-Id: I612b7500556eb9763d6668716b1b7331e31f3079 Reviewed-on: https://chromium-review.googlesource.com/614399Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#47349}
-
Sampson Gao authored
R=bjaideep@ca.ibm.com, jyan@ca.ibm.com, joransiu@ca.ibm.com Bug: Change-Id: I80bbb38800c9c43e95045f5db5b63894a5a0711a Reviewed-on: https://chromium-review.googlesource.com/614113Reviewed-by:
Jaideep Bajwa <bjaideep@ca.ibm.com> Commit-Queue: Jaideep Bajwa <bjaideep@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#47348}
-
Mostyn Bramley-Moore authored
* Avoid "using namespace" statements, which trigger clang's -Wheader-hygiene warnings in jumbo builds. * Undefine created macros at the end of source files. BUG=chromium:746958 Change-Id: I5d25432c314437f607b0e1be22765a6764267ba6 Reviewed-on: https://chromium-review.googlesource.com/610962Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Mostyn Bramley-Moore <mostynb@opera.com> Cr-Commit-Position: refs/heads/master@{#47347}
-
Karl Schimpf authored
Fixes the implementation of wasm exceptions to use a WasmRuntimeError object, and set the exception tag value as a property of the object. This guarantees that an uncaught wasm exception is treated like all other runtime errors. Bug: v8:6577 Change-Id: I0ab0130444e745178e86c23b3bc9fc9f385c8d05 Reviewed-on: https://chromium-review.googlesource.com/611124Reviewed-by:
Bill Budge <bbudge@chromium.org> Reviewed-by:
Eric Holk <eholk@chromium.org> Commit-Queue: Karl Schimpf <kschimpf@chromium.org> Cr-Commit-Position: refs/heads/master@{#47346}
-
Franziska Hinkelmann authored
Add benchmark for TypedArray.prototype.set from a regular array. Bug: v8:6704 Change-Id: I350960dec530c06e7cad62eec1f977d8fda97347 Reviewed-on: https://chromium-review.googlesource.com/613163Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Franziska Hinkelmann <franzih@chromium.org> Cr-Commit-Position: refs/heads/master@{#47345}
-
Jaideep Bajwa authored
Port c820b89b Original Commit Message: Removes the new.target slot from the interpreter's fixed frame. Instead adds a field to BytecodeArray to get the bytecode's incoming new.target or generator object register. The InterpreterEntryTrampoline then sets this register with the incoming new.target (or generator object) when the function is called. This register can be directly the new.target or generator object variable if they are LOCAL location, otherwise it is a temporary register which is then moved to the variable's location during the function prologue. This fixes a hack in the deoptimizer where we would set the new.target fixed slot to undefined in order to avoid extending it's lifetime through the optimized code - now it's just a standard register and can be optimized away as normal. R=rmcilroy@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Change-Id: Ifb93179153016ad989c6ae3675554e70c426e2fa Reviewed-on: https://chromium-review.googlesource.com/612746Reviewed-by:
Joran Siu <joransiu@ca.ibm.com> Commit-Queue: Jaideep Bajwa <bjaideep@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#47344}
-
Franziska Hinkelmann authored
Add a benchmark for TypedArray.prototype.set when setting from another TypedArray with a different type. Bug: v8:6704 Change-Id: Iad5585fe7d3a28b5b1a1b1f85ec81be659959239 Reviewed-on: https://chromium-review.googlesource.com/613267 Commit-Queue: Franziska Hinkelmann <franzih@chromium.org> Reviewed-by:
-
Franziska Hinkelmann authored
Add benchmark for TypedArray.prototype.set when setting from another TypedArray with the same type. Bug: v8:6704 Change-Id: Ibde60b17aa32fb9c8237b2ab766d2b2913e256d7 Reviewed-on: https://chromium-review.googlesource.com/613264Reviewed-by:
-
Georg Neis authored
R=jarin@chromium.org Bug: Change-Id: I97c2d73ea4ac83802421be85da327e214939d5a1 Reviewed-on: https://chromium-review.googlesource.com/610006Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#47341}
-
Yang Guo authored
R=petermarshall@chromium.org Bug: v8:6687 Change-Id: Ic447a6cd5cb8a7a251b4820fc82f1f1d033be355 Reviewed-on: https://chromium-review.googlesource.com/612067Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#47340}
-
Martyn Capewell authored
Delete StringCharCodeAtGenerator, as it's no longer used. Bug: Change-Id: I05294fac69671c0652742d120de9ea17e9031518 Reviewed-on: https://chromium-review.googlesource.com/613164Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Martyn Capewell <martyn.capewell@arm.com> Cr-Commit-Position: refs/heads/master@{#47339}
-
Michael Achenbach authored
The V8 mac asan bots correspond to "Mac ASAN Release" and "Mac ASAN Debug" from chromium.lkgr waterfall. Depends on infra side: https://chromium-review.googlesource.com/c/613162 TBR=yangguo@chromium.org NOTRY=true Bug: chromium:726584 Change-Id: Ic71e3577485131b260801eef9e801ab19ed093c1 Reviewed-on: https://chromium-review.googlesource.com/613480Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#47338}
-
Ross McIlroy authored
Splits CompileUnoptimizedCode into a non-main thread GenerateUnoptimizedCode and a main thread FinalizeUnoptimizedCode phase. Adds Disallow<HeapAccess> scopes in CompileUnoptimizedCode to ensure no access to the heap during this phase. Also cleans up a few heap accesses in CompilationInfo's constructor to avoid violating the disallowed heap access. Currently we reallow heap access during asm.js compilation as a temporary measure until the script streamer uses an off-heap script buffer. BUG=v8:5203 TBR=titzer@chromium.org Change-Id: I7f6140f19938a10a85f1cd89501812dd59dbf6d4 Reviewed-on: https://chromium-review.googlesource.com/605949 Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Marja Hölttä <marja@chromium.org> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#47337}
-
Ulan Degenbaev authored
This follows up 4af9cfcc by separating incremental marking state from the full MC marking state. Runtime and tests now use only the incremental marking state. The full MC marking state used by MC during atomic pause. This separation decouples atomicity of markbit accesses during incremental marking and during full MC. Bug: chromium:694255 TBR: mlippautz@chromium.org Change-Id: Ia409ab06515cd0d1403a272a016633295c0d6692 Reviewed-on: https://chromium-review.googlesource.com/612350 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#47336}
-
Michael Achenbach authored
Depends on infra change: https://chromium-review.googlesource.com/c/612079 This emulates the same GN configurations as from the builders "UBSan Release" and "UBSan vptr Release" on the chromium.lkgr waterfall. NOTRY=true TBR=yangguo@chromium.org Bug: chromium:726584 Change-Id: I248765f7f8353351da2a4d5b897b06cbc04ba007 Reviewed-on: https://chromium-review.googlesource.com/612982Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
-
Ulan Degenbaev authored
The function shouldn't try to start black allocation if it is already started. Bug: chromium:694255 TBR: mlippautz@chromium.org Change-Id: I77b5346f6ac2ec5947ca4351a8abe33865729fda Reviewed-on: https://chromium-review.googlesource.com/612385Reviewed-by:
-
Ulan Degenbaev authored
Bug: chromium:694255 TBR: mlippautz@chromium.org Change-Id: I207fd28c2e19637f45da3735284c8ca223b33481 Reviewed-on: https://chromium-review.googlesource.com/610562Reviewed-by:
-
Michael Achenbach authored
This reverts commit 01cae9ef. Reason for revert: Seeing several flaky crashes on windows associated to this change: https://build.chromium.org/p/client.v8/builders/V8%20Win64%20-%20debug/builds/18407 https://build.chromium.org/p/client.v8/builders/V8%20Win64%20-%20debug/builds/18408 Original change's description: > [Memory] Improve OOM callback tests. > > - Changes OOM tests to keep allocating more and more, starting from a > large amount, until we exhaust address space and get a failure. > > Bug: v8:6635 > Change-Id: I007927c5f639ed395d90198272c93b6ee0e58249 > Reviewed-on: https://chromium-review.googlesource.com/609264 > Commit-Queue: Bill Budge <bbudge@chromium.org> > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#47328} TBR=bbudge@chromium.org,mlippautz@chromium.org Change-Id: Ibe49f99040e1a3c595ed836d1d40dbd0c7247d1c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:6635 Reviewed-on: https://chromium-review.googlesource.com/612288Reviewed-by:
-
Michael Achenbach authored
This reverts commit 0d14ad57. Reason for revert: Seems to add a static initializer: https://build.chromium.org/p/client.v8/builders/V8%20Linux/builds/19779 Original change's description: > [builtins] Fix union initialization > > Fix d4c157ee commit > > On big endian platforms wrong byte is being read when accessing > "parameter_count" field of union, in function > failing on MIPS big endian platforms. > > Builtins: :GetStackParameterCount. It is the reason of several tests > Bug: > Change-Id: Ia21aba80a89215022ee218d27552b5b4ea18a0db > Reviewed-on: https://chromium-review.googlesource.com/603808 > Commit-Queue: Ivica Bogosavljevic <ivica.bogosavljevic@imgtec.com> > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Cr-Commit-Position: refs/heads/master@{#47330} TBR=jkummerow@chromium.org,jarin@chromium.org,jgruber@chromium.org,predrag.rudic@imgtec.com,ivica.bogosavljevic@imgtec.com Change-Id: I596bb1a04c72c8f5cb4f7b4a8e9161bd5889683d No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/612287Reviewed-by:
-
Predrag Rudic authored
Fix d4c157ee commit On big endian platforms wrong byte is being read when accessing "parameter_count" field of union, in function failing on MIPS big endian platforms. Builtins: :GetStackParameterCount. It is the reason of several tests Bug: Change-Id: Ia21aba80a89215022ee218d27552b5b4ea18a0db Reviewed-on: https://chromium-review.googlesource.com/603808 Commit-Queue: Ivica Bogosavljevic <ivica.bogosavljevic@imgtec.com> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#47330}
-
v8-autoroll authored
Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/a1420b8..5bad4f2 TBR=machenbach@chromium.org,hablich@chromium.org Change-Id: I7cf78bd76d7a5126194bfcb5538803de8e6ea601 Reviewed-on: https://chromium-review.googlesource.com/612852Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#47329}
-
Bill Budge authored
- Changes OOM tests to keep allocating more and more, starting from a large amount, until we exhaust address space and get a failure. Bug: v8:6635 Change-Id: I007927c5f639ed395d90198272c93b6ee0e58249 Reviewed-on: https://chromium-review.googlesource.com/609264 Commit-Queue: Bill Budge <bbudge@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#47328}
-
- 13 Aug, 2017 1 commit
-
-
v8-autoroll authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/b810910..876f9d1 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/3be402c..a1420b8 TBR=machenbach@chromium.org,hablich@chromium.org Change-Id: I798d723b736faa1eff4cd50f34e7af9bc3f36a26 Reviewed-on: https://chromium-review.googlesource.com/612842Reviewed-by:
-
- 12 Aug, 2017 4 commits
-
-
Marja Hölttä authored
- See bug for the reduced test case. - Not adding a regression test here: I don't want to assert that PreParser doesn't detect the redeclaration error, OTOH I don't want to make it detect the error either (in order to not couple detecting the error with FLAG_experimental_preparser_analysis). BUG=chromium:753896, v8:5516 Change-Id: I0f1beffe30e5cb48d6dbec35181980864e6df153 Reviewed-on: https://chromium-review.googlesource.com/608976Reviewed-by:
-
Marja Hölttä authored
These now pass because of https://chromium-review.googlesource.com/603787. BUG=v8:5516 Change-Id: Ifcb576056c3cba523e56c5c9c563724efe096012 Reviewed-on: https://chromium-review.googlesource.com/608972Reviewed-by:
-
Eric Holk authored
Bug: Change-Id: I51bef9b0b4bb109fe86d4f6f445db46c1335606f Reviewed-on: https://chromium-review.googlesource.com/612506Reviewed-by:
-
v8-autoroll authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/7c87e0e..b810910 Rolling v8/third_party/catapult: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+log/0eeb5ba..5db5135 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/7770b47..3be402c TBR=machenbach@chromium.org,hablich@chromium.org Change-Id: I6b6fa358050a92669961345aa201690f351f943b Reviewed-on: https://chromium-review.googlesource.com/612195Reviewed-by:
-
- 11 Aug, 2017 10 commits
-
-
Benedikt Meurer authored
These operators were only used by the old asm.js pipeline (with fullcodegen and the AstGraphBuilder). When going through the new pipeline, accesses to TypedArrays are handled by the native context specialization during inlining. Bug: v8:6409 Change-Id: Ib9b888c0b96f297a335580ee42dfa951bde566be Reviewed-on: https://chromium-review.googlesource.com/612347Reviewed-by:
-
Alexey Kozyatinskiy authored
R=dgozman@chromium.org Bug: chromium:754560 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: I3c0d5c4eebc3e8dbfa6663210046d6a86b1226b5 Reviewed-on: https://chromium-review.googlesource.com/612452Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#47321}
-
Ross McIlroy authored
Removes the new.target slot from the interpreter's fixed frame. Instead adds a field to BytecodeArray to get the bytecode's incoming new.target or generator object register. The InterpreterEntryTrampoline then sets this register with the incoming new.target (or generator object) when the function is called. This register can be directly the new.target or generator object variable if they are LOCAL location, otherwise it is a temporary register which is then moved to the variable's location during the function prologue. This fixes a hack in the deoptimizer where we would set the new.target fixed slot to undefined in order to avoid extending it's lifetime through the optimized code - now it's just a standard register and can be optimized away as normal. Bug=v8:6644 Change-Id: Ieb8cc34cccefd9fb6634a90cbc77c6002a54f2ae Reviewed-on: https://chromium-review.googlesource.com/608966 Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
-
Ulan Degenbaev authored
This reverts commit a7c7e8f6. Reason for revert: TSAN failures. Original change's description: > [heap] Handle bytecode arrays in concurrent marker. > > Bytecode array visitor has a side-effect of incrementing the age counter. > > This patch makes the increment atomic and thus safe for the concurrent > marker. > > Bug: chromium:694255 > Change-Id: I36c65b02ace8d366206bd8295e72aaa19742ed56 > Reviewed-on: https://chromium-review.googlesource.com/610001 > Commit-Queue: Ulan Degenbaev <ulan@chromium.org> > Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#47317} TBR=ulan@chromium.org,rmcilroy@chromium.org Change-Id: Iceff1e5925bb6ad7c03f858aa2f1fa62240f6909 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:694255 Reviewed-on: https://chromium-review.googlesource.com/612069Reviewed-by:
-
Alexey Kozyatinskiy authored
As long as we have scripts with negative source offset (see inline event listeners) we should not crash a browser when get negative offset. R=jgruber@chromium.org Bug: chromium:750592 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: Ic3138e7c61ec0a5133c56de9970acdffa5536d8e Reviewed-on: https://chromium-review.googlesource.com/611613Reviewed-by:
-
Ulan Degenbaev authored
Bytecode array visitor has a side-effect of incrementing the age counter. This patch makes the increment atomic and thus safe for the concurrent marker. Bug: chromium:694255 Change-Id: I36c65b02ace8d366206bd8295e72aaa19742ed56 Reviewed-on: https://chromium-review.googlesource.com/610001 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
-
Jakob Kummerow authored
It expected its argument to be a JSFunction, but fuzzer tests can pass anything. Non-JSFunction arguments should just silently be ignored, just like similar CF-whitelisted runtime functions do. Bug: chromium:754177 Change-Id: I41b29528bbe72f24b3d84f021b22602160769d26 Reviewed-on: https://chromium-review.googlesource.com/610706Reviewed-by:
-
Ulan Degenbaev authored
Shared function info marking is now side-effect free, so can be handled by base HeapVisitor. Concurrent marker does not bailout on shared function infos. Bug: chromium:694255 Change-Id: I41efece68f6758219fca318deb97a7f163ee9638 Reviewed-on: https://chromium-review.googlesource.com/608700 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
-
Ulan Degenbaev authored
Change-Id: I91bae96b82078a310b67707f98fb257896e3e00f Reviewed-on: https://chromium-review.googlesource.com/612083Reviewed-by:
-
Georg Neis authored
R=marja@chromium.org Bug: Change-Id: I641ca830bb11b91e7098ee8d2dbec5d523bbc879 Reviewed-on: https://chromium-review.googlesource.com/612082Reviewed-by:
-
