- 03 Feb, 2021 22 commits
-
-
Ng Zhi An authored
Bug: v8:11347,v8:11348 Change-Id: I47ba950b80197d1d769d93aa68266131be9bf31d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2666146Reviewed-by:
Deepti Gandluri <gdeepti@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#72518}
-
Ng Zhi An authored
Load lane instructions also need a v128 input. Bug: chromium:1173488 Change-Id: I45e4c4f8fc93a5b3246ac4d1b07925b41cbe3e89 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2673275Reviewed-by:
-
Milad Fa authored
Port 8798b3ef Port 1d3c80d3 Original Commit Message: - Fixes some incorrect assumptions about padding in the code generation. Slots may have apparent extra padding when allocation fragments go unused. - Reworks 32 bit push code to simplify skipping slot gaps when 'push' instructions are used. - Adds a ElementSizeInPointers function on machine representations. R=bbudge@chromium.org, joransiu@ca.ibm.com, junyan@redhat.com, midawson@redhat.com BUG= LOG=N Change-Id: I076ae8396434610c52fed040ace5e0f49ea3ef88 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2673142 Commit-Queue: Milad Fa <mfarazma@redhat.com> Reviewed-by:
Junliang Yan <junyan@redhat.com> Cr-Commit-Position: refs/heads/master@{#72516}
-
Bill Budge authored
- Stack adjustment was in slots, when it should be in bytes. Bug: v8:11391 Change-Id: Ia791f2b637337279be62d66377f9b5be35f31839 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2674062Reviewed-by:
Zhi An Ng <zhin@chromium.org> Commit-Queue: Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#72515}
-
Ng Zhi An authored
These didn't have the right suffix (i32 instead of i32x4). Also, names are longer now, so when tracing them, give the names column more space. Bug: v8:11384 Change-Id: Id11e0d23b344310121ae4e2e5910528cab2d6f73 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2673264Reviewed-by:
Bill Budge <bbudge@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#72514}
-
Ng Zhi An authored
Bug: v8:11391 Change-Id: Icb4b6b04cc0591f9b27256f7b58daed6c4fdffa2 No-Try: true No-Tree-Checks: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2673276 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#72513}
-
Zhi An Ng authored
This reverts commit 64471ba9. Reason for revert: Fails on nosse3/nosse4 https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Linux/40643/overview Original change's description: > [wasm-simd] Update spec tests > > We can also unmark some SIMD tests as failed since we are now inline > with spec. > > Bug: v8:11331 > Change-Id: I4b98ae068008c55535dbbbf0312a55aa03e7e83d > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2668060 > Reviewed-by: Andreas Haas <ahaas@chromium.org> > Commit-Queue: Zhi An Ng <zhin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#72507} TBR=ahaas@chromium.org,zhin@chromium.org Change-Id: I11a6670e42956bdcc66c371d2d852623030948b4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:11331 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2673265Reviewed-by:
-
Junliang Yan authored
Change-Id: Ifa2b160e42bad2b3ae93a3c310d5fa158ffbd286 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2672705Reviewed-by:
Milad Fa <mfarazma@redhat.com> Commit-Queue: Junliang Yan <junyan@redhat.com> Cr-Commit-Position: refs/heads/master@{#72511}
-
Milad Fa authored
Implementation for PPC will be added in a later CL. Port dd90d107 Original Commit Message: Code sequence from https://github.com/WebAssembly/simd/pull/379, and exactly the same as x64, with minor tweaks for ExternalReferenceAsOperand. R=zhin@chromium.org, joransiu@ca.ibm.com, junyan@redhat.com, midawson@redhat.com BUG= LOG=N Change-Id: I2be8a9cf04d0b327c15f47c2575877925238353c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2672706Reviewed-by:
-
Ng Zhi An authored
roundpd requires SSE4.1. Bug: v8:11265 Change-Id: I1b5d322946de44f57026b09ec406d32128e5b3bd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2668916Reviewed-by:
-
Shu-yu Guo authored
There is a bug in the top-level await spec draft such that async strongly connected components are not always evaluated before their depending modules. See https://github.com/tc39/proposal-top-level-await/pull/161 for full discussion and spec fix. Bug: v8:11376 Change-Id: I88bf06afb2e9a5d8d0b757de8276f1d1242a875e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2667772Reviewed-by:
Adam Klein <adamk@chromium.org> Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Commit-Queue: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/master@{#72508}
-
Ng Zhi An authored
We can also unmark some SIMD tests as failed since we are now inline with spec. Bug: v8:11331 Change-Id: I4b98ae068008c55535dbbbf0312a55aa03e7e83d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2668060Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#72507}
-
Bill Budge authored
This is a reland of 352b9ecb The test/fix CL has been merged in, as the fixes to return slot accounting are needed to fix Arm64 issues turned up by the fuzzers: https://chromium-review.googlesource.com/c/v8/v8/+/2644139 Original change's description: > Reland "Reland "[compiler][wasm] Align Frame slots to value size"" > > This is a reland of 1694925c > > Minor fix to linkage for constexpr. > > TBR=ahaas@chromium.org,neis@chromium.org > > Original change's description: > > Reland "[compiler][wasm] Align Frame slots to value size" > > > > This is a reland of cddaf66c > > > > Original change's description: > > > [compiler][wasm] Align Frame slots to value size > > > > > > - Adds an AlignedSlotAllocator class and tests, to unify slot > > > allocation. This attempts to use alignment holes for smaller > > > values. > > > - Reworks Frame to use the new allocator for stack slots. > > > - Reworks LinkageAllocator to use the new allocator for stack > > > slots and for ARMv7 FP register aliasing. > > > - Fixes the RegisterAllocator to align spill slots. > > > - Fixes InstructionSelector to align spill slots. > > > > > > Bug: v8:9198 > > > > > > Change-Id: Ida148db428be89ef95de748ec5fc0e7b0358f523 > > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2512840 > > > Commit-Queue: Bill Budge <bbudge@chromium.org> > > > Reviewed-by: Georg Neis <neis@chromium.org> > > > Reviewed-by: Andreas Haas <ahaas@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#71644} > > > > Bug: v8:9198 > > Change-Id: Ib91fa6746370c38496706341e12d05c7bf999389 > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2633390 > > Commit-Queue: Bill Budge <bbudge@chromium.org> > > Reviewed-by: Andreas Haas <ahaas@chromium.org> > > Reviewed-by: Georg Neis <neis@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#72195} > > Bug: v8:9198 > Change-Id: I91e02b823af8ec925dacf075388fb22e3eeb3384 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2640890 > Reviewed-by: Bill Budge <bbudge@chromium.org> > Commit-Queue: Bill Budge <bbudge@chromium.org> > Cr-Commit-Position: refs/heads/master@{#72209} Bug: v8:9198 Change-Id: I8258f87463f66417c7028b9a1fed4b9b6d82a3be Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2669892Reviewed-by:
Georg Neis <neis@chromium.org> Reviewed-by:
-
Mythri A authored
OSR compilations happen on main thread and the functions that are called from would have been already optimized. Also this code is only used for this invocation. So to limit the amount of time spent on main thread we could do a quick Turboprop compilation instead of a highly optimized TurboFan compilaiton. Change-Id: Ifcdcb5c855d8a9a56b13c1940b4ee0ed3bfb4d67 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2659257 Commit-Queue: Mythri Alle <mythria@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#72505}
-
Michael Achenbach authored
Bug: chromium:1174040 Change-Id: I2ee539e5074707ac93f97a9a3a131e9c2745cdbe Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2672180Reviewed-by:
Maya Lekova <mslekova@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#72504}
-
Michael Lippautz authored
Adds testing API that can only be used after enabling it on a heap. The call that enables testing is only provided via v8_for_testing or cppgc_for_testing build targets which protects against misusing from production code. Change-Id: I24a8f5543a2bb479481384e2c555d231383e5d12 Bug: chromium:1056170 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2667513Reviewed-by:
Hannes Payer <hpayer@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Omer Katz <omerkatz@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#72503}
-
Bill Budge authored
- Fixes some incorrect assumptions about padding in the code generation. Slots may have apparent extra padding when allocation fragments go unused. - Reworks 32 bit push code to simplify skipping slot gaps when 'push' instructions are used. - Adds a ElementSizeInPointers function on machine representations. Bug: chromium:1171759,v8:9198 Change-Id: I029e300fa9c306d7e35344576fd1c68857cf2bca Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2660379 Commit-Queue: Bill Budge <bbudge@chromium.org> Reviewed-by:
-
Thibaud Michaud authored
R=ahaas@chromium.org,ulan@chromium.org Bug: v8:8091 Change-Id: Ia826e18bd06b5e6d401ff43b33b43b4e4c2a69db Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2672022Reviewed-by:
-
Sathya Gunasekaran authored
IsAnyInitialArrayPrototype doesn't need an handlified input argument as it doesn't cause GC. This improves performance of MapData::MapData as canonical handle scope creation is expensive. Change-Id: I2e1a46354276857b64867ea3e994356faef8950e Bug: v8:9684 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2671659 Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by:
-
Seth Brenith authored
When generating getters, Torque needs to decide whether to perform a normal or relaxed load. Thus far, it has used the somewhat non-obvious logic that any indexed field with tagged non-smi data gets relaxed loads. This change adds a new annotation @relaxedRead to be consistent with the existing @relaxedWrite annotation. I added @relaxedRead annotations on any field that previously had this automatic behavior and whose getter is called, except for those in ScopeInfo because I'm relatively confident that it doesn't need relaxed access. Bug: v8:7793 Change-Id: I9987eea13760b967f1b8a3189b69742e55140c30 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2600113 Commit-Queue: Seth Brenith <seth.brenith@microsoft.com> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Nico Hartmann <nicohartmann@chromium.org> Cr-Commit-Position: refs/heads/master@{#72499}
-
Leszek Swirski authored
Fix some trailing whitespace issues in files in the tools directory. Change-Id: If9e9b1dab1d6f521e20619a2a1d093749f0528d9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2671660 Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
-
Santiago Aboy Solanes authored
Also access the DescriptorArray through GetPropertyKey concurrently if the FLAG_turbo_direct_heap_access is on. Bug: v8:7790 Change-Id: I29e5895fefc3653f954ba56aa85218121402e7ed Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2653232Reviewed-by:
-
- 02 Feb, 2021 18 commits
-
-
Milad Fa authored
Port 45b99aaa Original Commit Message: In https://crrev.com/c/2645694 we push the full q registers before lazy compile, but we did not change the fixed frame size to account for the wider registers being pushed. This manifested in the frame having data like: (gdb) x/10xg start.ptr_ 0x7f5576ff3eb0: 0x0000000000000000 0x0000336b08202759 0x7f5576ff3ec0: 0x7ff000007f801000 0x0000000000000000 0x7f5576ff3ed0: 0x7ff000007f801001 0x0000000000000000 0x7f5576ff3ee0: 0x7ff000007f801002 0x0000000000000000 0x7f5576ff3ef0: 0x7ff000007f801003 0x0000000000000000 The GC then walks part of this frame, thinking that 0x7ff000007f801003 is a heap object, and then crashes. Add some static_asserts (similar to builtins-x64) to remind ourselves that the pushed registers have to match the size in frame constants. R=zhin@chromium.org, joransiu@ca.ibm.com, junyan@redhat.com, midawson@redhat.com BUG= LOG=N Change-Id: I994f1b7fecbb24ea97d846b1eed98201bc3b08ad Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2669308Reviewed-by:
-
Ng Zhi An authored
Code sequence from https://github.com/WebAssembly/simd/pull/379, and exactly the same as x64, with minor tweaks for ExternalReferenceAsOperand. Bug: v8:11002 Change-Id: Icbfdac62b21c2734ad4886b3d48f34e29f7a8222 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2664860 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
-
Milad Fa authored
Port 910d92e2 Original Commit Message: This is a partial revert of https://crrev.com/c/2457669 to add back i64x2.ne and i64x2.all_true, which were accepted into the proposal (https://github.com/WebAssembly/simd/issues/419). This only implements it for x64 and arm64 on TurboFan, other archs and Liftoff will come later. R=zhin@chromium.org, joransiu@ca.ibm.com, junyan@redhat.com, midawson@redhat.com BUG= LOG=N Change-Id: I9aedc94f665a7e02426e0abe44cea72176063942 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2668830Reviewed-by:
-
Ng Zhi An authored
Bug: v8:11217 Change-Id: I6e61b11babc0baecf7b1982ef779b941d3344182 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2667971Reviewed-by:
-
Milad Fa authored
V8 uses the same set of fp param registers as Simd param registers. As these registers are two different sets on ppc we must make sure to also save them when Simd is enabled. Check the comments under crrev.com/c/2645694 for more details. Port 3b302d5c Original Commit Message: If a lazy compilation happens in between 2 Wasm calls, we need to save the full Q register, since we can have live v128 values. R=zhin@chromium.org, joransiu@ca.ibm.com, junyan@redhat.com, midawson@redhat.com BUG= LOG=N Change-Id: Icdd0a6d38225a866b61651ff406598c144c25ebf Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2667952Reviewed-by:
-
Ng Zhi An authored
We were hitting an implementation defined behavior in this instruction: - v is clamped to uint8_t::min and uint8_t::max - then we static_cast<int8_t>(v) - any values that don't fit in int8_t (> 127) hits and implementation defined behavior We reuse base::saturated_cast here instead to avoid this undefined behavior. Drive-by cleanup of test cases to make the signed/unsigned cases more explicity. Bug: v8:11372 Change-Id: I4e92cdfb685d74bd5436ba25f1c00db49a231221 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2659501 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
-
Thibaud Michaud authored
R=clemensb@chromium.org Bug: v8:8091 Change-Id: Id2f0b4635ee235c592a969a41d1f50ed677150f2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2667857Reviewed-by:
Clemens Backes <clemensb@chromium.org> Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/heads/master@{#72490}
-
Ng Zhi An authored
This is a partial revert of https://crrev.com/c/2457669 to add back i64x2.ne and i64x2.all_true, which were accepted into the proposal (https://github.com/WebAssembly/simd/issues/419). This only implements it for x64 and arm64 on TurboFan, other archs and Liftoff will come later. Bug: v8:11347,v8:11348 Change-Id: I86934478760e3d501ecdb3ce6c9b702764cc0838 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2665005Reviewed-by:
-
Junliang Yan authored
Change-Id: I6b0aa0daab07728f5a524ecba289276c7fa33a08 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2668568Reviewed-by:
-
Marja Hölttä authored
Now with more fixes. Bug: chromium:1162473, v8:11383 Change-Id: I54751cef03f6b2b1dc70324486441c9b0b011cc1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2667512 Auto-Submit: Marja Hölttä <marja@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
-
Junliang Yan authored
Change-Id: I34552a97244c5f4c343d16e5093676e3af5c210b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2667510Reviewed-by:
-
Benedikt Meurer authored
Previously the WebAssembly debugger support completely ignored the condition on breakpoints. With this change, we check conditions (snippets of JavaScript) properly, which enables not only conditional breakpoints in the front-end, but also other features like 'Never pause here' (which simply sets `false` as condition) and log points. Fixed: chromium:1173007 Bug: chromium:1173006 Change-Id: I02c740d383378a1f4cc08134ad571bea08e9a905 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2666690Reviewed-by:
-
Clemens Backes authored
We are often stepping multiple times without inspecting the state in-between. Hence, the generated debug side table is often not being used. Instead of always generating it, we can generate it lazily on demand, which can avoid the need to generate it at all. R=thibaudm@chromium.org TEST=inspector/debugger/wasm-stepping Bug: chromium:1172299 Change-Id: I9b9ff4485d65d720d23585856b3d672925460667 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2664446 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/heads/master@{#72484}
-
Santiago Aboy Solanes authored
Also, enable concurrent GetBackPointer(). Bug: v8:7790 Change-Id: If92cb7cdd9e6f5eb9a636764ca8abe2fc2c05ab2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2650205 Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by:
-
Jakob Kummerow authored
When constant-folding the test based on static types in the function body decoder, we have to ensure Liftoff's value stack is properly updated. Fixed: chromium:1172912 Change-Id: I618992608882b850a8a4bce0b267ce456e4c2a40 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2664447Reviewed-by:
Manos Koukoutos <manoskouk@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Auto-Submit: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#72482}
-
Clemens Backes authored
This reverts commit a850668c. Reason for revert: new test flaking on many bots, e.g. https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Win32/31068/overview Original change's description: > [d8] Fix a crash when getting the worker's onmessage handler > > Bug: chromium:1162473 > Change-Id: Ided2f52882aaf02e1dc9a8d0ba883fedf029464d > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2663004 > Reviewed-by: Camillo Bruni <cbruni@chromium.org> > Commit-Queue: Marja Hölttä <marja@chromium.org> > Cr-Commit-Position: refs/heads/master@{#72473} TBR=marja@chromium.org,cbruni@chromium.org Change-Id: I5ec056185967974a94fd61baec8a75e855e1a272 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1162473, v8:11383 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2666693Reviewed-by:
-
Leszek Swirski authored
Add a simple backtrace/bt command to the simulator debugger, which does the frame-pointer stack walk and dumps pc/fp/sp for each frame. This is strictly less powerful than the full JS stack dump, but can be used to debug issues with corrupted frames that prevent the JS stack dumper from working correctly. Change-Id: I26cc962ab8d22c0a219d6a35548544602aa89418 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2666688 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#72480}
-
Leszek Swirski authored
Extract out the command processing from Simulator::Debug(), and expose it to gdb as a new 'sim' command. Example usage: (gdb) sim p x15 (gdb) sim stack The sim command will execute that one command, and will return to gdb. For a list of all commands, you can call (gdb) sim help Note that sim won't resume simulator execution until gdb continues execution; for example, `sim next` will set a breakpoint on the next instruction, and will return to gdb. The user then has to continue execution in gdb, at which point the simulator will break. The user can then re-enter gdb with the gdb command. This will look like this: (gdb) sim next (gdb) continue ... sim> gdb (gdb) ... Change-Id: I678e71e2642d8427950b5f7ed65890ceae69e18d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2664448 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
-
