• Ng Zhi An's avatar
    [wasm-simd] Fix I8x16UConvertI16x8 in interpreter · 2e9b0e90
    Ng Zhi An authored
    We were hitting an implementation defined behavior in this instruction:
    
    - v is clamped to uint8_t::min and uint8_t::max
    - then we static_cast<int8_t>(v)
    - any values that don't fit in int8_t (> 127) hits and implementation
    defined behavior
    
    We reuse base::saturated_cast here instead to avoid this undefined
    behavior.
    
    Drive-by cleanup of test cases to make the signed/unsigned cases more
    explicity.
    
    Bug: v8:11372
    Change-Id: I4e92cdfb685d74bd5436ba25f1c00db49a231221
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2659501
    Commit-Queue: Zhi An Ng <zhin@chromium.org>
    Reviewed-by: 's avatarAdam Klein <adamk@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#72491}
    2e9b0e90
Name
Last commit
Last update
.github Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...