- 24 Nov, 2021 17 commits
-
-
Manos Koukoutos authored
Design doc: bit.ly/3jEVgzz We separate the internal representation of function references in Wasm from their JSFunction-based (external) representation. This improves performance of call_ref by requiring less indirections to load the context and call target from a function reference. In the boundary between wasm and JS/the C API, we add transformations between the two representations. Detailed changes: - Introduce WasmInternalFunction, containing fields required by call_ref, as well as a reference to the corresponding WasmExternalFunction. Add a reference to the WasmInternalFunction in WasmFunctionData. The {WasmInternalFunction::FromExternal} helper extracts the internal out of an external function. - Change {WasmInstanceObject::external_functions()} to internal functions. - Change wasm function tables to contain internal functions. - Change the following code to use internal functions: - call_ref in liftoff and Turbofan - function type checks in liftoff and Turbofan - CallRefIC and GenericJSToWasmWrapper builtins - {InitExprInterface::RefFunc} - module-compiler.cc in {ProcessTypeFeedback} - In module-instantiate.cc, in function-rtt creation. - Add transformations between internal and external functions in: - WasmWrapperGraphBuilder::{ToJS, BuildUnpackObjectWrapper, FromJS, BuildJSToJSWrapper}. - debug-wasm-objects.cc in {FunctionProxy::Get}, {WasmValueObject::New} and {AddWasmTableObjectInternalProperties}. - runtime-wasm.cc in ReplaceWrapper - the C and JS APIs - module-instantiate.cc, in import and export processing, as well as {InitializeIndirectFunctionTables} - WasmTableObject::{IsValidElement, SetFunctionTableEntry} - {WasmGlobalObject::SetFuncRef} - Simplify body descriptors of WasmExternalFunction variants. - Adjust tests. Bug: v8:11510 Change-Id: I8377f46f55c3771391ae1c5c8201a83854ee7878 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3277878Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Cr-Commit-Position: refs/heads/main@{#78068}
-
Tobias Tebbi authored
Bug: v8:12185 Change-Id: I7d5fbf624fff262b7777e443b12cb7a72d6165e5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3293404 Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
Nico Hartmann <nicohartmann@chromium.org> Cr-Commit-Position: refs/heads/main@{#78067}
-
Michael Lippautz authored
The CL converts uses of v8::internal::Worklist to heap::base::Worklist which does not require to know the number of tasks working with the work list upfront. heap::base::Worklist is the common implementation for V8's heap and cppgc and should be used/optimized going forward. Bug: v8:12426 Change-Id: I35713938ff80f43a763470f8bdf7e242439080f5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3297903 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/main@{#78066}
-
Marja Hölttä authored
In the final version, we might parse the parameters when deserializing instead, but this approach is more suitable for prototyping. Bug: v8:11525 Change-Id: I000869877b03fd1909acf602ab5190951b1939e5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3295456Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/main@{#78065}
-
Andreas Haas authored
R=jkummerow@chromium.org Bug: v8:12281 Change-Id: I94191b592350cfc8d06cf6fbadca6eaa8d37569f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3297897Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/main@{#78064}
-
Maya Lekova authored
This is a reland of d7c3f1cd. It fixes a build failure on native arm64. Original change's description: > Reland "[fastcall] Enable float support on arm64 simulator" > > This is a reland of b9ddcbc8 > > The original CL was reverted due to an MSAN issue, that is fixed by > moving the signature mapping onto the Isolate (instead of having > per-thread storage, which got invalid on multithreaded compilation). > > This CL also contains fixes for the Bazel config and for a data race > when obtaining the PerIsolateSimulatorData. > > Original change's description: > > [fastcall] Enable float support on arm64 simulator > > > > This CL adds support for handling calls to C functions with arbitrary > > signatures on the arm64 simulator. It adds infrastructure for > > encoding the signature data from CallDescriptor and FunctionInfo > > classes into a compact representation, stored in the simulator and > > called EncodedCSignature. > > > > Design doc: > > https://docs.google.com/document/d/1ZxOF3GSyNmtU0C0YJvrsydPJj35W_tTJZymeXwfDxoI/edit > > > > This CL is a follow up on the native support added in > > https://chromium-review.googlesource.com/c/v8/v8/+/3182232 > > and is partially based on the previous attempt: > > https://chromium-review.googlesource.com/c/v8/v8/+/2343072 > > > > Bug: chromium:1052746 > > Change-Id: I0991b47bd644b2fc2244c5eb923b085261f04765 > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3060486 > > Commit-Queue: Maya Lekova <mslekova@chromium.org> > > Reviewed-by: Camillo Bruni <cbruni@chromium.org> > > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > > Cr-Commit-Position: refs/heads/main@{#77744} > > Bug: chromium:1052746, chromium:1267854 > Change-Id: I89bbd01e33fb1080543d98bcfd4c2d17b5c76861 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3270541 > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Camillo Bruni <cbruni@chromium.org> > Commit-Queue: Maya Lekova <mslekova@chromium.org> > Cr-Commit-Position: refs/heads/main@{#78018} Bug: chromium:1052746, chromium:1267854 Change-Id: Ib495573569a6c930b8f9e5f1fe7ff46eb57a0aa7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3295461 Auto-Submit: Maya Lekova <mslekova@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/main@{#78063}
-
Ng Zhi An authored
Make it an enum class too, and fix all the enums to follow style guide. Fixes a -Wshadow warning, NONE shadows PropertyAttributes::None. Bug: v8:12244,v8:12245 Change-Id: I9a8181a35d5690a32a6ce58587f0d8704aa1ab40 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3291696 Auto-Submit: Zhi An Ng <zhin@chromium.org> Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/main@{#78062}
-
Marja Hölttä authored
Bug: v8:11525 Change-Id: I28548c4eddcc7764be950950e16ac30b12ac8cdd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3297890Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/main@{#78061}
-
Tobias Tebbi authored
Conditional compilation with @if/@ifnot is now allowed for - statements - typeswitch cases - enum constants - bitfield struct fields - struct fields and methods Bug: v8:7793 Change-Id: I701e8b1f4fb5c5494eaf0af6d0b540bc9166b5ca Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3296283Reviewed-by:
Nico Hartmann <nicohartmann@chromium.org> Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/main@{#78060}
-
Victor Gomes authored
When a LocalHeap is destroyed, we update (publish) the changes in the TypedSlots, this need to be protected by a mutex, since we may read the RecordRelocSlot in a different thread. Bug: v8:12054, v8:12411, chromium:1272364 Change-Id: Id1684dad3ed9e02c597099c440d1fbfdbd8c47ce Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3297892 Commit-Queue: Victor Gomes <victorgomes@chromium.org> Reviewed-by:
Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/main@{#78059}
-
Ng Zhi An authored
The fix in https://crrev.com/c/3283620 doesn't work, it was meant to be a general way to fix shadow whenever ASM_CODE_COMMENT is used, by appending the current line, via __LINE__ macro to the variable name. However, __LINE__ is not expended correctly when it is directly part of a variable name. To fix the shadowing, we use UNIQUE_IDENTIFIER to give unique names. Bug: v8:12244,v8:12245 Change-Id: I7b9b9da74d62023ac631ff0876f41e80971e2f09 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3291804 Auto-Submit: Zhi An Ng <zhin@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/main@{#78058}
-
Marja Hölttä authored
Bug: v8:11525 Change-Id: Ied08cccce533342474d520c9668d52846156a352 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3295452Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/main@{#78057}
-
Dominik Inführ authored
This CL improves --track-retaining-path with incremental marking: * Retainers need to be cleared *after* the GC and for full GCs only. Otherwise a scavenger that runs during incremental marking would clear all retainers. * Register marked root objects in IncrementalMarking::MarkRoots with retaining_root_. Change-Id: I18ab9da48fb7ac45f9ec0826334fd338dc202edc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3297893Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/main@{#78056}
-
Liu Yu authored
Port commit e127f584 Bug: chromium:1260623 Change-Id: I1462126391189f328bb5d8a8fbfb00f3bce642a8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3299283 Auto-Submit: Liu yu <liuyu@loongson.cn> Reviewed-by:
Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Commit-Queue: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Cr-Commit-Position: refs/heads/main@{#78054}
-
Jakob Gruber authored
1. The default locale may be reset / is not immutable as we thought. 2. A suffix of ignorable code points after the common length affects the comparison result. Bug: v8:12196 Fixed: v8:12398 Change-Id: I6f60f56352956779df801c43de6ebac8cd9c592d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3291314 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Auto-Submit: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/main@{#78053}
-
Benedikt Meurer authored
This is an unused overload, which doesn't add any value to keep around. Bug: none Change-Id: I6e004e28f6ec8d4c8de87a1e86d331a624694659 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3297896 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Auto-Submit: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/main@{#78052}
-
Frank Tang authored
Parser based on https://tc39.es/proposal-temporal/#sec-temporal-iso8601grammar Bug: v8:11544 Change-Id: I18eafc86da86005d5aee7b672c145fcf38a3ef5e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3271827Reviewed-by:
Adam Klein <adamk@chromium.org> Reviewed-by:
Shu-yu Guo <syg@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/main@{#78049}
-
- 23 Nov, 2021 12 commits
-
-
Milad Fa authored
This CL optimizes ByteReverse 16/32/64 ops on PPC<10 as well as PPC_10_PLUS. A 32bit sign extension is also added to `ByteRev32` in codegen. Change-Id: I6379ac4222f3574ab226971546238142039fe977 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3298308 Commit-Queue: Milad Fa <mfarazma@redhat.com> Reviewed-by:
Junliang Yan <junyan@redhat.com> Cr-Commit-Position: refs/heads/main@{#78048}
-
Marja Hölttä authored
Previous version: https://chromium-review.googlesource.com/c/v8/v8/+/3259648 Fix 1: ValueSerializer <3 JSArrayBufferView Fix 2: set flags correctly when creating DataViews via the API Bug: v8:11111 Change-Id: I9cbfdaff29f97c7823eaa3d931689b363e1f4cf7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3297708Reviewed-by:
Marja Hölttä <marja@chromium.org> Reviewed-by:
Dominik Inführ <dinfuehr@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/main@{#78046}
-
Andreas Haas authored
With dynamic tiering, caching is triggered multiple times as there is no single event anymore that triggers when the module should be cached. This CL adds a counter for the number of times caching is triggered. This counter can indicate whether our current caching heuristics are good or should get adjusted. R=thibaudm@chromium.org Bug: v8:12281 Change-Id: I8ed9ed73a556d11df643c31ec6d20760a257e0d4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3295578Reviewed-by:
Thibaud Michaud <thibaudm@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/main@{#78045}
-
Hiroshige Hayashizaki authored
This CL adds `can_use_compiled_module` parameter to WasmStreaming::Finish() that is used by Chromium https://chromium-review.googlesource.com/c/chromium/src/+/3282643 to invalidate compiled module bytes after SetCompiledModuleBytes(). Bug: chromium:1260939 Change-Id: Iebf0e8615c27c8622721777c664b06a53fb9ee91 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3297548Reviewed-by:
Andreas Haas <ahaas@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/main@{#78044}
-
Tobias Tebbi authored
Private methods use a property with symbol name that stores a context. This is then loaded to perform the brand check. Since this uses JSLoadProperty in Turbofan, we should not type JSLoadProperty as NonInternal. Bug: chromium:1269063, v8:12359 Change-Id: I920ccf46e939ab0477ff2fdb3cda6d7d94bab0af Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3293089Reviewed-by:
Nico Hartmann <nicohartmann@chromium.org> Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/main@{#78042}
-
Marja Hölttä authored
This reverts commit 8f3e53b8. Reason for revert: Blink test failures Original change's description: > [rab/gsab] Add RAB / GSAB support to DataViews > > Bug: v8:11111 > Change-Id: Ice66accee734484302d499b8098056ae1c68faf3 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3259648 > Commit-Queue: Marja Hölttä <marja@chromium.org> > Reviewed-by: Shu-yu Guo <syg@chromium.org> > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> > Cr-Commit-Position: refs/heads/main@{#78028} Bug: v8:11111 Change-Id: Icaae7276dfede8c021f3ce1a7e96ed3ec13fe4fe No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3295577 Auto-Submit: Marja Hölttä <marja@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Marja Hölttä <marja@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/main@{#78039}
-
Anton Bikineev authored
The list of to-be-finalized objects can grow significantly. While running Speedometer2, the metadata that stores to-be-finalized objects can be the second largest contributor to heap consumption (overall taking up 2.6MB, checked with heaptrack). The CL changes the list to be stored inlined in HoH, if cage-heap is enabled, rather than in a separate vector. Bug: chromium:1249550 Change-Id: I04a0c84d118655fa6ff8e2440423e802cd722842 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3295448Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Anton Bikineev <bikineev@chromium.org> Cr-Commit-Position: refs/heads/main@{#78038}
-
JianxiaoLuIntel authored
Change-Id: I6411c752e3de1fb6e1547ccfe41265c5615eb421 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3296148 Auto-Submit: Jianxiao Lu <jianxiao.lu@intel.com> Reviewed-by:
Dominik Inführ <dinfuehr@chromium.org> Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/main@{#78037}
-
jiepan authored
Change-Id: Icc245d9939649386d44ca95b9e57933b436b5cb5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3293414Reviewed-by:
Maya Lekova <mslekova@chromium.org> Commit-Queue: Jie Pan <jie.pan@intel.com> Cr-Commit-Position: refs/heads/main@{#78034}
-
jiepan authored
Bug: v8:12228 Change-Id: I21b2ee1e640ba75227a03d765bb1552eff68e3fa Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3293415Reviewed-by:
Zhi An Ng <zhin@chromium.org> Commit-Queue: Jie Pan <jie.pan@intel.com> Cr-Commit-Position: refs/heads/main@{#78033}
-
Paolo Severini authored
Bug: chromium:1271456 Change-Id: I54b81fc8e450ba65c9895ec5e22366446098dd64 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3296146Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Paolo Severini <paolosev@microsoft.com> Cr-Commit-Position: refs/heads/main@{#78032}
-
Paolo Severini authored
It is possible to inline a JSToWasm wrapper that directly calls a WasmToJS wrapper. In this case we need to make sure that the instance we pass is a WasmApiFunctionRef, not a WasmInstanceObject. Bug: chromium:1271456 Change-Id: I684a769922895860a43c73ba43c2598c9bda4b64 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3293423 Commit-Queue: Paolo Severini <paolosev@microsoft.com> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/main@{#78031}
-
- 22 Nov, 2021 11 commits
-
-
Omer Katz authored
Bug: v8:12407 Change-Id: Iedf6154796423267fdb32125a408e580bb3c205b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3295349Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/main@{#78030}
-
Anton Bikineev authored
For large working set, the sweeper metadata can significantly increase. Currently, the backing of swept_unfinalized_pages never gets freed, which causes about 300KB of memory be occupied (checked on Speedometer2). The CL makes sure to shrink (actually free) the backing after each GC cycle. Bug: chromium:1249550 Change-Id: I7c7e5248983960a498afc252a344fa71cb1444c3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3295347 Commit-Queue: Omer Katz <omerkatz@chromium.org> Auto-Submit: Anton Bikineev <bikineev@chromium.org> Reviewed-by:
Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/main@{#78029}
-
Marja Hölttä authored
Bug: v8:11111 Change-Id: Ice66accee734484302d499b8098056ae1c68faf3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3259648 Commit-Queue: Marja Hölttä <marja@chromium.org> Reviewed-by:
Shu-yu Guo <syg@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/main@{#78028}
-
Frank Tang authored
Reduce unnecessary size during development Bug: chromium:1260432 Change-Id: I690e511900abf0f8218f6ece8a5d1f144947b584 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3292484Reviewed-by:
Clemens Backes <clemensb@chromium.org> Reviewed-by:
Shu-yu Guo <syg@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/main@{#78027}
-
Ng Zhi An authored
Bug: v8:12284 Change-Id: Ia5dd40ffd1854ed8f1d6138a1bf40d8f2ca79793 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3272642Reviewed-by:
Deepti Gandluri <gdeepti@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/main@{#78025}
-
Ng Zhi An authored
Bug: v8:12244,v8:12245 Change-Id: I49326278fa43cd07c17a01b70253303d2e861b06 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3291558Reviewed-by:
Maya Lekova <mslekova@chromium.org> Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/main@{#78024}
-
Omer Katz authored
Change-Id: Id592b919b307637a0dab1ce1a7d9ec931836650c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3295458 Commit-Queue: Omer Katz <omerkatz@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Auto-Submit: Omer Katz <omerkatz@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/main@{#78022}
-
Clemens Backes authored
Many safepoint tables do not contain any deoptimization info and/or no callee-saved registers. Do not emit empty fields for all entries in this case. This often shrinks the size of the encoded safepoint table by more than 50%. Drive-by cleanups: - Rename fields of the safepoint table entries to clarify their meaning ("tagged slots" instead of "bits", "tagged register indexes" instead of "register bits"). - Include the PC in the decoded {SafepointEntry} to make it the single source of truth. R=jkummerow@chromium.org Bug: v8:12401 Change-Id: If5c24a688a434842ed3b6427f5f1f3ea9232173a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3289173Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/main@{#78021}
-
Andreas Haas authored
With dynamic tiering, not all functions get compiled with TurboFan, and not all functions can therefore get cached. With this metric we want to keep track of the time needed to compile missing functions with Liftoff. R=jkummerow@chromium.org Bug: v8:12281 Change-Id: I1f2de3e1f6b004477985df5d2116f69371528c3f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3289178Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/main@{#78020}
-
Nico Hartmann authored
This reverts commit d7c3f1cd. Reason for revert: https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Android%20Arm64%20-%20debug%20builder/22043/overview Original change's description: > Reland "[fastcall] Enable float support on arm64 simulator" > > This is a reland of b9ddcbc8 > > The original CL was reverted due to an MSAN issue, that is fixed by > moving the signature mapping onto the Isolate (instead of having > per-thread storage, which got invalid on multithreaded compilation). > > This CL also contains fixes for the Bazel config and for a data race > when obtaining the PerIsolateSimulatorData. > > Original change's description: > > [fastcall] Enable float support on arm64 simulator > > > > This CL adds support for handling calls to C functions with arbitrary > > signatures on the arm64 simulator. It adds infrastructure for > > encoding the signature data from CallDescriptor and FunctionInfo > > classes into a compact representation, stored in the simulator and > > called EncodedCSignature. > > > > Design doc: > > https://docs.google.com/document/d/1ZxOF3GSyNmtU0C0YJvrsydPJj35W_tTJZymeXwfDxoI/edit > > > > This CL is a follow up on the native support added in > > https://chromium-review.googlesource.com/c/v8/v8/+/3182232 > > and is partially based on the previous attempt: > > https://chromium-review.googlesource.com/c/v8/v8/+/2343072 > > > > Bug: chromium:1052746 > > Change-Id: I0991b47bd644b2fc2244c5eb923b085261f04765 > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3060486 > > Commit-Queue: Maya Lekova <mslekova@chromium.org> > > Reviewed-by: Camillo Bruni <cbruni@chromium.org> > > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > > Cr-Commit-Position: refs/heads/main@{#77744} > > Bug: chromium:1052746, chromium:1267854 > Change-Id: I89bbd01e33fb1080543d98bcfd4c2d17b5c76861 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3270541 > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Camillo Bruni <cbruni@chromium.org> > Commit-Queue: Maya Lekova <mslekova@chromium.org> > Cr-Commit-Position: refs/heads/main@{#78018} Bug: chromium:1052746, chromium:1267854 Change-Id: Ia8f10d085d13990b331f306957f95ecf3e003cfd No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3295453 Owners-Override: Nico Hartmann <nicohartmann@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Nico Hartmann <nicohartmann@chromium.org> Cr-Commit-Position: refs/heads/main@{#78019}
-
Maya Lekova authored
This is a reland of b9ddcbc8 The original CL was reverted due to an MSAN issue, that is fixed by moving the signature mapping onto the Isolate (instead of having per-thread storage, which got invalid on multithreaded compilation). This CL also contains fixes for the Bazel config and for a data race when obtaining the PerIsolateSimulatorData. Original change's description: > [fastcall] Enable float support on arm64 simulator > > This CL adds support for handling calls to C functions with arbitrary > signatures on the arm64 simulator. It adds infrastructure for > encoding the signature data from CallDescriptor and FunctionInfo > classes into a compact representation, stored in the simulator and > called EncodedCSignature. > > Design doc: > https://docs.google.com/document/d/1ZxOF3GSyNmtU0C0YJvrsydPJj35W_tTJZymeXwfDxoI/edit > > This CL is a follow up on the native support added in > https://chromium-review.googlesource.com/c/v8/v8/+/3182232 > and is partially based on the previous attempt: > https://chromium-review.googlesource.com/c/v8/v8/+/2343072 > > Bug: chromium:1052746 > Change-Id: I0991b47bd644b2fc2244c5eb923b085261f04765 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3060486 > Commit-Queue: Maya Lekova <mslekova@chromium.org> > Reviewed-by: Camillo Bruni <cbruni@chromium.org> > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Cr-Commit-Position: refs/heads/main@{#77744} Bug: chromium:1052746, chromium:1267854 Change-Id: I89bbd01e33fb1080543d98bcfd4c2d17b5c76861 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3270541Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Commit-Queue: Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/main@{#78018}
-