- 18 Aug, 2021 5 commits
-
-
Jakob Gruber authored
In follow-up work, the parser will be refactored to take the input as raw char arrays instead of a FlatStringReader s.t. it can be reused by the V8 parser (which has AstRawStrings instead of Strings). Bug: v8:896 Change-Id: I0e0bda4b34bc23b8bc427ddf3f9516081c42bb8a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3099947Reviewed-by:
Patrick Thier <pthier@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/main@{#76359}
-
Shu-yu Guo authored
TBR=adamk@chromium.org Bug: v8:11852 Change-Id: Ifa42d8f15433ac2328a5852e1b16e9da423d798b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3101578Reviewed-by:
Shu-yu Guo <syg@chromium.org> Commit-Queue: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/main@{#76358}
-
v8-ci-autoroll-builder authored
Rolling v8/third_party/google_benchmark/src: https://chromium.googlesource.com/external/github.com/google/benchmark/+log/2d054b6..990299f install docs folder when installing library (#1212) (Dominic Hamon) https://chromium.googlesource.com/external/github.com/google/benchmark/+/990299f add .DS_Store to .gitignore (Dominic Hamon) https://chromium.googlesource.com/external/github.com/google/benchmark/+/91ce110 refactor the documentation to minimise `README.md` (#1211) (Dominic Hamon) https://chromium.googlesource.com/external/github.com/google/benchmark/+/201b981 TBR=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com,mlippautz@chromium.org Change-Id: Idf8867d550ac0eccb330b6275fd9911f4cc859a6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3102598Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#76357}
-
Shu-yu Guo authored
These tests test allocation failure and time out on MSAN. TBR=adamk@chromium.org Bug: v8:11852 Change-Id: Ie0b042ab6bc37028c41a4b12d4911aba7f9af375 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3101574Reviewed-by:
-
Shu-yu Guo authored
Bug: v8:11852 Change-Id: I1d3c01b827e847bb7edcd2ebe7d3b340f7d53069 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3097473 Auto-Submit: Shu-yu Guo <syg@chromium.org> Commit-Queue: Adam Klein <adamk@chromium.org> Reviewed-by:
Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/main@{#76355}
-
- 17 Aug, 2021 25 commits
-
-
Ng Zhi An authored
We snapshot all the code first, then log it without holding the lock. Change-Id: I8c18b2db56678a9320ea6b63cd06290453c0a66a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3097472 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/main@{#76354}
-
Ng Zhi An authored
Change i16x8.splat to use Punpcklqdq instead of Pshufd as the final step to move low 32 bits to all lanes. Move this implementation to shared-macro-assembler and use it everywhere. Bug: v8:11589,v8:12090 Change-Id: I968b1dca5a262e4e67875caea18c5c09828cb33a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3092558 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/heads/main@{#76353}
-
Ng Zhi An authored
The optimal implementation is in TurboFan x64 codegen, move it into shared-macro-assembler, and have TurboFan ia32 and Liftoff use it. The optimal implementation accounts for AVX2 support. We add a couple of AVX2 instruction to ia32 in sse-instr.h, not all of them are used, but follow-up patches will use them, so we add support (including diassembly and test) in this change. Drive-by clean up to test-disasm-x64.cc to merge 2 AVX2 test sections. Bug: v8:11589 Change-Id: I1c8d7deb0f8bb70b29e7a680e5dbcfb09ca5505b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3092555Reviewed-by:
-
Josip Sokcevic authored
Cr-Commit-Position: refs/heads/main@{#76351} -
Frank Tang authored
The old implementation had an implicit assumption that IsolateData::builtin_entry_table_offset is a uint12, i.e. <4096. We're about to cross that threshold, so this patch frees up a temp register to let the code generator handle larger offsets. Bug: v8:12110 Change-Id: I2c313918be4b1c4fdd2984259e5e8cc02bb24035 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3097108Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#76350}
-
Milad Fa authored
Port 1821aff2 Original Commit Message: Since we can just use the lower bits, we can make the compressions no-ops. As a note, they still change the representation so that the machine graph verifier is happy. X64's version of: https://chromium-review.googlesource.com/c/v8/v8/+/1751722 R=solanes@chromium.org, joransiu@ca.ibm.com, junyan@redhat.com, midawson@redhat.com BUG= LOG=N Change-Id: I414fa30a17e5af4fa5b3e84b1b321d890431f27e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3100587Reviewed-by:
Junliang Yan <junyan@redhat.com> Commit-Queue: Milad Fa <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/master@{#76349}
-
Samuel Groß authored
ArrayBuffer backing stores will instead use the virtual memory cage and be referenced through offsets rather than pointers when the sandbox is enabled. This will be implemented in an independent CL. Bug: v8:10391 Change-Id: Icc9781003e53c76dbbf4c84ee165151e4182da4b Cq-Include-Trybots: luci.v8.try:v8_linux64_heap_sandbox_dbg_ng Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3086458Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Commit-Queue: Samuel Groß <saelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#76348}
-
Leszek Swirski authored
The API doesn't forbid passing in a "no cache reason" even when there's a cache. Change-Id: I4392bd9707333e8bc39129de72de753d88265c5c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3099950Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#76347}
-
Michael Lippautz authored
Bug: chromium:1056170 Change-Id: I71375a2ac8f4ac51de8b6c1899f7f146e4f107ec Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3099949 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Omer Katz <omerkatz@chromium.org> Auto-Submit: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#76346}
-
Al Muthanna Athamina authored
Bug: v8:11826 Change-Id: I30a582351305e1548948086709fc9ba0b0a91bd8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3069286Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Liviu Rau <liviurau@chromium.org> Commit-Queue: Almothana Athamneh <almuthanna@chromium.org> Cr-Commit-Position: refs/heads/master@{#76345}
-
Clemens Backes authored
{NativeModule::AddCode} is a central method that should usually be called in batches, where the caller holds a {CodeSpaceWriteScope} for a longer time (over several compilations). This CL moves us closer to that by removing the scope from that central method and instead putting it in callers where it becomes more visible. There are already TODOs to introduce caching or batching to avoid some switching, and one more TODO is added. Drive-by: Remove an unneeded {CodeSpaceMemoryModificationScope}. R=jkummerow@chromium.org Bug: v8:11974 Change-Id: Ia13c601abc766e5fca6ca053bf1fc4d647b53ed0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3098186Reviewed-by: -
Georg Neis authored
Don't create DataField and FastDataConstant access infos with a kNone field representation. Instead return Invalid. Bug: chromium:1239601 Change-Id: I4df7aa298974f9dcd650ead50aaa349c84feb487 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3097463Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#76343}
-
Samuel Groß authored
Changing the protections of a kNoAccess region to something different can fail due to OOM. We should handle this properly. Bug: chromium:1240062 Change-Id: I35e8837a57d66930390067eb0d1ab4bc76709948 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3099685Reviewed-by:
-
♥ Leszek Swirski authoredMake off-thread deserialization play well with the Isolate compilation cache, by moving the Finish call into GetSharedFunctionInfoForScript. This means that a) The isolate cache is checked before the Finish, allowing it to be hit, and b) Results of off-thread deserializations are written into the Isolate cache. Bug: chromium:1075999 Change-Id: I535935180bbe77f3e718253830e649bd62857634 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3094006 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by: -
Ilja Iskovs authored
This is a reland of 2261e053 This patch can now be relanded as some space was made for more opcodes: https://bugs.chromium.org/p/v8/issues/detail?id=12093 Original change's description: > [arm64][wasm] Use NEON S/Usra for Wasm SIMD add(shr(x, imm), y) > > A single AArch64 SIMD signed/unsigned Shift Right and Accumulate can be > used to implement Wasm SIMD add(shr(x, imm), y). This gives a 1-1.5% > improvement on some compute intensive Wasm benchmarks on Neoverse-N1. > > Mla and Adalp optimisations were refactored to match the style of the > added code. > > Change-Id: Id5959a31ca267e02b7d60e7ff6f942adb029b41e > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3089157 > Reviewed-by: Zhi An Ng <zhin@chromium.org> > Commit-Queue: Martyn Capewell <martyn.capewell@arm.com> > Cr-Commit-Position: refs/heads/master@{#76280} Change-Id: Idd166b7d3c960af33049bbce6e7276763c28f286 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3097284 Commit-Queue: Martyn Capewell <martyn.capewell@arm.com> Reviewed-by:
Zhi An Ng <zhin@chromium.org> Reviewed-by:
-
Camillo Bruni authored
Drive-by-fix: Use switch statement in AsyncHooks::PromiseHookDispatch Bug: chromium:1239907 Change-Id: I882956bfed92b56e1e8d885bdc68e205dd80c135 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3097882Reviewed-by:
Maya Lekova <mslekova@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#76339}
-
Georg Neis authored
The validation was too strong in the case where the incrementation produces type None. Bug: chromium:1236716 Change-Id: I948b370594fa7dad1ba6e5b951f473855bf1346b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3097865Reviewed-by:
Nico Hartmann <nicohartmann@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#76338}
-
Camillo Bruni authored
Bug: v8:12060 Change-Id: Ie78329cd6e9f8b19e3be0ccc0c14ae4a1995fb9d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3098189Reviewed-by:
Victor Gomes <victorgomes@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#76337}
-
Georg Neis authored
Bug: v8:12111 Change-Id: Iaee1f4273c9e7f273bd76ffba5fc60d7507a833d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3097450Reviewed-by:
-
Camillo Bruni authored
- Use early return - Add exception_string read-only root Change-Id: Iba935a4a0308d21ced2693047fdf217b7f9e62f4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3097884Reviewed-by:
-
Georg Neis authored
Namely: %kDisableOptimizationFinalization %WaitForBackgroundOptimization %kFinalizeOptimization Bug: v8:12091 Change-Id: Iea6c5e1d0c88b62fd02b240b20b0fca0fb79451f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3097878Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/a0d5191..536c882 Rolling v8/buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/6810b87..6f9b470 Rolling v8/third_party/aemu-linux-x64: kjigTwWNxlU1rn_26vpSH5hoVlSnC4w1rFJHyivz5PQC..JV2fBSeIQc_xaqKsVDvLIvDmvx2ejeL-Y75N37PloLMC Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/126f6a8..77a7089 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/0c42eff..c4e2b36 TBR=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: I798a7427a6708d38f65b675fffa6c9f6bc521553 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3098690Reviewed-by:
-
Frank Tang authored
Stage 3 proposal R4T: https://groups.google.com/a/chromium.org/g/blink-dev/c/e4Ict1TT9FE/m/aq69ne3rBAAJ I2S: https://groups.google.com/a/chromium.org/g/blink-dev/c/-6bANPdHR7c/m/netwFVfEAQAJ Spec: https://tc39.es/proposal-intl-extend-timezonename/ https://chromestatus.com/guide/edit/4506375298220032 LGTM1:bratell.d@gmail.com LGTM2:chrishtr@chromium.org LGTM3:tkent@chromium.org Bug: v8:11661 Change-Id: I1e92ac473dd42f6238feebe9ac8dad6be96ac210 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3088518 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
-
Yu Yin authored
Fix build failed with: is_component_build = true use_goma = true Change-Id: Ia06175c091e94e36aa71c134b056b4d6b88e5c96 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3098826Reviewed-by:
Ji Qiu <qiuji@iscas.ac.cn> Reviewed-by:
Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Commit-Queue: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Cr-Commit-Position: refs/heads/master@{#76331}
-
Frank Tang authored
Stage 3 proposal Spec: https://tc39.es/intl-displaynames-v2/ R2T: https://groups.google.com/a/chromium.org/g/blink-dev/c/XOJE7zVlxnI/m/cnkuazxHAwAJ I2S: https://groups.google.com/a/chromium.org/g/blink-dev/c/uld_YkbzL0Q/m/L7VjjNTDAQAJ Design Doc: https://docs.google.com/document/d/17hQz4nOC7PJYhxc_MU-BRoT6BnYGZv66XlU1iGX0ywQ LGTM1:bratell.d@gmail.com LGTM2:chrishtr@chromium.org LGTM3:tkent@chromium.org Bug: v8:11637 Change-Id: I555c5425ff5ee5854a43608aa56ee5399651408a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3087976Reviewed-by:
-
- 16 Aug, 2021 10 commits
-
-
Milad Fa authored
Change-Id: If641c8a4a466f6f9ea1dc9d8c15184fab17f52c7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3098008 Commit-Queue: Milad Fa <mfarazma@redhat.com> Reviewed-by:
-
Milad Fa authored
Change-Id: I6f0bdcedb55bc673ac7381ac94bca3e17e360e21 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3097449 Commit-Queue: Milad Fa <mfarazma@redhat.com> Reviewed-by:
-
Ng Zhi An authored
This is a reland of a3b2c4ec The fix is in PS3, for UBSan. We use WriteUnalignedValue for potentially unaligned memory writes. Original change's description: > [wasm][diagnostics] Support WasmCode in gdb JIT integration > > - Add new enum WASM_CODE to JitCodeEvent::CodeType > - Use AddressRegion instead of AddressRange (remove the latter) > - Change CodeDescription constructor to take an AddressRegion, > both JIT_CODE and WASM_CODE use this > - Add a simple mjsunit test that sets --gdbjit to check that > we don't crash. > - Add a api test for adding WASM_CODE > > Bug: v8:11908 > Change-Id: I6e87fadc2df67978144d78caf9800c3982bc3705 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3067754 > Reviewed-by: Adam Klein <adamk@chromium.org> > Reviewed-by: Clemens Backes <clemensb@chromium.org> > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> > Commit-Queue: Zhi An Ng <zhin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#76271} Bug: v8:11908 Change-Id: I5ded6d01cff40803b2f70525163f760edcf97165 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3093506Reviewed-by:
-
Jakob Kummerow authored
When the ToString Torque builtin has already found and called a `toString` or `valueOf` method on a JSReceiver, and still needs to call the runtime afterwards, it should do so with the result of that first step, as opposed to the original input. Fixed: v8:11689 Change-Id: I672249f9a6c230c3e61921b043f372c25a0178cf Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3097270Reviewed-by:
-
Michael Lippautz authored
Adds a heap verification GN arg to gate the marking verifier and live bytes verification on. The flag may be used in future for other more expensive checks as well. Currently, the flag is automatically enabled in dcheck_is_on and debug builds. The change enables live bytes verification for the library in regular debug builds which may flush out issues. Bug: v8:11785 Change-Id: I0f41bc0d76ebea9f6a8c9315c947598015ee5d68 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3097868 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
Junliang Yan authored
Change-Id: I1fec4575a84d22488fb6d572b302810655c78240 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3097811Reviewed-by:
Milad Fa <mfarazma@redhat.com> Commit-Queue: Junliang Yan <junyan@redhat.com> Cr-Commit-Position: refs/heads/master@{#76324}
-
Clemens Backes authored
This ensures that we have enough slack to land or merge important fixes (and temporarily coming closer to the limit). If the static assertion is ever violated, we should immediately create a tracking bug to free some opcode space. Temporarily reducing the required slack (16 in this CL) is OK then. R=zhin@chromium.org Bug: v8:12093 Change-Id: I0934061c38cefb713ae83ccc4d81791dc4b2d312 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3097281Reviewed-by:
-
Clemens Backes authored
This is a reland of e2016cf0. The fix is in PS2, with a comment why it is needed. Original change's description: > [d8] Use predictable platform if --predictable is passed > > We currently only use the predictable platform if --verify-predictable > is passed, which is confusing and not following the comment on the > --predictable flag ("enable predictable mode"). > > This CL fixes that and makes --verify-predictable imply --predictable to > also allow to only pass --verify-predictable. > > R=ahaas@chromium.org > CC=mlippautz@chromium.org > > Bug: v8:11879 > Change-Id: Ifb9683ddc4fab374ce519169533c90244175bb48 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3094010 > Reviewed-by: Andreas Haas <ahaas@chromium.org> > Commit-Queue: Clemens Backes <clemensb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#76305} Bug: v8:11879 Cq-Include-Trybots: luci.v8.try:v8_linux64_tsan_isolates_rel_ng Change-Id: I7bb7a6af722ee1cc447bc668385543dd72fd309b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3097867 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#76322}
-
Junliang Yan authored
Change-Id: I908854415c0d86d44f3b2b011c8b72df707421e5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3097810Reviewed-by:
-
Jakob Kummerow authored
In this particular case, a comment in the code provides sufficient protection against regressions. No-Try: true Fixed: v8:12087 Change-Id: If9cad800bcc822b7b5ab91669ccda8b4314009f7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3098185 Auto-Submit: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
-
