- 30 Sep, 2021 19 commits
-
-
Benedikt Meurer authored
Fixed: chromium:1073804 Change-Id: Ia8cd29323e2b1c4faa0f115b5f60bc216b7813f1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3196175 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Simon Zünd <szuend@chromium.org> Auto-Submit: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/main@{#77171}
-
Michael Lippautz authored
Minor MC does not support processing the specialized remembered set for ephemeron tables. Temporarily delegate to the regular write barrier for correctness until the other barrier is supported. Bug: v8:12262 Change-Id: Iad74b27f8738237dcc1e146b2df3aa6ed8c9a505 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3195895Reviewed-by:
Dominik Inführ <dinfuehr@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/main@{#77170}
-
Manos Koukoutos authored
Bug: v8:7748 Change-Id: Id6adc39af6818f5a37307f26cfe40de11a0ce3c2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3195872Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Cr-Commit-Position: refs/heads/main@{#77169}
-
Seth Brenith authored
This is a reland of 94958172 Original change's description: > [torque] Get rid of @noVerifier annotation > > As one small step toward reducing annotations, I propose that all > classes get generated verifiers unless they've opted out of C++ class > generation via @doNotGenerateCppClass, and that generated verifiers > always verify every Torque-defined field. If a generated verifier is > incorrect, such as for JSFunction or DataHandler, we can just avoid > calling it and hand-code the verification. > > Bug: v8:7793 > Change-Id: I7c0edb660574d0c688a59c7e90c41ee7ad464b42 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3171758 > Reviewed-by: Nico Hartmann <nicohartmann@chromium.org> > Commit-Queue: Seth Brenith <seth.brenith@microsoft.com> > Cr-Commit-Position: refs/heads/main@{#77145} Bug: v8:7793 Change-Id: I3da34705bf9fc2b1886161f8f59c7275583f7fc4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3194812 Commit-Queue: Seth Brenith <seth.brenith@microsoft.com> Reviewed-by:
Nico Hartmann <nicohartmann@chromium.org> Cr-Commit-Position: refs/heads/main@{#77168}
-
Clemens Backes authored
We currently could produce the error message 'not enough arguments on the stack for block, expected 0 more'. This CL fixes this by printing the available number of arguments and the needed number, and adds DCHECKs to catch similar miscomputations in the future. It also adds a new test that produced the broken error before, and includes the expected failure message in a few more tests for robustness. R=manoskouk@chromium.org Change-Id: Ia08863889ae36ae0a05d96d36e92295b7159a01e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3194264Reviewed-by:
Manos Koukoutos <manoskouk@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/main@{#77167}
-
Marja Hölttä authored
Bug: v8:12244, v8:12245 Change-Id: I46cc6fca7d4dda82c825ac15c97bba41ec61378a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3183347Reviewed-by:
Shu-yu Guo <syg@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/main@{#77166}
-
Al Muthanna Athamina authored
Bug: v8:11826 Change-Id: I5b7f64df8bf067d85cf89bc6c5e6a6804e6b2bc1 Cq-Include-Trybots: luci.v8.try:v8_numfuzz_dbg_ng,v8_numfuzz_ng,v8_numfuzz_tsan_ng Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3196130 Auto-Submit: Almothana Athamneh <almuthanna@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/main@{#77165}
-
Clemens Backes authored
The test allocates a lot of wasm memories. This got a low slower after https://crrev.com/c/3190476, because we can now allocate more than 102 memories, and do not explicitly trigger a GC any more to get rid of unused memories. We should figure out how to tell the GC about the external memory such that the memories get collected earlier. R=ahaas@chromium.org Bug: v8:12076, v8:12278 Change-Id: I9b8795a9999a806380d86f22e751de2727942648 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3196131Reviewed-by:
-
Omer Katz authored
Bug: chromium:1056170 Change-Id: I355187177d062bf7117bcbd402821f2b9dd739de Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3194267 Commit-Queue: Omer Katz <omerkatz@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/main@{#77163}
-
Omer Katz authored
Bug: chromium:1056170 Change-Id: I0876d1977694c50995a7b97145748bdb365289ad Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3194266 Commit-Queue: Omer Katz <omerkatz@chromium.org> Reviewed-by:
-
Clemens Backes authored
The address space limit puts an arbitrary cap on the total reservation size, thus limiting the total number of Wasm memories to around 100 on 64-bit systems. Since the usable address space on 64 bit is much larger than the 1TB+4GB limit, this makes us reject code that we could otherwise just execute. This CL thus removes that limit completely. See the linked issue for more discussion, including security considerations. R=jkummerow@chromium.org, rsesek@chromium.org Bug: v8:12076 Change-Id: I1f61511d68efdab1f8cef4e09c0a39fc1d6fed60 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3190476Reviewed-by:
-
Marja Hölttä authored
It's confusing that we have CSA_CHECK and CSA_ASSERT and it's not clear from the names that the former works in release mode and the latter only in debug mode. Renaming CSA_ASSERT to CSA_DCHECK makes it clear what it does. So now we have CSA_CHECK and CSA_DCHECK and they're not confusing. This also renames assert() in Torque to dcheck(). Bug: v8:12244 Change-Id: I6f25d431ebc6eec7ebe326b6b8ad3a0ac5e9a108 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3190104Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Reviewed-by:
-
Maya Lekova authored
This reverts commit 6e6385a0. Reason for revert: Breaks MSAN, see https://bugs.chromium.org/p/v8/issues/detail?id=12277 Original change's description: > Update V8 DEPS. > > Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/ecb990f..28fa03f > > Rolling v8/buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi/+log/50e90b8..31a3660 > > Rolling v8/third_party/aemu-linux-x64: e_KiIcYNB7sHa2eqRBhqVoR_Mmg2Q7nqmzRCXzegWQAC..pE8RqfOzLp5AXCDDOSrlKJ4MZInfuyxWzRSwdXBe1doC > > Rolling v8/third_party/android_platform: https://chromium.googlesource.com/chromium/src/third_party/android_platform/+log/6e5dc9a..7a11b79 > > Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/5afc365..01df326 > > Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/764c927..9c24aed > > Rolling v8/third_party/instrumented_libraries: https://chromium.googlesource.com/chromium/src/third_party/instrumented_libraries/+log/eb740e9..0aa3fcf > > TBR=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com > > Change-Id: If86099561baf7a927d6c5109790dad7b958208d0 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3194881 > Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> > Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/main@{#77153} Change-Id: I40135e9ed7adfcbfca054969c729aba5d8c9c91e No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3195713 Auto-Submit: Maya Lekova <mslekova@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Maya Lekova <mslekova@chromium.org> Owners-Override: Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/main@{#77159}
-
Jakob Gruber authored
Irregexp reentrancy (crrev.com/c/3162604) introduced a bug for global regexp execution in which each iteration would use a new stack region (i.e. we forgot to pop the regexp stack pointer when starting a new iteration). This CL fixes that by popping the stack pointer on the loop backedge. At a high level: - Initialize the backtrack_stackpointer earlier and avoid clobbering it by setup code. - Pop it on the loop backedge. - Slightly refactor Push/Pop operations to avoid unneeded memory accesses. Bug: v8:11382 Change-Id: Ibad6235767e110089a2b346034f923590b286a05 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3194251Reviewed-by:
Patrick Thier <pthier@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/main@{#77158}
-
Benedikt Meurer authored
The V8 Inspector was sending an additional frame as part of async stack traces for async functions, which pointed to the first executed `await` in the async function. This is leaking an implementation detail of how (and more precisely when) the inspector decides to collect this stack trace. From the users perspective the async part of the stack trace is supposed to capture what happened _prior to the task_ - meaning in case of async functions: What lead to the execution of the async function. This is reflected by the fact that the DevTools front-end (and the V8 Inspector itself) performs post-processing on these async call stacks, removing the misleading top frame from it. But this post-processing is not applied consistently to all async stack traces (i.e. the Console message stack traces don't get this), and potentially also not applied consistently across consumers of the Chromium debugger backend. Instead the V8 Inspector now removes the top frame itself and thus reports `await` consistently with how other async tasks are reported to debugger front-ends. Note: This preserves backwards compatibility with old versions of devtools-frontend, which do post-processing (for the Call Stack) only on async stack traces marked with "async function", while we now mark these async stack traces with "await" instead (aligned with what the front-end is using as user visibile string anyways in the Call Stack section, and this matching will be updated in a separate follow up CL to look for "await" instead of "async function"). Before: https://imgur.com/kIrWcIc.png After: https://imgur.com/HvZGqiP Fixed: chromium:1254259 Bug: chromium:1229662 Change-Id: I57ce051a28892177b6b96221f083ae957f967e52 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3193535 Auto-Submit: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
Kim-Anh Tran <kimanh@chromium.org> Cr-Commit-Position: refs/heads/main@{#77157}
-
Patrick Thier authored
Load instance type into a register instead of using memory operands for several checks on ia32 and x64. Drive-by: Name used registers in Generate_Call/Generate_Construct Change-Id: I289c5e420fa03ca639c9b78266560cafb166f6f7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3190099Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Commit-Queue: Patrick Thier <pthier@chromium.org> Cr-Commit-Position: refs/heads/main@{#77156}
-
Victor Gomes authored
It also updates the scripts to support Python3 Bug: chromium:1245634 Change-Id: Iffe29bacfd788575b35da6449d5830fc665da7a8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3194259 Commit-Queue: Victor Gomes <victorgomes@chromium.org> Reviewed-by:
-
Zhao Jiazhong authored
Due to MIPS64 ISA feature, 32-bit values should be sign-extended in 64-bit registers, no matter it's signed or unsigned. Besides, LoongArch64 also has this feature, and a similar change has been made before loong64 port's land in V8. This CL also make a small fix for loong64. Change-Id: Ib284662931082365f727925af61781e3653debc8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3193595Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/ecb990f..28fa03f Rolling v8/buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi/+log/50e90b8..31a3660 Rolling v8/third_party/aemu-linux-x64: e_KiIcYNB7sHa2eqRBhqVoR_Mmg2Q7nqmzRCXzegWQAC..pE8RqfOzLp5AXCDDOSrlKJ4MZInfuyxWzRSwdXBe1doC Rolling v8/third_party/android_platform: https://chromium.googlesource.com/chromium/src/third_party/android_platform/+log/6e5dc9a..7a11b79 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/5afc365..01df326 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/764c927..9c24aed Rolling v8/third_party/instrumented_libraries: https://chromium.googlesource.com/chromium/src/third_party/instrumented_libraries/+log/eb740e9..0aa3fcf TBR=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: If86099561baf7a927d6c5109790dad7b958208d0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3194881Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#77153}
-
- 29 Sep, 2021 19 commits
-
-
Seth Brenith authored
I'm trying to remove annotations and make behavior more consistent. For @generatePrint, there are two options: either generate printers for every extern class, or never generate printers for extern classes. This change implements the option of always generating printers. Classes that require custom printing can easily hide the generated printer by using DECL_PRINTER. This causes the generated file gen/torque-generated/objects-printer.cc to grow to 1600 lines, including many functions that are never used, but I think the consistency benefit outweighs a little more compilation time on one file. This change also removes custom printers in cases where the generated printer includes all of the same content. If folks would prefer the option to never generate printers, I'm open to doing that instead. I like the notion that generating more code could reduce the friction of adding new classes and thereby encourage people to define precise types rather than using FixedArrays, but the current implementation of generated printers is limited, and many printers have been customized to show the data that matters the most. Unlike verifiers and body descriptors, there are no correctness or safety concerns with hand-written printers. Some bugs showed up once we start generating printers for everything, and this change fixes them: - Printers incorrectly included ungettable fields like padding - Printers called getters which might be hidden by hand-written classes - The generated getter for Map::instance_type used ReadField<InstanceType>, which is not an arithmetic type since it's an enum One more tiny drive-by fix: added a missing newline in the printers for JSMap and JSSet. Bug: v8:7793 Change-Id: Ib9e9575fbcb57879935ff18bf4db49fe276d2966 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3172190Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Commit-Queue: Seth Brenith <seth.brenith@microsoft.com> Cr-Commit-Position: refs/heads/main@{#77152}
-
Seth Brenith authored
Nobody uses the generated *_FIELDS macros anymore, so we can remove them. I also renamed the generated file to represent its content better. Bug: v8:7793 Change-Id: I49ab39e363d6961e7210cd67018b6fb83b65a162 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3192191Reviewed-by:
-
Junliang Yan authored
Port edc349db Bug: v8:11235 Change-Id: I53538b1a18d778c4580683d300bc380ee1041c40 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3194874Reviewed-by:
Milad Fa <mfarazma@redhat.com> Commit-Queue: Junliang Yan <junyan@redhat.com> Cr-Commit-Position: refs/heads/main@{#77150}
-
Clemens Backes authored
This fixes a long-standing TODO to disallow importing receivers that have "toString" or "valueOf" patched. Calling those methods could have observable side effects, so allowing that would require bigger refactorings to ensure that we only call each such function exactly once per import, and in the right order. Since this use case is rare, we just forbid importing such receivers. R=jkummerow@chromium.org Bug: chromium:1248677 Change-Id: I99bbd7db950ec3c7ac9cc1f59e8c476688e7d7b6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3190475Reviewed-by:
-
Junliang Yan authored
Change-Id: Ida66b9c42cfb9bd5b59a83188a2dfa0d602d4036 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3192427Reviewed-by:
-
Milad Fa authored
Port: 1cd7a582 Original Commit Message: Class Constructors are special, because they are callable but [[Call]] raises an exception. Instead of checking if a JS function is a class constructor for every JS function call, this CL adds a new instance type for class constructors. This way we can use a fast instance type range check for the common case, and only check for class constructors in the uncommon case were a class constructor is called and when we need to raise an exception. Change-Id: I578fde90d00d1e80cf36ba28205ce9bfe6830afb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3192422Reviewed-by:
Junliang Yan <junyan@redhat.com> Commit-Queue: Milad Fa <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/main@{#77147}
-
Maya Lekova authored
This reverts commit 94958172. Reason for revert: Breaks arm/arm64 ports, e.g. https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Linux%20-%20arm64%20-%20sim/30120/blamelist Original change's description: > [torque] Get rid of @noVerifier annotation > > As one small step toward reducing annotations, I propose that all > classes get generated verifiers unless they've opted out of C++ class > generation via @doNotGenerateCppClass, and that generated verifiers > always verify every Torque-defined field. If a generated verifier is > incorrect, such as for JSFunction or DataHandler, we can just avoid > calling it and hand-code the verification. > > Bug: v8:7793 > Change-Id: I7c0edb660574d0c688a59c7e90c41ee7ad464b42 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3171758 > Reviewed-by: Nico Hartmann <nicohartmann@chromium.org> > Commit-Queue: Seth Brenith <seth.brenith@microsoft.com> > Cr-Commit-Position: refs/heads/main@{#77145} Bug: v8:7793 Change-Id: I56da8a9726d23470e927be1be5e7bcede1399861 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3194262 Auto-Submit: Maya Lekova <mslekova@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Seth Brenith <seth.brenith@microsoft.com> Owners-Override: Maya Lekova <mslekova@chromium.org> Reviewed-by:
Seth Brenith <seth.brenith@microsoft.com> Cr-Commit-Position: refs/heads/main@{#77146}
-
Seth Brenith authored
As one small step toward reducing annotations, I propose that all classes get generated verifiers unless they've opted out of C++ class generation via @doNotGenerateCppClass, and that generated verifiers always verify every Torque-defined field. If a generated verifier is incorrect, such as for JSFunction or DataHandler, we can just avoid calling it and hand-code the verification. Bug: v8:7793 Change-Id: I7c0edb660574d0c688a59c7e90c41ee7ad464b42 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3171758Reviewed-by:
-
Omer Katz authored
This is a reland of e47f9200 Relanding for clang only. GCC and MSVC will not inline. Original change's description: > cppgc: Inline allocation fast path across api boundary > > Bug: chromium:1239030, chromium:1056170 > Change-Id: I4a559027e63ebbd99e51344aa659d4fb284df88f > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3190094 > Commit-Queue: Omer Katz <omerkatz@chromium.org> > Reviewed-by: Anton Bikineev <bikineev@chromium.org> > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Cr-Commit-Position: refs/heads/main@{#77124} Bug: chromium:1239030, chromium:1056170 Change-Id: Iaa52118ea0e6ccd78f5e7818fa30ed163906da83 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3191211Reviewed-by:
-
Omer Katz authored
This is a reland of 2db50670 crrev.com/c/3182223 resolves all known issues (and should prevent additional issues in the future). Original change's description: > Reland "Reland "cppgc: Enable checks for assignments in prefinalizers"" > > This is a reland of adb6276f > > Causes for previous revert was addressed by crbug.com/3140387 and > crbug.com/3163579. > > Original change's description: > > Reland "cppgc: Enable checks for assignments in prefinalizers" > > > > This is a reland of edcc8ff5 > > > > Cause for previous revert was addressed by crbug.com/1241773. > > > > Original change's description: > > > cppgc: Enable checks for assignments in prefinalizers > > > > > > Bug: v8:11749 > > > Change-Id: Ic027f732030fb6a2befeffeca9db2eacfd0830a5 > > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3099953 > > > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > > > Commit-Queue: Omer Katz <omerkatz@chromium.org> > > > Cr-Commit-Position: refs/heads/main@{#76370} > > > > Bug: v8:11749 > > Change-Id: I57fc138ace002d41e54f7f70250e4d19bc9262b0 > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3122153 > > Auto-Submit: Omer Katz <omerkatz@chromium.org> > > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > > Commit-Queue: Omer Katz <omerkatz@chromium.org> > > Cr-Commit-Position: refs/heads/main@{#76553} > > Bug: v8:11749 > Change-Id: I138ca374314108f0f23e234a8fd90d15d912120d > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3168280 > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Commit-Queue: Omer Katz <omerkatz@chromium.org> > Cr-Commit-Position: refs/heads/main@{#76971} Bug: v8:11749 Change-Id: I8bf48cecde910e74f40cf0cd6aa8a5ed19de1584 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3182224Reviewed-by:
-
Al Muthanna Athamina authored
Remove infra-staging from numfuzz builders and add no-fail instead. Also remove the staging builders. Bug: v8:11826 Cq-Include-Trybots: luci.v8.try:v8_numfuzz_dbg_ng,v8_numfuzz_ng,v8_numfuzz_tsan_ng Change-Id: Icd7bc6275b5c78e38f0e75b5d133b3b7056f333e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3182233 Commit-Queue: Almothana Athamneh <almuthanna@chromium.org> Reviewed-by:
-
Junliang Yan authored
Change-Id: I23f5a67a347c586fb26b99fd71fca8ea03cd83a4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3194258Reviewed-by:
-
Patrick Thier authored
Class Constructors are special, because they are callable but [[Call]] raises an exception. Instead of checking if a JS function is a class constructor for every JS function call, this CL adds a new instance type for class constructors. This way we can use a fast instance type range check for the common case, and only check for class constructors in the uncommon case were a class constructor is called and when we need to raise an exception. Change-Id: Ic6fdd9829722d05559fdfd01f6100c61873a0872 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3186434Reviewed-by:
-
Michael Lippautz authored
During a final atomic pause CrossThreadPersistent handles need to be frozen after they have been marked to avoid any WeakCrossThreadPersistent handles creating new strong references (through their Lock() call) that would retain objects. Handles are frozen by acquiring a lock. Since this lock is also taking by other threads on WCTP::Lock() this can introduce jank. This CL improves the situation by delaying processing of CTP references until absolutely necessary, i.e., when we have otherwise no more objects to mark. Bug: chromium:1252743 Change-Id: I872f38c6d24d7955bea74fd59685abd3019b385e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3194253Reviewed-by:
Omer Katz <omerkatz@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/main@{#77139}
-
Jakob Gruber authored
.. and refactor js-regexp.h. - Hide the generic DataAt/SetDataAt accessors and replace them by dedicated accessors. Use the common lower_case naming scheme for these. - Shuffle around definitions in js-regexp.h s.t. they are in a meaningful order. - Dedupe the source/flags accessors - these fields are stored both on the instance and on the data array. We keep only accessors for the instance. Previously, these were disambiguated through naming oddities (e.g. Pattern() returned data->source). Change-Id: I3d53c8b095f0d59621ff779608438f7fa5e8c92a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3193534 Auto-Submit: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Maya Lekova <mslekova@chromium.org> Reviewed-by:
-
Georg Neis authored
Bug: v8:7790 Change-Id: I5439fa0a8ecfab8f407e2aeeaffd4b4f656cdfe1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3192674 Commit-Queue: Georg Neis <neis@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Auto-Submit: Georg Neis <neis@chromium.org> Reviewed-by:
-
Lu Yahan authored
Change-Id: Ieb986b9e17103ec24ca98a7ab44e7bef9caa6bfa Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3194013Reviewed-by:
ji qiu <qiuji@iscas.ac.cn> Commit-Queue: ji qiu <qiuji@iscas.ac.cn> Cr-Commit-Position: refs/heads/main@{#77136}
-
Jakob Gruber authored
This is a reland of 7d849870 Original change's description: > [regexp] Reorganize and deduplicate in the regexp parser > > The parser is organized in a somewhat tricky way s.t. it can be > hard to map the implementation back to the specified grammar. > > In particular, the logic for CharacterClassEscape, ClassEscape, > and CharacterEscape was implemented twice - once inside a character > class, once outside. > > This CL refactors related logic to have only a single implementation. > > As a drive-by, fix one related inconsistency related to \k inside > a character class. > > Fixed: v8:10602 > Change-Id: I5858840159694fa6f8d1aa857027db80754e3dfd > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3178966 > Reviewed-by: Mathias Bynens <mathias@chromium.org> > Commit-Queue: Jakob Gruber <jgruber@chromium.org> > Cr-Commit-Position: refs/heads/main@{#77114} Fixed: v8:10602,chromium:1253976 Change-Id: I9e7cc6a34d3be06e1a68895775aa50b0eee78c57 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3193531Reviewed-by:
Mathias Bynens <mathias@chromium.org> Commit-Queue: Mathias Bynens <mathias@chromium.org> Auto-Submit: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/main@{#77135}
-
v8-ci-autoroll-builder authored
Rolling v8/base/trace_event/common: https://chromium.googlesource.com/chromium/src/base/trace_event/common/+log/715537d..68d8169 Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/a76920d..ecb990f Rolling v8/third_party/aemu-linux-x64: 6Vr4alb5803W2n5PbA5ZLwCcJznKdmFX1pDoy_5hfOAC..e_KiIcYNB7sHa2eqRBhqVoR_Mmg2Q7nqmzRCXzegWQAC Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/2146b04..5afc365 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/ce514ad..764c927 Rolling v8/third_party/googletest/src: https://chromium.googlesource.com/external/github.com/google/googletest/+log/e4717df..ab36804 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/2e80143..278dd91 Rolling v8/tools/luci-go: git_revision:e9585787c808e21d6eaa2c7d7a928dbc19999172..git_revision:a373a19da0fbbbe81b2b684e3797260294393e40 Rolling v8/tools/luci-go: git_revision:e9585787c808e21d6eaa2c7d7a928dbc19999172..git_revision:a373a19da0fbbbe81b2b684e3797260294393e40 Rolling v8/tools/luci-go: git_revision:e9585787c808e21d6eaa2c7d7a928dbc19999172..git_revision:a373a19da0fbbbe81b2b684e3797260294393e40 TBR=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: I4765817d9f51dd6f7d9a600799098134eee1a8fb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3192297Reviewed-by:
-
- 28 Sep, 2021 2 commits
-
-
Zhi An Ng authored
This reverts commit 649e9113. Reason for revert: Abseil was reverted due to gcc failures, so reverting this first. When upstream fixes land, we can reland abseil and this change. Original change's description: > [bazel] Adds support to abseil > > No-Try: true > Bug: v8:11006 > Change-Id: Ie2758849fcb8b19ae34289d3e762094b062f2a5c > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3168644 > Reviewed-by: Dan Elphick <delphick@chromium.org> > Commit-Queue: Victor Gomes <victorgomes@chromium.org> > Cr-Commit-Position: refs/heads/main@{#76938} Bug: v8:11006 Change-Id: Iedde555df8bc736cf922b0d9f51b0a78f7e1db49 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3192192 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/main@{#77133}
-
Ng Zhi An authored
This reverts commit 214ef26d. Reason for revert: gcc bots are failing https://crbug.com/v8/12248 Original change's description: > Reland "[DEPS] Add abseil to deps" > > This is a reland of 3c49308a > > Original change's description: > > [DEPS] Add abseil to deps > > > > Add a dependency on the chromium abseil-cpp subdir mirror. > > > > Bug: v8:11006 > > Change-Id: Icaad757269d27c65bc368ed539f84c5bb79ee62d > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2464940 > > Commit-Queue: Leszek Swirski <leszeks@chromium.org> > > Reviewed-by: Yang Guo <yangguo@chromium.org> > > Reviewed-by: Victor Gomes <victorgomes@chromium.org> > > Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#70786} > > Bug: v8:11006 > Change-Id: I2befd2eadd11d485eee47c68119d93be9a3e1655 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2504257 > Commit-Queue: Leszek Swirski <leszeks@chromium.org> > Reviewed-by: Adam Klein <adamk@chromium.org> > Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> > Reviewed-by: Yang Guo <yangguo@chromium.org> > Reviewed-by: Hannes Payer <hpayer@chromium.org> > Reviewed-by: Victor Gomes <victorgomes@chromium.org> > Cr-Commit-Position: refs/heads/main@{#76897} Bug: v8:11006 Change-Id: Icdc7ed108a49fa33a0233a1af8ba8e4d9daadfd8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3191392Reviewed-by:
Adam Klein <adamk@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/main@{#77132}
-
