Commit 67601ba9 authored by Ng Zhi An's avatar Ng Zhi An Committed by V8 LUCI CQ

Revert "Reland "[DEPS] Add abseil to deps""

This reverts commit 214ef26d.

Reason for revert: gcc bots are failing https://crbug.com/v8/12248

Original change's description:
> Reland "[DEPS] Add abseil to deps"
>
> This is a reland of 3c49308a
>
> Original change's description:
> > [DEPS] Add abseil to deps
> >
> > Add a dependency on the chromium abseil-cpp subdir mirror.
> >
> > Bug: v8:11006
> > Change-Id: Icaad757269d27c65bc368ed539f84c5bb79ee62d
> > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2464940
> > Commit-Queue: Leszek Swirski <leszeks@chromium.org>
> > Reviewed-by: Yang Guo <yangguo@chromium.org>
> > Reviewed-by: Victor Gomes <victorgomes@chromium.org>
> > Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#70786}
>
> Bug: v8:11006
> Change-Id: I2befd2eadd11d485eee47c68119d93be9a3e1655
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2504257
> Commit-Queue: Leszek Swirski <leszeks@chromium.org>
> Reviewed-by: Adam Klein <adamk@chromium.org>
> Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
> Reviewed-by: Yang Guo <yangguo@chromium.org>
> Reviewed-by: Hannes Payer <hpayer@chromium.org>
> Reviewed-by: Victor Gomes <victorgomes@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#76897}

Bug: v8:11006
Change-Id: Icdc7ed108a49fa33a0233a1af8ba8e4d9daadfd8
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3191392Reviewed-by: 's avatarAdam Klein <adamk@chromium.org>
Commit-Queue: Zhi An Ng <zhin@chromium.org>
Cr-Commit-Position: refs/heads/main@{#77132}
parent 1054ee7f
......@@ -1783,15 +1783,6 @@ group("v8_maybe_icu") {
}
}
group("v8_abseil") {
public_deps = [ "//third_party/abseil-cpp:absl" ]
public_configs = [
"//third_party/abseil-cpp:absl_define_config",
"//third_party/abseil-cpp:absl_include_config",
]
}
v8_header_set("torque_runtime_support") {
visibility = [ ":*" ]
......@@ -1812,7 +1803,6 @@ v8_source_set("torque_generated_initializers") {
public_deps = [
":torque_runtime_support",
":v8_abseil",
":v8_maybe_icu",
]
......@@ -1844,10 +1834,7 @@ v8_source_set("torque_generated_definitions") {
":v8_tracing",
]
public_deps = [
":v8_abseil",
":v8_maybe_icu",
]
public_deps = [ ":v8_maybe_icu" ]
sources = [
"$target_gen_dir/torque-generated/class-forward-declarations.h",
......@@ -2131,10 +2118,7 @@ v8_source_set("v8_snapshot") {
# Also top-level visibility targets can depend on this.
visibility += [ "//:gn_visibility" ]
public_deps += [
":v8_abseil",
":v8_maybe_icu",
]
public_deps += [ ":v8_maybe_icu" ]
sources += [ "$target_gen_dir/snapshot.cc" ]
}
......@@ -2312,10 +2296,7 @@ v8_source_set("v8_init") {
"src/init/setup-isolate-full.cc",
]
public_deps = [
":v8_abseil",
":v8_maybe_icu",
]
public_deps = [ ":v8_maybe_icu" ]
configs = [ ":internal_config" ]
}
......@@ -3760,7 +3741,6 @@ v8_source_set("v8_compiler_opt") {
public_deps = [
":generate_bytecode_builtins_list",
":run_torque",
":v8_abseil",
":v8_maybe_icu",
":v8_tracing",
]
......@@ -3793,7 +3773,6 @@ v8_source_set("v8_compiler") {
public_deps = [
":generate_bytecode_builtins_list",
":run_torque",
":v8_abseil",
":v8_internal_headers",
":v8_maybe_icu",
":v8_tracing",
......@@ -4603,7 +4582,6 @@ v8_source_set("v8_base_without_compiler") {
":cppgc_base",
":generate_bytecode_builtins_list",
":run_torque",
":v8_abseil",
":v8_headers",
":v8_internal_headers",
":v8_maybe_icu",
......@@ -6133,10 +6111,7 @@ if (v8_enable_webassembly) {
":v8_tracing",
]
public_deps = [
":v8_abseil",
":v8_maybe_icu",
]
public_deps = [ ":v8_maybe_icu" ]
configs = [
":external_config",
......@@ -6216,10 +6191,7 @@ if (v8_enable_webassembly) {
":wasm_test_common",
]
public_deps = [
":v8_abseil",
":v8_maybe_icu",
]
public_deps = [ ":v8_maybe_icu" ]
configs = [
":external_config",
......
......@@ -48,9 +48,6 @@ vars = {
# reclient CIPD package version
'reclient_version': 're_client_version:0.40.0.40ff5a5',
# This variable is overrided in Chromium's DEPS file.
'build_with_chromium': False,
# GN CIPD package version.
'gn_version': 'git_revision:0153d369bbccc908f4da4993b1ba82728055926a',
......@@ -317,10 +314,6 @@ deps = {
'condition': 'host_cpu != "s390" and host_os != "aix"',
'dep_type': 'cipd',
},
'third_party/abseil-cpp': {
'url': Var('chromium_url') + '/chromium/src/third_party/abseil-cpp.git' + '@' + '8aecb680df5a6758cf5eba7d5acc5dbaf6df11aa',
'condition': 'not build_with_chromium',
}
}
include_rules = [
......
......@@ -95,7 +95,6 @@ v8_component("v8_debug_helper") {
":gen_heap_constants",
"../..:generate_bytecode_builtins_list",
"../..:run_torque",
"../..:v8_abseil",
"../..:v8_headers",
"../..:v8_internal_headers",
"../..:v8_libbase",
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment