- 02 Dec, 2020 8 commits
-
-
Sathya Gunasekaran authored
This reverts commit e2aa734a. Reason for revert: speculative revert for https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Mac64%20-%20debug/31901/blamelist Original change's description: > [wasm-simd][arm] Prototype i8x16.popcnt > > Bug: v8:11002 > Change-Id: Ib97e51ed52249a1af7a4b879396b70a016991719 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2567534 > Commit-Queue: Zhi An Ng <zhin@chromium.org> > Reviewed-by: Bill Budge <bbudge@chromium.org> > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> > Cr-Commit-Position: refs/heads/master@{#71552} TBR=bbudge@chromium.org,jkummerow@chromium.org,v8-arm-ports@googlegroups.com,zhin@chromium.org Change-Id: Id1ae2dbaae52d45eb81ba8636178236ca8e9f7e0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:11002 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2568925Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#71554}
-
Jakob Gruber authored
This reverts commit 3599cce1. Originally landed in https://chromium-review.googlesource.com/c/v8/v8/+/2531775 Work on NCI is suspended, remove unused complexity. We may want to share native-context-independent feedback in the future, but probably through other means. Bug: v8:8888 Change-Id: I23dfb67f6f01b4891af87bc42a9e62f99d0bf044 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2567701Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Mythri Alle <mythria@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#71553}
-
Zhi An Ng authored
Bug: v8:11002 Change-Id: Ib97e51ed52249a1af7a4b879396b70a016991719 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2567534 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#71552}
-
Zhi An Ng authored
Prototype v128.{load,store}{8,16,32,64}_lane on arm64. All the required assembler, disassembler, and simulator changes are already available. The biggest changes here are in the instruction-selector. ld1 and st1 only supports no-offset or post-index addressing, so we have to do our own addition (base + index) to construction the actual memory address to load/store from. Bug: v8:10975 Change-Id: I026e3075003ff5dece7cd1a590894b09e2e823db Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2558268 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by: -
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/b031112..6ca160d Rolling v8/third_party/aemu-linux-x64: jfuzh1KU9b_qTmPrfQ2v7GW8FB2tUz0uUUjeyB_2LdQC..DQxYsB8PVOoG7iQxYf01AM0DSgvbu3DKEyrTvcT79zAC Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/6d2a0fe..80cea4f Rolling v8/tools/swarming_client: https://chromium.googlesource.com/infra/luci/client-py/+log/d46ea76..1a07271 TBR=machenbach@chromium.org,tmrts@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I844e9927c1ace1820c2af0da886e0f33d53f2c6d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2568501Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#71550}
-
Zhi An Ng authored
Bug: v8:11215 Change-Id: If6e9cb252176230815c7509ecf2a6e3e2269e601 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2567532Reviewed-by:
-
Zhi An Ng authored
Bug: v8:11074 Change-Id: I26969322948c1d062b1bc5478f547d52cba3f1b9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2567312Reviewed-by:
Dominik Inführ <dinfuehr@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#71548}
-
Zhi An Ng authored
This is a reland of a69b7ef2 Original change's description: > [wasm-simd][ia32] Prototype store lane > > Prototype v128.store{8,16,32,64}_lane on IA32. > > Drive by fix for wrong disassembly of movlps. > > Also added more test cases for StoreLane, test for more alignment and offset. > > Bug: v8:10975 > Change-Id: I0e16f1b5be824b6fc818d02d0fd84ebc0dff4174 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2557068 > Commit-Queue: Zhi An Ng <zhin@chromium.org> > Reviewed-by: Bill Budge <bbudge@chromium.org> > Cr-Commit-Position: refs/heads/master@{#71511} Bug: v8:10975 Change-Id: I2c9b219b9ab9d78a83d1bf32ad1271d717471c19 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2567317Reviewed-by:
-
- 01 Dec, 2020 32 commits
-
-
Andreas Haas authored
ReduceCompilationPriority takes a lock now. Original message: This Cl changes the priority of baseline compilation from kUserVisible to kUserBlocking. Once baseline compilation finishes, the priority is reduced to kUserVisible. The reason for using kUserBlocking is that thereby TurboFan compilation cannot block Liftoff compilation anymore. Additionally, kUserBlocking is quite appropriate, as the initial compilation does block a whole section of a web app from execution. R=clemensb@chromium.org Bug: v8:11088 Cq-Include-Trybots: luci.v8.try:v8_linux64_tsan_rel_ng Cq-Include-Trybots: luci.v8.try:v8_linux64_tsan_isolates_rel_ng Change-Id: I6e1bcc809148198a4b4f88bfd4f2e62b1b061439 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2563675 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#71546}
-
Ross McIlroy authored
In order to reduce the codegen size of dynamic map checks, add the ability to have an eager with resume deopt point, which can call a given builitin to perform a more detailed check than can be done in codegen, and then either deoptimizes itself (as if the calling code had performed an eager deopt) or resumes execution in the calling code after the check. In addition, support for adding extra arguments to a deoptimization continuation is added to enable us to pass the necessary arguments to the DynamicMapChecks builtin. Finally, a trampoline is added to the DynamicMapChecks which saves the registers that might be clobbered by that builtin, to avoid having to save them in the generated code. This trampoline also performs the deoptimization based on the result of the DynamicMapChecks builtin. In order to ensure both the trampoline and DynamicMapChecks builtin have the same call interface, and to limit the number of registers that need saving in the trampoline, the DynamicMapChecks builtin is moved to be a CSA builtin with a custom CallInterfaceDescriptor, that calls an exported Torque macro that implements the actual functionality. All told, this changes the codegen for a monomorphic dynamic map check from: movl rbx,<expected_map> cmpl [<object>-0x1],rbx jnz <deferred_call> resume_point: ... deferred_call: <spill registers> movl rax,<slot> movq rbx,<object> movq rcx,<handler> movq r10,<DynamicMapChecks> call r10 cmpq rax,0x0 jz <restore_regs> cmpq rax,0x1 jz <deopt_point_1> cmpq rax,0x2 jz <deopt_point_2> int3l restore_regs: <restore_regs> jmp <resume_point> ... deopt_point_1: call Deoptimization_Eager deopt_point_2: call Deoptimization_Bailout To: movl rax,<slot> movl rcx,<expected_map> movq rdx,<handler> cmpl [<object>-0x1],rcx jnz <deopt_point> resume_point: ... deopt_point: call DynamicMapChecksTrampoline jmp <resume_point> BUG=v8:10582 Change-Id: Ica4927b9acc963b9b73dc62d9379a7815335650f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2560197 Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:Georg Neis <neis@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#71545}
-
Michael Achenbach authored
Follow up on renamed configurations, porting: https://crrev.com/c/2565170 TBR=gsathya@chromium.org Bug: v8:10619,chromium:1097270 Change-Id: Ibfeb6ee817642b16d79e673b2d91d4142a2b6cd4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2566761Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#71544}
-
Milad Fa authored
In this CL we fix the emitted code for Load Splat and Load Extend. Load Splat loads a byte, half word, word or double word based on the specific opcode. Load Extend always loads a double word and then unpacks it accordingly. Change-Id: Ic1619c81a58f4997d69612f08edb6975d17e8bb3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2568132Reviewed-by:
Junliang Yan <junyan@redhat.com> Commit-Queue: Milad Fa <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/master@{#71543}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/4fd0dec..b031112 TBR=machenbach@chromium.org,tmrts@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ic9a9082919cc7de8c816c33dcc62d219440a342c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2567562Reviewed-by:
-
Camillo Bruni authored
This CL extends the existing optimization markers: - "~" for interpreted code - "-" for native context independent code (new) - "+" for turboprop code (new) - "*" for turbofan code Bug: v8:10644 Change-Id: If8940a8c3f32c6f347f61a901be101078df66331 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2567693 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
-
Sathya Gunasekaran authored
Bug: v8:10644 Change-Id: I8c81e1f9d6f1f766af07905928ea7b437771e1ef Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2567201Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#71540}
-
Manos Koukoutos authored
This is a reland of 535fd785. This CL was not the culprit, thus landing unmodified. Original change's description: > [wasm] Make DecodeLocals return the number of decoded locals > > Currently, when the new locals are not appended to the existing ones, > there is no way to know how many new locals were defined. This CL > addresses this issue. > > Drive-by: Fix the pc passed to DecodeLocals in OpcodeLength. > Change-Id: Id9de561a6380b52dcce398301727aa12196c0677 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2567695 > Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> > Reviewed-by: Clemens Backes <clemensb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#71526} TBR=manoskouk@chromium.org Change-Id: I1b2fbe9f6d0a19da9d73202de9f488870e79cd30 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2567704Reviewed-by:
-
Michael Achenbach authored
This is a reland of 4ad08c82 The reland organizes the different error types in separate functions for separate call stacks. Error simulation is also guarded by a minimum file size to prevent Clusterfuzz from getting stuck with its bad-build check. Original change's description: > Enable simulating errors to test fuzzer reliability > > This adds a d8 flag --simulate-errors, which on shutdown will cause > certain errors. This enables testing the reliability of sanitizers. > > This will cause a fatal error, a dcheck (if available) or a > violation that can be detected with one of the following sanitizers: > ASAN, UBSAN, MSAN, CFI. > > The same flag used in differential fuzzing will cause an error > subsumed with the error state "fake_difference". > > Bug: chromium:1152412 > Change-Id: I4b36c6fe716797004d634263617d22ca67b05600 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2554999 > Commit-Queue: Michael Achenbach <machenbach@chromium.org> > Reviewed-by: Clemens Backes <clemensb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#71430} Bug: chromium:1152412 Change-Id: I604258b4c1ebd215c26b1de6b2822663f857bf64 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2565125 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
-
Clemens Backes authored
The wasm fuzzer corpus is pretty outdated. The script that was used to generate it did not work any more. This CL updates the script, and runs it. This generates a fuzzer corpus of 42011 wasm modules, compared to 15290 before. The new modules will contain new features like SIMD and multi-value, which will be interesting fuzzer inputs. R=ahaas@chromium.org Change-Id: Ic3df26930cb8c1c6e8d521597ceb06cc338c02ed Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2565512Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#71537}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/23fe346..4fd0dec Rolling v8/third_party/aemu-linux-x64: uQdbvtcP840HCVMjrZtUTrYeUgSD_J2rxG1WcyDUbvMC..jfuzh1KU9b_qTmPrfQ2v7GW8FB2tUz0uUUjeyB_2LdQC Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/1af7968..6d2a0fe TBR=machenbach@chromium.org,tmrts@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ie69bc3b89d25bbe914fd1359077902b16ecc0565 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2567493Reviewed-by:
-
Shu-yu Guo authored
Await is a unary operator and should be disallowed on the LHS of exponentiation like all other unary operators. Bug: v8:11213 Change-Id: I9c51e33cb37660627748cd926ec222ac0ac246de Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2566442Reviewed-by:
Marja Hölttä <marja@chromium.org> Commit-Queue: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/master@{#71535}
-
Dominik Inführ authored
So far the main thread can have two different kinds of local handles, regular main thread handles and local handles in its LocalIsolate. This is both confusing and error-prone. This CL retargets local handles creation for the LocalIsolate on the main thread to always create regular main thread handles instead. Bug: v8:10315 Change-Id: I4df509a0fc1bd630ba956b5eaacacbe706ddb4ef Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2527062Reviewed-by:
Igor Sheludko <ishell@chromium.org> Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/master@{#71534}
-
Manos Koukoutos authored
Add support for array and struct definitions and the rest of gc-related opcodes. Drive-by: Remove obsolete kWasmAnyFunctionTypeForm, replace it with kWasmFuncRef. Bug: v8:7748 Change-Id: I9512ff22d661fead5ad86767871632ae94346465 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2567691Reviewed-by:
-
Bill Budge authored
- Uses linkage location information, to keep in sync with how LinkageAllocator and Frame work to assign stack slots. Bug: v8:9198 Change-Id: I299038e4cff706355263f00603ba32515449fefe Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2556259Reviewed-by:
Maya Lekova <mslekova@chromium.org> Reviewed-by:
Thibaud Michaud <thibaudm@chromium.org> Commit-Queue: Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#71532}
-
Sathya Gunasekaran authored
This reverts commit 535fd785. Reason for revert: https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Linux%20-%20gc%20stress/31193/blamelist Original change's description: > [wasm] Make DecodeLocals return the number of decoded locals > > Currently, when the new locals are not appended to the existing ones, > there is no way to know how many new locals were defined. This CL > addresses this issue. > > Drive-by: Fix the pc passed to DecodeLocals in OpcodeLength. > Change-Id: Id9de561a6380b52dcce398301727aa12196c0677 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2567695 > Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> > Reviewed-by: Clemens Backes <clemensb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#71526} TBR=clemensb@chromium.org,manoskouk@chromium.org Change-Id: Ie2bbb1b14e5326bce62bb42fa528528b662d3528 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2567199Reviewed-by:
-
Thibaud Michaud authored
Instead of processing batches with a fixed number of functions, process batches with approximately the same number of bytes. This prevents disproportionately large batches to block the pipeline. R=ahaas@chromium.org Bug: v8:11164 Change-Id: I7fe57abac13c5fb749a002e339c5a9b2dab607be Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2567699Reviewed-by:
-
Manos Koukoutos authored
Null checks were not optimized out for non-nullable arrays for array.len. This CL brings array.len in line with the rest of the gc operations. Bug: v8:7748 Change-Id: I8d4d5f159ed220f6e64cb812079e15d6e92de68b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2567690Reviewed-by:
-
Dominik Inführ authored
Avoid data race when enabling flag with concurrent thread that reads that flag as well. Bug: v8:10315 Change-Id: I9eecc48e21b1070e8db444021264eec2784f5102 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2567697 Auto-Submit: Dominik Inführ <dinfuehr@chromium.org> Reviewed-by:
-
Leszek Swirski authored
The DCHECK on number_of_elements was making TSAN unhappy. Given that making this field atomic would be a performance penalty, and that the DCHECK isn't expected to catch any errors in practice (other DCHECKs check the same invariant), we can just drop it. Bug: v8:11183 Change-Id: Ic1b5697b233c4c45c3951816531f888459c3e69f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2567698 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
-
Manos Koukoutos authored
Currently, when the new locals are not appended to the existing ones, there is no way to know how many new locals were defined. This CL addresses this issue. Drive-by: Fix the pc passed to DecodeLocals in OpcodeLength. Change-Id: Id9de561a6380b52dcce398301727aa12196c0677 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2567695 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by:
-
Camillo Bruni authored
Bug: chromium:1061857 Change-Id: I81ec92979b2e64f77385df79c084b98485c266ff Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2563265Reviewed-by:
Victor Gomes <victorgomes@chromium.org> Reviewed-by:
-
Michael Lippautz authored
Adds publicly callable version of write barrier for TracedReferenceBase. Bug: chromium:1056170 Change-Id: Ie45b4ebbe91d9f0e8f76b521dcbfd931232adcf6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2565248Reviewed-by:
-
Clemens Backes authored
This reverts commit be52501d. Reason for revert: Multiple TSan issues: https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Linux64%20TSAN/34457/overview (and others) Original change's description: > [heap] Add epoch to GC tracing events > > This CL adds the TRACE_GC_EPOCH macro, which adds the epoch as attribute > to the trace event. Use TRACE_GC_EPOCH for top-level events, nested > events can get the information from its parent. > > V8's GC needs an epoch for young and full collections, since scavenges > also occur during incremental marking. The epoch is also process-wide, > so different isolates do not reuse the same id. > > Change-Id: I8889bccce51e008374b4796445a50062bd87a45d > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2565247 > Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#71521} TBR=ulan@chromium.org,dinfuehr@chromium.org Change-Id: I8219595f0751de84cbea7e047ef21aa95da32f07 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2567696Reviewed-by:
-
Michael Achenbach authored
When one comparison run crashes, we cap the outputs to compare to the shorter one. If one of those, however, contains ignored lines, the comparison get's skewed. This makes the main source of ignored lines more robust (the line printed for unknown flags), by not printing it in the first place in the context of differential fuzzing. Bug: chromium:1153871 Change-Id: If2e534959779be14a686be5e43630cbf66e215a0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2567692 Auto-Submit: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
-
Dominik Inführ authored
This CL adds the TRACE_GC_EPOCH macro, which adds the epoch as attribute to the trace event. Use TRACE_GC_EPOCH for top-level events, nested events can get the information from its parent. V8's GC needs an epoch for young and full collections, since scavenges also occur during incremental marking. The epoch is also process-wide, so different isolates do not reuse the same id. Change-Id: I8889bccce51e008374b4796445a50062bd87a45d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2565247 Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Reviewed-by:
-
Zhi An Ng authored
Bug: v8:11074 Change-Id: I0b819aba03d720780142bcc937e2f148d39f9be9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2567537 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#71520}
-
Etienne Pierre-Doray authored
This reverts commit 064ee3c8. Reason for revert: Causing blink_web_tests to fail on builder "WebKit Linux MSAN" https://bugs.chromium.org/p/chromium/issues/detail?id=1153968 Original change's description: > Reland "[wasm]: Use CancelAndDetach and barrier on BackgroundCompileJob." > > Reason for revert: Data race: > https://ci.chromium.org/p/v8/builders/ci/V8%20Linux64%20TSAN/34121 > > It was assume that MockPlatform runs everything on 1 thread. However, > MockPlatform::PostJob previously would schedule the job through > TestPlatform, which eventually posts concurrent tasks, thus causing > data race. > Fix: Manually calling NewDefaultJobHandle and passing the MockPlatform > ensures the jobs also run sequentially. > > Additional change: > - CancelAndDetach is now called in ~CompilationStateImpl() to make sure > it's called in sequence with ScheduleCompileJobForNewUnits > > Original CL description: > To avoid keeping around a list of job handles, CancelAndDetach() is > used in CancelCompilation. Dependency on WasmEngine is handled by a > barrier that waits on all jobs to finish. > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2498659 > Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Reviewed-by: Clemens Backes <clemensb@chromium.org> > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> > Cr-Original-Commit-Position: refs/heads/master@{#71074} > Change-Id: Ie9556f7f96f6fb9a61ada0e5cbd58d4fb4a0f571 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2559137 > Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> > Reviewed-by: Andreas Haas <ahaas@chromium.org> > Cr-Commit-Position: refs/heads/master@{#71459} TBR=ulan@chromium.org,jkummerow@chromium.org,ahaas@chromium.org,clemensb@chromium.org,etiennep@chromium.org Bug: chromium:1153968, v8:11209, v8:11210, v8:11212 # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I2c8406bea81ee7cf6c5726c2fec50fffdce09611 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2566446Reviewed-by:
-
Santiago Aboy Solanes authored
Change-Id: Iee3a65c6df143a41b45b610a10a19ec28ad5c268 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2565513Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Cr-Commit-Position: refs/heads/master@{#71518}
-
Zhi An Ng authored
Bug: v8:11074 Change-Id: I80b7c54e44f2fc0cdc4d9786b58aaa92de519b04 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2567536Reviewed-by:
-
Liu Yu authored
This CL applies kSetOverflowToMin in TruncateFloat32ToInt32, TruncateFloat32ToUint32, and TruncateFloat64ToInt64, allowing EffectControlLinearizer to request truncating to INT32_MIN or INT64_MIN in case of overflow. Port: d4b29d75 Bug: v8:11121 Change-Id: I1ef794e89641d0be6e9be9bdb99fd7737f465821 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2537417Reviewed-by:
Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Reviewed-by:
-
Clemens Backes authored
The auto-generated inspector fuzzer corpus seed files will overwrite the 'utils' class by a proxy which provides non-existing functions. See https://crrev.com/c/2563552. R=szuend@chromium.org Bug: chromium:1142437 Change-Id: If1e86617c4244f1b12fe007b5059b5a5f57454d5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2565127Reviewed-by:
Simon Zünd <szuend@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#71515}
-
