- 05 Nov, 2021 17 commits
-
-
Camillo Bruni authored
The new callback does no longer use ScriptOrModule but rather gets the host-defined options and the referrer name as separate arguments. This brings us one step closer to deprecate ScriptOrModule and putting the host-defined options in the script context. - Add v8::Data::IsFixedArray and cast helpers - Deprecate HostImportModuleDynamicallyWithImportAssertionsCallback soon - Add Script::Run entry point that explicitly takes host-defined options (unused yet) Bug: chromium:1244145 Change-Id: I08bc92cfb3b79d840e766fb71b8d91d301f4399c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3263893 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Victor Gomes <victorgomes@chromium.org> Cr-Commit-Position: refs/heads/main@{#77733}
-
Victor Gomes authored
CodeSpaceMemoryModificationScope should only be used by the main thread and during a safepoint. This adds a check in CodeSpaceMemoryModificationScope. The reason for this is that CodeSpaceMemoryModificationScope is not thread-safe. It assumes that no other thread is modifying code space (either by setting memory permission or adding a new page). This CL also replaces CodeSpaceMemoryModificationScope to CodePageCollectionMemoryModificationScope in a few occurrences, where the former is not needed. This should not hurt performance. Bug: v8:12054 Change-Id: I2675e667782c6ad8410877a4e64374899066bcd1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3263890 Commit-Queue: Victor Gomes <victorgomes@chromium.org> Reviewed-by:
Dominik Inführ <dinfuehr@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/main@{#77732}
-
Nikolaos Papaspyrou authored
Report young generation GC statistics to the Recorder API. These will be used by Blink to populate UMA histograms. Existing UMA reporting in V8 remains as is for now and will be removed in a followup. This CL goes together with: https://chromium-review.googlesource.com/c/chromium/src/+/3247446 Change-Id: I1fed070d4a3996c4d0d8942b455d722afafcc4ab Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3247635 Commit-Queue: Nikolaos Papaspyrou <nikolaos@chromium.org> Reviewed-by:
Omer Katz <omerkatz@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/main@{#77731}
-
Manos Koukoutos authored
We enable struct.new and array.init initializer expressions in the JS testcase generated by --wasm-fuzzer-gen-test. We needed to make some changes in the WasmInitExpr class, and to implement a new interface for the WasmFullDecoder, which constructs a WasmInitExpr. Changes: - Make WasmInitExpr a ZoneObject. Use a pointer for its operands_ field. This is needed so WasmInitExpr is trivially copiable, and thus usable as a Value type in WasmFullDecoder. - Implement a WasmFullDecoder interface in wasm-fuzzer-common that constructs a WasmInitExpr. Use it to decode initializers in the module generated by the fuzzer. - Change AppendInitExpr to take a WasmInitExpr as argument. - Fix an issue with printing of struct definitions. - Change initializer expression used for structs to struct.new_with_rtt. This is consistent with the currently used structural types. Bug: v8:11954 Change-Id: I65a87cc98701a54f32500be192b3b6eef2ff6c8c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3257712Reviewed-by:
Thibaud Michaud <thibaudm@chromium.org> Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Cr-Commit-Position: refs/heads/main@{#77730}
-
Maya Lekova authored
This reverts commit 5dd16ca0. Reason for revert: MSAN complains about an uninitialized value, see https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Linux%20-%20arm64%20-%20sim%20-%20MSAN/41150/overview Original change's description: > Add tests for serialization of v8::CFunction > > The tests are modeled after another patch that includes > v8::CFunctions into Node.js's builtin snapshot. > > Refs: https://github.com/nodejs/node/pull/40649 > Change-Id: I5a91682f7944ef06a0d3caf7333b09f974bcd64b > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3251138 > Reviewed-by: Leszek Swirski <leszeks@chromium.org> > Reviewed-by: Maya Lekova <mslekova@chromium.org> > Commit-Queue: Joyee Cheung <joyee@igalia.com> > Cr-Commit-Position: refs/heads/main@{#77726} Change-Id: I9ea32a84783c3f555ee40daebf7b7f6c74f75062 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3263892 Auto-Submit: Maya Lekova <mslekova@chromium.org> Owners-Override: Maya Lekova <mslekova@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#77729}
-
Leszek Swirski authored
We don't do scope analysis when there is a preparse error, so we don't have a literal that is valid enough to create a SharedFunctionInfo. Fixed: chromium:1267172 Change-Id: I18437889fb42593622410a44922bd9f0dc995992 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3263887 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
-
Michael Lippautz authored
Bug: v8:12165 Change-Id: I47b92d71ef76e71b6bfbcc883e70f5b31bceedcb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3263889Reviewed-by:
-
Joyee Cheung authored
The tests are modeled after another patch that includes v8::CFunctions into Node.js's builtin snapshot. Refs: https://github.com/nodejs/node/pull/40649 Change-Id: I5a91682f7944ef06a0d3caf7333b09f974bcd64b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3251138Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Maya Lekova <mslekova@chromium.org> Commit-Queue: Joyee Cheung <joyee@igalia.com> Cr-Commit-Position: refs/heads/main@{#77726}
-
Camillo Bruni authored
Change-Id: I5dbfe8c1e2f8474d4693dc9e9ddd57639c37c6ab Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3263885Reviewed-by:
-
Victor Gomes authored
Change-Id: I1d343244f9b4674b830c13a879d90397de4a784a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3263886 Auto-Submit: Victor Gomes <victorgomes@chromium.org> Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/main@{#77724}
-
Leszek Swirski authored
Remove FunctionLiterals and ParseInfo from the LazyCompileDispatcher API, passing instead the SharedFunctionInfo, a character stream, and optionally some preparse data. In the future, this should allow us to pass arbitrary uncompiled SharedFunctionInfos into the LazyCompileDispatcher. Change-Id: Iff90408f3b259c7f5df0e74687d052e75959fa48 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3262131Reviewed-by:
-
Jakob Gruber authored
Capture group names were extended in https://github.com/tc39/ecma262/pull/1869/files https://github.com/tc39/ecma262/pull/1932/files RegExpIdentifierName now explicitly enables unicode (+U) for unicode escape sequences; likewise, surrogate pairs are now allowed unconditionally. The implementation simply switches on unicode temporarily while parsing a capture group name. Good news everyone, /(?<𝒜>.)/ is now a legal pattern. Bug: v8:10384 Change-Id: Ida805998eb91ed717b2e05d81d52c1ed61104e3f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3233234 Auto-Submit: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
-
Al Muthanna Athamina authored
Bug: chromium:1136844 Change-Id: Ie282c94e18bce71e47f69d84c89640d459ea39a7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3260505 Commit-Queue: Almothana Athamneh <almuthanna@chromium.org> Reviewed-by:
Liviu Rau <liviurau@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/main@{#77721}
-
Leszek Swirski authored
Do a full copy of all fields when initialising and copying from the placeholder SharedFunctionInfo that is used in off-thread function compilation. This guarantees that all fields are correct both in the on-thread and off-thread cases. Change-Id: If1807c6f56fe38fea40ed39596f85634356e2623 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3260518Reviewed-by:
-
Dominik Inführ authored
Move logic to perform a global safepoint into GlobalSafepointScope respectively GlobalSafepoint for easier reuse of this functionality in the future. Note that full functionality for a global safepoint will be provided in a subsequent CL. Bug: v8:11708 Change-Id: I80dd22c36ab01df573623aa36ead9cc373663b9b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3259531Reviewed-by:
Igor Sheludko <ishell@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/third_party/google_benchmark/src: https://chromium.googlesource.com/external/github.com/google/benchmark/+log/8aae0a4..329fb06 Fix error with Fix Werror=old-style-cast (#1272) (Bensuperpc) https://chromium.googlesource.com/external/github.com/google/benchmark/+/329fb06 Fix error Wshorten-64-to-32 (#1273) (Bensuperpc) https://chromium.googlesource.com/external/github.com/google/benchmark/+/8826ef7 TBR=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com,mlippautz@chromium.org Change-Id: I02d2c02eba3ba63364060cc0809ee021fa4b804e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3262145Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#77718}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/02bef0a..9088cd6 Rolling v8/third_party/aemu-linux-x64: hys6gk1KOHMz9nURGWen255HiLIaVd3e4eZfa-w6l7oC..Ce6sqxwYi8DOFfwlCOP0MURltjjH-QIsgAsJ1p7--KIC Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/b939095..429f4e0 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/8a0d05d..1c179b5 Rolling v8/third_party/instrumented_libraries: https://chromium.googlesource.com/chromium/src/third_party/instrumented_libraries/+log/3c149f5..7dab69f Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/b2ffe54..af96b7b TBR=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: Ie305f81bb17aabb539976e30057152e18e1df4c2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3262141Reviewed-by:
-
- 04 Nov, 2021 23 commits
-
-
Camillo Bruni authored
This is a reland of 0446ab7c Additional fix: Manually set the host-defined options on deserialised scripts in d8. Original change's description: > [d8] Verify host-defined options > > d8 never checked what the actual value of the host-defined options are. > We now properly very that the host-defined options is a specific object > so we we don't end up accidentally ignoring a wrong options object. > > Drive-by-fix: > - Convert %AbortJS argument to string > > Bug: chromium:1244145 > Change-Id: If0ed128d215682bcf066592418420548b06eb6a1 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3259655 > Commit-Queue: Camillo Bruni <cbruni@chromium.org> > Reviewed-by: Shu-yu Guo <syg@chromium.org> > Cr-Commit-Position: refs/heads/main@{#77699} Bug: chromium:1244145 Change-Id: I8ddfdba27d84c36862323ab9e1aba14b2ff932a4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3259539 Auto-Submit: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Shu-yu Guo <syg@chromium.org> Commit-Queue: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/main@{#77716}
-
Andreas Haas authored
The wasm serialization format only contains TurboFan code. All other functions are only represented by placeholders. With this CL serialization fails if the serialized module does not contain any TurboFan functions and would therefore consist only of placeholders. This is a defense in depth approach, because ideally serialization only gets triggered when TurboFan code is available. However, in some scenarios like debugging it can happen that modules without TurboFan code get serialized. Bug: v8:12281 Change-Id: Ib05430ff89eb2317da80fc0d086ce1d7ab0e919d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3212510 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/main@{#77715}
-
Dominik Inführ authored
Change-Id: I68935a96ac674965cf12079daa0aae35be042a97 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3260523 Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
Michael Lippautz authored
Adjust WATCHLISTS to only send out updates to those testfiles as part of notifying oilpan-reviews+v8@. Change-Id: Ib877f0353ea2b2d1ac06c93d450145dbeb6fcc66 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3260517 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Auto-Submit: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
Leszek Swirski authored
Remove the concept of JobId from LazyCompileDispatcher, and make SFIs the canonical id for these jobs. This has several consequences: * We no longer split enqueing a job and registering a SFI with that job. We did this previously because we could not allocate SFIs in the Parser -- now with LocalHeap we can, so we do. * We remove the separate Job vector, and make the SFI IdentityMap hold pointers to Jobs directly. This requires a small amount of extra care to deallocate Jobs when removing them from the map, but it means not having to allocate new global handles for jobs. * The SFI is passed into the BackgroundCompileTask instead of the script, so our task finalization doesn't need the SFI anymore. * We no longer need to iterate ParallelTasks after compiling (to register SFIs), so we can get rid of ParallelTasks entirely and access the dispatcher directly from the parser. There are a few drive-bys since we're touching this code: * Jobs are move to have a "state" variable rather than a collection of bools, for stricter DCHECKing. * There's no longer a set of "currently running" jobs, since this was only used to check if a job is running, we can instead inspect the job's state directly. * s/LazyCompilerDispatcher/LazyCompileDispatcher/g Change-Id: I85e4bd6db108f5e8e7fe2e919c548ce45796dd50 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3259647 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by: -
Lutz Vahl authored
R=hablich@chromium.org, vahl@chromium.org Change-Id: I33783822bf8131910ff9840a58b07da5086a92d0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3260521Reviewed-by:
Lutz Vahl <vahl@chromium.org> Reviewed-by:
-
Michael Lippautz authored
LayoutDescriptor has been removed some time ago. Change-Id: I8aa16fcd82be098c9bfd439decef8147514587d0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3260515 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Auto-Submit: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
Michael Lippautz authored
Add CHECK ensuring that the young generation is indeed empty for pointers updating. This is necessary as otherwise iterating an object may race with updating a slot in a Map for WasmStruct. Bug: v8:12185 Change-Id: Id590cf267fedf95d97df2464a638352696ad53db Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3260514Reviewed-by:
-
Tim van der Lippe authored
This reverts commit f9ebad01. Reason for revert: suspected root cause of crbug.com/1257806 Additionally, this patch might actually be incorrect as we eagerly evaluate native accessors, which can only happen if the debugger is running. Original change's description: > [inspector] Use side-effect free debug evaluate for inherited accessors. > > Replace the hard-coded blocklist ("Response.body" and "Request.body") in > the V8 inspector with proper side-effect free debug evaluate. This is > otherwise a non-functional change and in particular preserves the > behavior of reporting accessors as (own) data properties. That will be > tackled in a follow-up CL. > > This CL is possible because with https://crrev.com/c/3056879 Blink now > properly marks accessors as side-effect free consistently with what the > V8 inspector had done before. > > Doc: http://doc/1gLyyOlssS5zyCSEyybVC-5sp0UnNJj2hBoFyf6ryrTc > Bug: chromium:829571, chromium:1076820, chromium:1119900 > Change-Id: Idb256accaf4cfb5db5982b3eb06ddcef588be635 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3062573 > Auto-Submit: Benedikt Meurer <bmeurer@chromium.org> > Commit-Queue: Philip Pfaffe <pfaffe@chromium.org> > Reviewed-by: Philip Pfaffe <pfaffe@chromium.org> > Cr-Commit-Position: refs/heads/master@{#76019} Bug: chromium:829571, chromium:1076820, chromium:1119900, chromium:1257806 Fixed: chromium:1265372 Change-Id: Ia31a3022aaa9ddeae1f01eaa90e345f8bdbb21c9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3259653 Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/main@{#77708}
-
Jakob Kummerow authored
The old "gc-safe" implementation to get the off-heap type information wasn't quite as gc-safe as it needs to be. Due to parallel compaction, we shouldn't check for forwarding pointers; instead we should rely on the old location of the Foreign, but make sure not to look at its Map (which might be a forwarding pointer). Bug: v8:12185 Change-Id: I4570b00a5300a0d7ed8c042fa21d355373e0e691 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3260513 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
-
Jakob Gruber authored
- Add an inline fast path for flat strings. - Efficient shape queries. - Add constants for seq/external one/two-byte string tags. Bug: v8:12195 Change-Id: Ia2c3d3c9207ab56bc4f0b425d21c7c93ad98aef4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3259530 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Leszek Swirski authored
This reverts commit 0446ab7c. Reason for revert: Lots of failures https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Linux%20-%20debug/37355/overview Original change's description: > [d8] Verify host-defined options > > d8 never checked what the actual value of the host-defined options are. > We now properly very that the host-defined options is a specific object > so we we don't end up accidentally ignoring a wrong options object. > > Drive-by-fix: > - Convert %AbortJS argument to string > > Bug: chromium:1244145 > Change-Id: If0ed128d215682bcf066592418420548b06eb6a1 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3259655 > Commit-Queue: Camillo Bruni <cbruni@chromium.org> > Reviewed-by: Shu-yu Guo <syg@chromium.org> > Cr-Commit-Position: refs/heads/main@{#77699} Bug: chromium:1244145 Change-Id: I267f4bdbd8afce81934f4e813dbe1ec09ebdc1ae No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3259538 Auto-Submit: Leszek Swirski <leszeks@chromium.org> Owners-Override: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#77705}
-
Shu-yu Guo authored
This runtime function behaves like StoreDataPropertyInLiteral, except it can throw, since it's also used for defining public class fields. Unlike the literal use case, class field can end up throwing due to field initializers doing things like freezing the instance. Bug: chromium:1264828 Change-Id: I3ea4d15ad9b906c26763f022c8e22b757fa80b6c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3252558 Commit-Queue: Igor Sheludko <ishell@chromium.org> Auto-Submit: Shu-yu Guo <syg@chromium.org> Reviewed-by:
-
Corentin Pescheloche authored
The goal of the PR is to add to telemetry a metric estimating the space occupied by the codemap retained by a CpuProfiler and its underlying CodeObserver. This change is motivated by the addition of kEagerLogger to CpuProfiler which when enabled let a CpuProfiler build a CodeMap without an active session. This metric will help us understand better the space consumed by a profiler in that scenario and will also help detect memory leaks. Bug: chromium:1241491 Change-Id: Iadb1ed52b4c1ac70bc554942b4fa795cdf1212f3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3224567Reviewed-by:
-
Leszek Swirski authored
Some post-compile flag setting was unnecessary, since those flags originally came from the SFI they were being set on. Also, DontOptimizeReason was never actually set, so we can remove it entirely. Change-Id: Ic07821fc20ba4e16a2bd8b9e8ac8c1b266aa4067 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3260510 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Victor Gomes <victorgomes@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
-
Jakob Gruber authored
- Use a StringShape instead of repeatedly querying type. - Add a shortcut for already-flat strings. - Unhandlify where possible (all except SlowFlatten). - Mark String::Flatten and StringShape methods V8_INLINE. - Add a specialized ConsString::IsFlat overload. Drive-by: Various (add const, remove this->, helper methods). Bug: v8:12195 Change-Id: If20df12bc29c29cff2005fdc9bd826ed9f303463 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3259527 Auto-Submit: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Leszek Swirski authored
This reverts commit 92edf9a1. Reason for revert: Breaks mjsunit/es6/proxies-json on GCStress https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Linux64%20GC%20Stress%20-%20custom%20snapshot/39619/overview Original change's description: > [runtime] Optimise paired instance type checks > > Clang doesn't optimise over handle derefs. Change the ValueSerializer > and the JsonStringifier to use InstanceType directly for checks. > This CL squeezes another 1.5% of JSON.stringify in local benchmarks. > > Drive-by-fix: > - Avoid a few more derefs in the JsonStringifier > - Make JsonStringifier::SerializeJSArray a bit more readable > > Change-Id: I37626a6d92a8d9275611a4e6d1d908f2e0c6d43b > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3247637 > Commit-Queue: Camillo Bruni <cbruni@chromium.org> > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Cr-Commit-Position: refs/heads/main@{#77697} Change-Id: I127dd5832b9caceb0d5b74631eede274551405e0 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3260511 Auto-Submit: Leszek Swirski <leszeks@chromium.org> Owners-Override: Leszek Swirski <leszeks@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/main@{#77700}
-
Camillo Bruni authored
d8 never checked what the actual value of the host-defined options are. We now properly very that the host-defined options is a specific object so we we don't end up accidentally ignoring a wrong options object. Drive-by-fix: - Convert %AbortJS argument to string Bug: chromium:1244145 Change-Id: If0ed128d215682bcf066592418420548b06eb6a1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3259655 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
-
Al Muthanna Athamina authored
Bug: v8:12185 Change-Id: I32518ad88d98f68934a1b3c12b1559e31f0df628 No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3259528 Auto-Submit: Almothana Athamneh <almuthanna@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
-
Camillo Bruni authored
Clang doesn't optimise over handle derefs. Change the ValueSerializer and the JsonStringifier to use InstanceType directly for checks. This CL squeezes another 1.5% of JSON.stringify in local benchmarks. Drive-by-fix: - Avoid a few more derefs in the JsonStringifier - Make JsonStringifier::SerializeJSArray a bit more readable Change-Id: I37626a6d92a8d9275611a4e6d1d908f2e0c6d43b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3247637 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/main@{#77697}
-
v8-ci-autoroll-builder authored
Rolling v8/third_party/google_benchmark/src: https://chromium.googlesource.com/external/github.com/google/benchmark/+log/4f31803..8aae0a4 [cleanup] Change `== ""` to `.empty()` on string to avoid clang-tidy warnings (#1271) (Vy Nguyen) https://chromium.googlesource.com/external/github.com/google/benchmark/+/8aae0a4 TBR=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com,mlippautz@chromium.org Change-Id: I4edce04c4cbc33019942b05ae1fdb094571f0694 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3260155Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/cf32591..02bef0a Rolling v8/buildtools/linux64: git_revision:8926696a4186279489cc2b8d768533e61bba73d7..git_revision:90294ccdcf9334ed25a76ac9b67689468e506342 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/75c4ea8..b939095 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/57c928c..8a0d05d Rolling v8/third_party/googletest/src: https://chromium.googlesource.com/external/github.com/google/googletest/+log/16f637f..bf0701d Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/21baac0..b2ffe54 TBR=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: I8f7d055b78dc6db357a4dcfe761e17728ae53b65 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3260153Reviewed-by:
-
Zhao Jiazhong authored
Currently, the safepoint is last call instruction's return address on mips and loongarch64 platform. But in `CallCFunction`, there are some other instructions after calling, which leading to a wrong safepoint record on mips and loongarch64. So I record the pc for safepoint at the end of `CallCFunction` function, and change `last_call_pc_` to `pc_for_safepoint_`. Besides, commit 48b2b891 introduced a typo on loong64 platform, I also fixed it in this CL. Change-Id: Ia3ea77ae2f6f1c8c604e35f420a7632a78c9725a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3258875 Commit-Queue: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
