- 23 Jun, 2017 27 commits
-
-
Toon Verwaest authored
Bug: Change-Id: I0415b3946e6efd97c3b2fb770fda7dba265ee8cd Reviewed-on: https://chromium-review.googlesource.com/545000Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#46177}
-
Marja Hölttä authored
This removes the include from: assembler.h (moved Isolate::AddressId to globals.h / IsolateAddressId) counters.h (ditto) elements.h (trivial) keys.h (trivial + iwyu fixes) property.h (trivial) transitions.h (trivial) vm-state.h (trivial) heap/code-stats.h (trivial + drive-by iwyuing) BUG=v8:5294 Change-Id: I36b8c07d4edf4177f1a987a393569f5191167ed3 Reviewed-on: https://chromium-review.googlesource.com/532879Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#46176}
-
Ulan Degenbaev authored
The race happens when the layout descriptor is evacuated at the same time as an object that has this layout descriptor is evacuated. Change-Id: I0a5fc545cf359fdfe738d8b6359713f5ea170986 Reviewed-on: https://chromium-review.googlesource.com/544953 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#46175}
-
Camillo Bruni authored
This partially reverts commit 015edc60. Reason for revert: Performance regression on richards Bug: v8:6211 Change-Id: Ib69a1ed90b2015addcc54d7f299bdd654d964b54 Reviewed-on: https://chromium-review.googlesource.com/544992Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#46174}
-
Toon Verwaest authored
Bug: Change-Id: I240356157c71a544d94f8898029d54010b2f4d37 Reviewed-on: https://chromium-review.googlesource.com/544309 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
-
Michael Achenbach authored
NOTRY=true NOTREECHECKS=true TBR=ulan@chromium.org Bug: chromium:735951 Change-Id: I8b54ba272d353b1fb499fcfccef1f49b9c47a137 Reviewed-on: https://chromium-review.googlesource.com/544828 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#46172}
-
Michael Achenbach authored
This reverts commit 217d654c. Reason for revert: Changes layout tests: https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/16520 Original change's description: > [parser] moved load property position after dot > > Currently LdaNamedProperty bytecode for expressions like a.b has position before dot. This CL moves this location after dot. > It's important for later removing of Nop bytecodes in expressions like a.b() where a is local variable, property call and property load should have the same position. > > R=jgruber@chromium.org > > Bug: v8:6425 > Change-Id: I528c5007de52215beba80851ab04693ecec038e2 > Reviewed-on: https://chromium-review.googlesource.com/543047 > Reviewed-by: Marja Hölttä <marja@chromium.org> > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#46163} TBR=marja@chromium.org,kozyatinskiy@chromium.org,jgruber@chromium.org Change-Id: I94543526f39f0a20452fbce1a7bc6744cac66621 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:6425 Reviewed-on: https://chromium-review.googlesource.com/544993Reviewed-by:
-
Andreas Haas authored
For correct error positions, the FunctionBody struct stored a {base} pointer to the beginning of the wasm module bytes, in addition to the {start} and {end} pointer of the function body within the module bytes. For streaming compilation, we do not have all module bytes in a single chunk of memory. Therefore this CL changes the FunctionBody such that it does not store the base pointer but the offset of the function body within the module. I did the same change already some time ago for the {Decoder}. R=clemensh@chromium.org, mtrofin@chromium.org Change-Id: I5138fbe270d0f5166a7dcc5cb8f3fe78a298bff6 Reviewed-on: https://chromium-review.googlesource.com/544863Reviewed-by:Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#46170}
-
Marja Hölttä authored
Make PreParser match what Parser does. BUG=v8:5516 Change-Id: I2801206fd17b9a5047bc43c6112f4945971596b7 Reviewed-on: https://chromium-review.googlesource.com/544949 Commit-Queue: Marja Hölttä <marja@chromium.org> Reviewed-by:
Daniel Vogelheim <vogelheim@chromium.org> Cr-Commit-Position: refs/heads/master@{#46169}
-
jgruber authored
Drive-by-fixes: Singleton ranges past EOF, disable optimization for block count mode. Bug: v8:6000 Change-Id: I718891f8821285ce3d7d8360faaa91a43de5b93d Reviewed-on: https://chromium-review.googlesource.com/541300Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Marja Hölttä <marja@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#46168}
-
Michael Starzinger authored
This removes the --turbo flag and solely relies on the filter pattern provided via --turbo-filter when deciding whether to use TurboFan. Note that disabling optimization wholesale can still be done with --no-opt, which should be used in favor of --no-turbo everywhere. Also note that this contains semantic changes to the TurboFan activation criteria. We respect the filter pattern more stringently and no longer activate TurboFan just because the source contains patterns forcing use of Ignition via {AstNumberingVisitor::DisableFullCodegenAndCrankshaft}. R=rmcilroy@chromium.org BUG=v8:6408 Change-Id: I0c855f6a62350eb62283a3431c8cc1baa750950e Reviewed-on: https://chromium-review.googlesource.com/528121Reviewed-by:Jaroslav Sevcik <jarin@chromium.org> Reviewed-by:
Michael Stanton <mvstanton@chromium.org> Reviewed-by:
-
Ulan Degenbaev authored
Factory::NewUninitializedFixedArray is unsafe for GC. If performance allows, we should remove the function. Change-Id: I3f80352797e9768b788c2996c3f29e823c067f74 Reviewed-on: https://chromium-review.googlesource.com/517794Reviewed-by:
-
Tobias Tebbi authored
Async generator yield* is still desugared in the parser, to be moved to the BytecodeGenerator in a future CL. Bug: v8:6472 Change-Id: I8b33e2f9e931949f7375540099cd8ec3a6b27cf1 Reviewed-on: https://chromium-review.googlesource.com/539335 Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#46165}
-
Ulan Degenbaev authored
Change-Id: I5d5df00a38b7196001fb91e2642914271d8e66d0 Reviewed-on: https://chromium-review.googlesource.com/544932 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
-
Alexey Kozyatinskiy authored
Currently LdaNamedProperty bytecode for expressions like a.b has position before dot. This CL moves this location after dot. It's important for later removing of Nop bytecodes in expressions like a.b() where a is local variable, property call and property load should have the same position. R=jgruber@chromium.org Bug: v8:6425 Change-Id: I528c5007de52215beba80851ab04693ecec038e2 Reviewed-on: https://chromium-review.googlesource.com/543047Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#46163}
-
Michael Lippautz authored
Completely shares first-level visitation with the Scavenger. Remove marking recursively on the way as we cannot reliable check for stack overflow on background tasks. Bug: chromium:651354 Change-Id: I6da1dc787cdfb4232ea4b6cb8e72e0f736cabf10 Reviewed-on: https://chromium-review.googlesource.com/544967 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#46162}
-
Michael Achenbach authored
This also adds libraries recursively under the obj dir. Dropping v8_shell from globs since it's not included in the targets. NOTRY=true Bug: v8:5918 Change-Id: Ibfadb60dd7b347cf4a742f07e8b110c70e67cb06 Reviewed-on: https://chromium-review.googlesource.com/544308 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
-
Michael Lippautz authored
Reduces binary size, see bug. Bug: chromium:736097 Change-Id: I89b4b873accf2de85d5913a30fac53972d98e78d Reviewed-on: https://chromium-review.googlesource.com/544984Reviewed-by:
-
Michael Lippautz authored
Remove PageParallelJob as it is completely replaced now. It served us well. Bug: chromium:651354 Change-Id: I620fa7bb0dcaf7cd3710492913c501bcb162c781 Reviewed-on: https://chromium-review.googlesource.com/544950Reviewed-by:
-
Michael Lippautz authored
Bug: Change-Id: I90e0c469d096cbffbecf01add6cfabbf3af275fa Reviewed-on: https://chromium-review.googlesource.com/544307Reviewed-by:
-
jgruber authored
This piggy-backs on top of existing precise and best-effort coverage to expose block coverage through the inspector protocol. Coverage collection now implicitly reports block-granularity coverage when available. A new 'isBlockCoverage' property on Inspector's FunctionCoverage type specifies the granularity of reported coverage. For now, only count-based block coverage is supported, but binary block coverage should follow soon. Support is still gated behind the --block-coverage flag. Bug: v8:6000 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: I9c4d64e1d2a098e66178b3a68dcee800de0081af Reviewed-on: https://chromium-review.googlesource.com/532975 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#46157}
-
Marja Hölttä authored
Should've been part of https://chromium-review.googlesource.com/544300 BUG=v8:5516 Change-Id: I315b37d313b64c738174a6cd7461e5c46e362734 Reviewed-on: https://chromium-review.googlesource.com/544939Reviewed-by:
-
Michael Achenbach authored
TBR=vogelheim@chromium.org NOTRY=true Bug: chromium:645890 Change-Id: Ib5aa315d32c374c2bc755dc67255f84ce544e85f Reviewed-on: https://chromium-review.googlesource.com/544846 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
-
Michael Achenbach authored
This reverts commit d4a10807. Reason: Fails on gpu bots: https://build.chromium.org/p/client.v8.fyi/builders/Linux%20Release%20%28NVIDIA%29/builds/2145 # Fatal error in ../../v8/src/isolate.h, line 878 # Check failed: !IsIsolateInBackground(). BUG=v8:6361 TBR=kschimpf@chromium.org,cbruni@chromium.org,mtrofin@chromium.org,jochen@chromium.org,ulan@chromium.org NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true Change-Id: I5cf0241b3932b3c500598207b684a4b37936d0f8 Reviewed-on: https://chromium-review.googlesource.com/544825 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
-
bmeurer authored
Object.create is most often called with a single parameter, the prototype, and the properties are usually omitted. So optimizing for the common case, we remove the argument adaption. R=jgruber@chromium.org BUG=v8:5989 Review-Url: https://codereview.chromium.org/2953913002 Cr-Commit-Position: refs/heads/master@{#46153}
-
fedor authored
`libStart` already has ALSR slide added to it. Do not add it twice. https: //codereview.chromium.org/2696903002/ Review-Url: https://codereview.chromium.org/2928083004 Cr-Commit-Position: refs/heads/master@{#46152}
-
v8-autoroll authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/68d4fc6..a4ae1b7 Rolling v8/buildtools: https://chromium.googlesource.com/chromium/buildtools/+log/b92ff91..38477c2 Rolling v8/third_party/catapult: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+log/76def89..e810453 TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org Change-Id: Ia4c5bf404be1f3dd3c6bd49f32aa92b15c88f21c Reviewed-on: https://chromium-review.googlesource.com/545059Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#46151}
-
- 22 Jun, 2017 13 commits
-
-
kschimpf authored
HistoryTimer's can't run in the background because they use a timer with a simple api of Start() and Stop(). This CL fixes this problem by building a base class TimedHistogram that doesn't have a timer. The class HistoryTimer is modified to use this base class so that uses that run on the foreground thread do not need to be modified. It also adds a new class TimedHistogramScope that defines the timer in this class. This allows the corresopnding TimedHistogram class to be type safe. BUG=v8:6361 Review-Url: https://codereview.chromium.org/2929853003 Cr-Commit-Position: refs/heads/master@{#46150}
-
Clemens Hammacher authored
Why I want to fix this: I got a CL to replace V8_NORETURN by [[noreturn]], but clang-format formats this as extern "C"[[noreturn]] PRINT_FORMAT... (i.e. missing whitespace). Also, this is the only extern "C" function in our code base, so if we do not need to call it from C, we should just get rid of it. R=jochen@chromium.org BUG=v8:6474 Change-Id: I950bdc505822eb37a107c58e63c82a61907ba515 Reviewed-on: https://chromium-review.googlesource.com/539341Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#46149}
-
Alexey Kozyatinskiy authored
TBR=dgozman@chromium.org Bug: none Change-Id: Idc0020b44140b8c319622950aa309723c4e086eb Reviewed-on: https://chromium-review.googlesource.com/544964Reviewed-by:
-
Clemens Hammacher authored
https://chromium-review.googlesource.com/530193 accidentally disabled the timer for compilation time of individual wasm functions. This CL reenables this, and also gets rid of the ExecuteCompilationInternal method by using base::Optional for conditionally initializing the HistogramTimerScope. R=mtrofin@chromium.org CC=ahaas@chromium.org Change-Id: I359f0622561b82aea4d4002b7ed79fde32f1b35e Reviewed-on: https://chromium-review.googlesource.com/544135Reviewed-by:
Mircea Trofin <mtrofin@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#46147}
-
Jochen Eisinger authored
In most cases, I'm using ENTER_V8 which is due to the fact that the respective methods might end up executing script, either because they invoke some callback, or because they might trigger a proxy trap. Also add microtask suppression scopes in the debugger to all the places that need one according to tests. BUG=v8:5830 R=marja@chromium.org,jgruber@chromium.org Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: I24cc3de37fc0d8156acfe86b290568e5f8f662b4 Reviewed-on: https://chromium-review.googlesource.com/519262 Commit-Queue: Jochen Eisinger <jochen@chromium.org> Reviewed-by:
-
Ross McIlroy authored
BytecodeList::New() returns a reference to the BytecodeLabel added to the list. Since ZoneVector can resize, this reference could become invalid. Instead move to a ZoneLinkedList so the references never move. Since we were using zone vectors, the old references were still valid, and they were only mutated to set is_bound_, so only DCHECKs should have been affected. Change-Id: I5da850af2596dcd7f56578a6e5badd332350cb5b Reviewed-on: https://chromium-review.googlesource.com/544941 Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#46145}
-
danno authored
This CL leverages and extends the deopt-to-stub mechanisms previously introduced to support deopting from CSA-built builtins (e.g. Array.prototype.forEach). BUG=v8:6373 LOG=N Review-Url: https://codereview.chromium.org/2890363002 Cr-Commit-Position: refs/heads/master@{#46144}
-
Toon Verwaest authored
Bug: Change-Id: I45414453378c77f00ba01ca79fd4d84245c5a423 Reviewed-on: https://chromium-review.googlesource.com/544862Reviewed-by:
-
Anisha.Rohra authored
Removed the unnecessary macro. R=machenbach@chromium.org, dpranke@chromium.org, adamk@chromium.org BUG= LOG=N Review-Url: https://codereview.chromium.org/2949053003 Cr-Commit-Position: refs/heads/master@{#46142}
-
Toon Verwaest authored
Bug: Change-Id: I52bd9573735ac7c28a03e070064fe89b38d479ef Reviewed-on: https://chromium-review.googlesource.com/544957Reviewed-by:
-
Andreas Haas authored
If the fuzzer input cannot be executed in the interpreter within a step limit, then the interpreter does not calculate the result but instead finishes with a RangeError. The problem with the input of the bug report was that the interpreter finished with that RangeError, but the execution of the compiled code still returned a result, which was naturally not a RangeError and therefore caused the result check to fail. With this CL the compiled code is not even executed when there is a RangeError after the execution in the interpreter. Thereby we also avoid executing an infinite loop. BUG=chromium:734435 R=clemensh@chromium.org Change-Id: If9d0fb9e14e84f06d6f11d22f882363d56c1c20b Reviewed-on: https://chromium-review.googlesource.com/544838 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
-
Ulan Degenbaev authored
This patch also adds handling of NativeContext and BytecodeArray. BUG=chromium:694255 Change-Id: I6d4b2db03ece7346200853bd0b80daf65672787f Reviewed-on: https://chromium-review.googlesource.com/543237 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
-
Michael Achenbach authored
This is a reland of 54b42a55 Original change's description: > [build] Add filter script for official build > > This adds a V8-side script to list the files contained in an official archive. > > This'll accompany the infra-side archive recipe: > https://chromium-review.googlesource.com/c/544298/ > > Keeping this script on the V8-side will make it easy to change the > archived build product. > > NOTRY=true > > Bug: v8:5918 > Change-Id: I9fcb2eae183a26e7ce11c839d95a583a049cbe75 > Reviewed-on: https://chromium-review.googlesource.com/544877 > Commit-Queue: Michael Achenbach <machenbach@chromium.org> > Reviewed-by: Daniel Vogelheim <vogelheim@chromium.org> > Cr-Commit-Position: refs/heads/master@{#46135} TBR=vogelheim@chromium.org NOTRY=true Bug: v8:5918 Change-Id: I87b58c78a2cbd97f4da37ac93fe1e8ee77bf5ca0 Reviewed-on: https://chromium-review.googlesource.com/544979Reviewed-by:
-
