• Clemens Hammacher's avatar
    [cleanup] extern "C" not needed for V8_Fatal · 696f31ba
    Clemens Hammacher authored
    Why I want to fix this: I got a CL to replace V8_NORETURN by
    [[noreturn]], but clang-format formats this as
      extern "C"[[noreturn]] PRINT_FORMAT...
    (i.e. missing whitespace).
    Also, this is the only extern "C" function in our code base, so if we
    do not need to call it from C, we should just get rid of it.
    
    R=jochen@chromium.org
    BUG=v8:6474
    
    Change-Id: I950bdc505822eb37a107c58e63c82a61907ba515
    Reviewed-on: https://chromium-review.googlesource.com/539341Reviewed-by: 's avatarJochen Eisinger <jochen@chromium.org>
    Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#46149}
    696f31ba
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
gypfiles Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...