- 27 Sep, 2021 4 commits
-
-
Jakob Kummerow authored
Bug: v8:12244,v8:12245 Change-Id: Ida2dc91b10f708ded9cb71d140bf26673b1442bc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3183166 Auto-Submit: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/main@{#77078}
-
Marja Hölttä authored
Bug: v8:11111 Change-Id: I10409756af4ba1a04c1bca21cbdab375003a7f42 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3177225 Commit-Queue: Marja Hölttä <marja@chromium.org> Reviewed-by: Shu-yu Guo <syg@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/main@{#77077}
-
Dominik Inführ authored
GCTracer::Scope and GCTracer::Event shadow GarbageCollector's MARK_COMPACTOR, etc. Bug: v8:12244, v8:12245 Change-Id: Ibe60fb03ba35c9a9e057cadc7b8f557d9db9437f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3182226 Auto-Submit: Dominik Inführ <dinfuehr@chromium.org> Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/main@{#77076}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/a169c19..6476f40 TBR=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: I7f9fa264560e7a5128358e1b0218cb6763f9c12c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3184927Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#77075}
-
- 26 Sep, 2021 5 commits
-
-
Zhao Jiazhong authored
Port commit e301d71f Change-Id: I58bb66e86629b60bcb75b3cec3e293d75acc5f5c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3184290 Auto-Submit: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Reviewed-by: Liu yu <liuyu@loongson.cn> Commit-Queue: Liu yu <liuyu@loongson.cn> Cr-Commit-Position: refs/heads/main@{#77074}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/32fc064..a169c19 Rolling v8/third_party/aemu-linux-x64: y7X4kitLsRPSZc6ksrVllZRbH7mvEXlq9-4wOg7zR5cC..6Vr4alb5803W2n5PbA5ZLwCcJznKdmFX1pDoy_5hfOAC Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/77d41f0..efd7c81 TBR=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: If098b284229ccbc2cabf93026ea8fb957ed779d0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3183003Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#77073}
-
Lu Yahan authored
Change-Id: Ifa2236b650f78ad851930e69e0387d8952f197c1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3178142 Commit-Queue: Yahan Lu <yahan@iscas.ac.cn> Reviewed-by: Brice Dobry <brice.dobry@futurewei.com> Cr-Commit-Position: refs/heads/main@{#77072}
-
Lu Yahan authored
Change-Id: I71bc9fd393d2f53c982b85cd1cf6729e56a62f2d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3174619Reviewed-by: Ji Qiu <qiuji@iscas.ac.cn> Reviewed-by: Hannes Payer <hpayer@chromium.org> Commit-Queue: Yahan Lu <yahan@iscas.ac.cn> Cr-Commit-Position: refs/heads/main@{#77071}
-
jing.bao authored
Bug: v8:12228 Change-Id: Ifd813e6bff92e6a08cc41eb8f5b1848abe849cd3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3178540Reviewed-by: Zhi An Ng <zhin@chromium.org> Commit-Queue: Jing Bao <jing.bao@intel.com> Cr-Commit-Position: refs/heads/main@{#77070}
-
- 25 Sep, 2021 2 commits
-
-
Shu-yu Guo authored
Bug: chromium:1246752 Change-Id: If305d80e4f727e95dffb40a9c4fc551ce253b948 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3183729 Commit-Queue: Shu-yu Guo <syg@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/main@{#77069}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/c4acc0e..32fc064 Rolling v8/buildtools/linux64: git_revision:69ec4fca1fa69ddadae13f9e6b7507efa0675263..git_revision:de86ec4176235871a7cb335756987e41246dae4a Rolling v8/third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/4402489..a46a633 Rolling v8/third_party/aemu-linux-x64: 35rwW0ni0eziJ2doq4bSBym86edze8jHjf2fyZhjl8kC..y7X4kitLsRPSZc6ksrVllZRbH7mvEXlq9-4wOg7zR5cC Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/3d49e1c..444aba8 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/a6baf70..f35d350 Rolling v8/third_party/googletest/src: https://chromium.googlesource.com/external/github.com/google/googletest/+log/159c9ad..e4717df Rolling v8/third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/77c1323..dfa96e8 Rolling v8/tools/luci-go: git_revision:028cd41e0f4b2bec99d94c780caf2f978e09b182..git_revision:e9585787c808e21d6eaa2c7d7a928dbc19999172 Rolling v8/tools/luci-go: git_revision:028cd41e0f4b2bec99d94c780caf2f978e09b182..git_revision:e9585787c808e21d6eaa2c7d7a928dbc19999172 Rolling v8/tools/luci-go: git_revision:028cd41e0f4b2bec99d94c780caf2f978e09b182..git_revision:e9585787c808e21d6eaa2c7d7a928dbc19999172 TBR=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: I4ea1bfbd22da816afaf413bd6e86c63aa91d4a39 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3182608Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#77068}
-
- 24 Sep, 2021 29 commits
-
-
Milad Fa authored
After https://crrev.com/c/3182223 gcc might throw the following error during compilation: ``` error: variable 'is_on_heap' set but not used ``` Bug: v8:11749 Change-Id: I31a2bef4adb1bfcb2b35115b4dea6df80f84f681 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3183165Reviewed-by: Omer Katz <omerkatz@chromium.org> Commit-Queue: Milad Fa <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/main@{#77067}
-
Ng Zhi An authored
Bug: v8:12244 Change-Id: I463eceb5b90f4b5b0efddcad7b1734e14d36944d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3183526Reviewed-by: Adam Klein <adamk@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/main@{#77066}
-
Ng Zhi An authored
Drive-by clean-up to move ADD_CODE, which is defined the same way in multiple files, into wasm-run-utils.h. R=adamk@chromium.org Bug: v8:12244 Change-Id: I61d54cf2c589c3f8b69950fba097d8754bb99c5a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3183524Reviewed-by: Adam Klein <adamk@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/main@{#77065}
-
Ng Zhi An authored
Rename the kNone enum in SimdPrefix to kNoPrefix R=adamk@chromium.org Bug: v8:12244 Change-Id: I8604dfadea24ce5f00c710de4d3c38da9d8a27a7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3182886Reviewed-by: Adam Klein <adamk@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/main@{#77064}
-
Omer Katz authored
Off heap members are "safe" to reference dead objects since they are not connected to the object graph and do not ressurect the object. This is needed becuase Members are used as temporary on stack variables in Blink, e.g. when querying if a HeapHashMap contains a key. Bug: v8:11749 Change-Id: I7ab2559d00c366480a3efbc0512bb1d1f63b64e7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3182223Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/main@{#77063}
-
Jakob Kummerow authored
Bug: v8:12244,v8:12245 Change-Id: I3d9223f32bdc0d1cf7e5083996bc5707ab361e52 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3183162 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Auto-Submit: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/main@{#77062}
-
Ng Zhi An authored
R=adamk@chromium.org Bug: v8:12244 Change-Id: Ie925797bda5de937afaf345e3115e18c14a9e06d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3182882Reviewed-by: Adam Klein <adamk@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/main@{#77061}
-
Ng Zhi An authored
R=adamk@chromium.org Bug: v8:12244 Change-Id: I7d4bde96822fc238a04c76b848f2c55e93375c3e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3182880Reviewed-by: Adam Klein <adamk@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/main@{#77060}
-
Shu-yu Guo authored
https://chromium.googlesource.com/external/github.com/tc39/test262/+log/650e7ad..50dd431 Bug: v8:7834, v8:12240 Change-Id: I017d7a60a38c8935d279040eb5f4bdadda22317e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3182892 Commit-Queue: Shu-yu Guo <syg@chromium.org> Commit-Queue: Adam Klein <adamk@chromium.org> Auto-Submit: Shu-yu Guo <syg@chromium.org> Reviewed-by: Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/main@{#77059}
-
Junliang Yan authored
Port a0ace8a8 Original Message: In Liftoff, the result of table.grow was smi-untagged and sign-extended to a ptr-sized value. However the result is typed as i32, so the upper 32 bits should be cleared on 64 bit platforms. In particular this is observable when the value is used as an index for a memory operand, which leads to the repro in the attached issue. Match the TF behavior by untagging the value as a 32-bit int. Change-Id: I73ee1d29b830eae1fd4e680634b78317b04c069c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3183160Reviewed-by: Milad Fa <mfarazma@redhat.com> Commit-Queue: Junliang Yan <junyan@redhat.com> Cr-Commit-Position: refs/heads/main@{#77058}
-
Clemens Backes authored
Many instructions are declared using DECLARE_INSTRUCTION (via ASSEMBLER_INSTRUCTION_LIST), and each of them currently defined eight templates for different sizes and different number of arguments. This CL reduces this to three variadic templates per instruction. R=zhin@chromium.org Bug: v8:12244 Change-Id: Ibd75c55e757f917eb1e9b54c0a1a79632a1ba6d8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3181103Reviewed-by: Zhi An Ng <zhin@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/main@{#77057}
-
Clemens Backes authored
Some macros are redundant or unused. - WASM_RETURN1 is identical to WASM_RETURN. - WASM_RETURNN has an unused {count} parameter, and is otherwise identical to WASM_RETURN. - WASM_IFB is identical to WASM_IF. - WASM_CASE and WASM_CASE_BR are unused. - WASM_BR_TABLEV is unused. R=thibaudm@chromium.org Bug: v8:12244 Change-Id: Ie7be00351f2dfe38d6e84d80e157a85df37233a9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3178860Reviewed-by: Thibaud Michaud <thibaudm@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/main@{#77056}
-
Andreas Haas authored
R=clemensb@chromium.org Bug: v8:12244 Change-Id: I9d633fd3c79703ee65dc2f57b556fde4853cc35c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3181105Reviewed-by: Clemens Backes <clemensb@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/main@{#77055}
-
Clemens Backes authored
Instead of hand-coding a loop, use range-based for loops for iterating signatures. Similarly, {std::transform} can replace a hand-coded loop for constructing values from return types. R=thibaudm@chromium.org Bug: v8:12244 Change-Id: I467656650b731cbcb9ea57c54f5311885bb158dd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3181520Reviewed-by: Thibaud Michaud <thibaudm@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/main@{#77054}
-
Andreas Haas authored
R=jkummerow@chromium.org Bug: v8:12244 Change-Id: I6264a91caa1f961ea1fa27c372c53240d969e91a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3181527 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/main@{#77053}
-
Dominik Inführ authored
Bug: v8:12244, v8:12245 Change-Id: Ibea600e10d64be5e4da474ae501b88e4f4d9cc51 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3182228 Auto-Submit: Dominik Inführ <dinfuehr@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/main@{#77052}
-
Dominik Inführ authored
Bug: v8:12244, v8:12245 Change-Id: Iaa2d8be352bbe03882f531cc66ab36c15b2b2a75 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3182227 Auto-Submit: Dominik Inführ <dinfuehr@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/main@{#77051}
-
Andreas Haas authored
Rename the enum value to avoid variable shadowing. R=clemensb@chromium.org Bug: v8:12244 Change-Id: I96a3bee7615b44692bb9edfedf82c6020a803d0d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3181529Reviewed-by: Clemens Backes <clemensb@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/main@{#77050}
-
Andreas Haas authored
NameSectionKindCode::kFunction got shadowed by WasmCompilationResult::Kind::kFunction. NameSectionKindCode is not used often, so this CL just adds "Code" to all fields of this enum. R=clemensb@chromium.org Bug: v8:12244 Change-Id: I87155a43084b868f6c118ddc2e44cb9c35b4249b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3181535Reviewed-by: Clemens Backes <clemensb@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/main@{#77049}
-
Dominik Inführ authored
Bug: v8:12244, v8:12245 Change-Id: I718c7531a7bec24abbc1c5b23246828261d0b94b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3182221Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/main@{#77048}
-
Jakob Kummerow authored
Bug: v8:12244,v8:12245 Change-Id: I60eaad6a96f227a0c39f2f79806b38a2080296ef Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3182220 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Maya Lekova <mslekova@chromium.org> Auto-Submit: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/main@{#77047}
-
Milad Fa authored
Port e301d71f Original Commit Message: Because these instructions can trap, we don't want them to be reordered as freely as unprotected accesses. As part of this, make explicit which opcodes support a MemoryAccessMode. R=neis@chromium.org, joransiu@ca.ibm.com, junyan@redhat.com, midawson@redhat.com BUG= LOG=N Change-Id: I122a53a67c9d2b3b99c5c25395064b61969483a4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3181539Reviewed-by: Georg Neis <neis@chromium.org> Reviewed-by: Junliang Yan <junyan@redhat.com> Commit-Queue: Milad Fa <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/main@{#77046}
-
Michael Lippautz authored
Bug: v8:12244, v8:12245 Change-Id: Id6b9e0a3986fb04c1a949b26ecf20da652ddd097 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3181537 Auto-Submit: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Dominik Inführ <dinfuehr@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/main@{#77045}
-
Thibaud Michaud authored
In Liftoff, the result of table.grow was smi-untagged and sign-extended to a ptr-sized value. However the result is typed as i32, so the upper 32 bits should be cleared on 64 bit platforms. In particular this is observable when the value is used as an index for a memory operand, which leads to the repro in the attached issue. Match the TF behavior by untagging the value as a 32-bit int. R=clemensb@chromium.org CC=ahaas@chromium.org Bug: chromium:1251465 Change-Id: Ia57fd8a69ecb2787b42bbf8217e448976aa1dbd9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3173680Reviewed-by: Clemens Backes <clemensb@chromium.org> Reviewed-by: Andreas Haas <ahaas@chromium.org> Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/heads/main@{#77044}
-
Milad Fa authored
Port 4bbfc4b7 Original Commit Message: The argument is no longer in use. R=jgruber@chromium.org, joransiu@ca.ibm.com, junyan@redhat.com, midawson@redhat.com BUG= LOG=N Change-Id: I06095fc237ae19ece4586d60b048785d7efa4ac3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3179268Reviewed-by: Junliang Yan <junyan@redhat.com> Commit-Queue: Milad Fa <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/main@{#77043}
-
Omer Katz authored
Bug: v8:12244,v8:12245 Change-Id: Ic2d324fa5a3bde18b4fdbe7d64e44c7fc9ccd4ea Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3181534Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/main@{#77042}
-
Samuel Groß authored
Attempts to allocate memory pages inside the virtual memory cage are currently allowed to fall back to allocating them outside of the cage if necessary. When this will be forbidden in the future, these cases will turn into allocation failures. To estimate the frequency of such events, we now record the outcome of allocation attempts for memory inside the cage into UMA. Bug: chromium:1218005 Change-Id: I788fdd968eea10c887eaba1585cd7951823246e0 Cq-Include-Trybots: luci.v8.try:v8_linux64_heap_sandbox_dbg_ng Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3178520Reviewed-by: Igor Sheludko <ishell@chromium.org> Commit-Queue: Samuel Groß <saelo@chromium.org> Cr-Commit-Position: refs/heads/main@{#77041}
-
Michael Lippautz authored
Bug: v8:12244,v8:12245 Change-Id: Ic73482248fdf36929f597626db13462401f098e8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3181530Reviewed-by: Dominik Inführ <dinfuehr@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/main@{#77040}
-
Andreas Haas authored
R=thibaudm@chromium.org Bug: v8:12244 Change-Id: I36a44660b8b41a4b9dc44a1143b2cc0c2f88a040 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3181523Reviewed-by: Thibaud Michaud <thibaudm@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/main@{#77039}
-